mirror of
https://github.com/rust-lang/rust.git
synced 2025-02-22 20:03:37 +00:00
8ecaad85f6
Fix stack overflow in recursive AST walk in early lint The src/test/ui/issues/issue-74564-if-expr-stack-overflow.rs test case added to verify https://github.com/rust-lang/rust/issues/74564 still crashes with a stack overflow on s390x-ibm-linux. Symptom is a very deep recursion in compiler/rustc_lint/src/early.rs: fn visit_expr(&mut self, e: &'a ast::Expr) { self.with_lint_attrs(e.id, &e.attrs, |cx| { lint_callback!(cx, check_expr, e); ast_visit::walk_expr(cx, e); }) } (where walk_expr recursively calls back into visit_expr). The crash happens at a nesting depth of over 17000 stack frames when using the default 8 MB stack size on s390x. This patch fixes the problem by adding a ensure_sufficient_stack call to the with_lint_attrs routine (which also should take care of all the other mutually recursive visitors here). Fixes part of https://github.com/rust-lang/rust/issues/105383. |
||
|---|---|---|
| .. | ||
| nonstandard_style | ||
| array_into_iter.rs | ||
| builtin.rs | ||
| context.rs | ||
| deref_into_dyn_supertrait.rs | ||
| early.rs | ||
| enum_intrinsics_non_enums.rs | ||
| errors.rs | ||
| expect.rs | ||
| for_loops_over_fallibles.rs | ||
| hidden_unicode_codepoints.rs | ||
| internal.rs | ||
| late.rs | ||
| let_underscore.rs | ||
| levels.rs | ||
| lib.rs | ||
| methods.rs | ||
| non_ascii_idents.rs | ||
| non_fmt_panic.rs | ||
| nonstandard_style.rs | ||
| noop_method_call.rs | ||
| opaque_hidden_inferred_bound.rs | ||
| pass_by_value.rs | ||
| passes.rs | ||
| redundant_semicolon.rs | ||
| tests.rs | ||
| traits.rs | ||
| types.rs | ||
| unused.rs | ||