mirror of
https://github.com/rust-lang/rust.git
synced 2025-06-05 11:48:30 +00:00
3e3a4192d8
`MacArgs` is an enum with three variants: `Empty`, `Delimited`, and `Eq`. It's used in two ways: - For representing attribute macro arguments (e.g. in `AttrItem`), where all three variants are used. - For representing function-like macros (e.g. in `MacCall` and `MacroDef`), where only the `Delimited` variant is used. In other words, `MacArgs` is used in two quite different places due to them having partial overlap. I find this makes the code hard to read. It also leads to various unreachable code paths, and allows invalid values (such as accidentally using `MacArgs::Empty` in a `MacCall`). This commit splits `MacArgs` in two: - `DelimArgs` is a new struct just for the "delimited arguments" case. It is now used in `MacCall` and `MacroDef`. - `AttrArgs` is a renaming of the old `MacArgs` enum for the attribute macro case. Its `Delimited` variant now contains a `DelimArgs`. Various other related things are renamed as well. These changes make the code clearer, avoids several unreachable paths, and disallows the invalid values. |
||
|---|---|---|
| .. | ||
| nonstandard_style | ||
| array_into_iter.rs | ||
| builtin.rs | ||
| context.rs | ||
| early.rs | ||
| enum_intrinsics_non_enums.rs | ||
| errors.rs | ||
| expect.rs | ||
| for_loops_over_fallibles.rs | ||
| hidden_unicode_codepoints.rs | ||
| internal.rs | ||
| late.rs | ||
| let_underscore.rs | ||
| levels.rs | ||
| lib.rs | ||
| methods.rs | ||
| non_ascii_idents.rs | ||
| non_fmt_panic.rs | ||
| nonstandard_style.rs | ||
| noop_method_call.rs | ||
| opaque_hidden_inferred_bound.rs | ||
| pass_by_value.rs | ||
| passes.rs | ||
| redundant_semicolon.rs | ||
| tests.rs | ||
| traits.rs | ||
| types.rs | ||
| unused.rs | ||