rust/crates
bors[bot] 0fb5d9d87a
Merge #6033
6033: Make name resolution resolve proc macros instead of relying purely on the build system r=matklad a=jonas-schievink

This makes name resolution look at proc-macro declaration attributes like `#[proc_macro_derive]` and defines the right proc macro in the macro namespace, fixing unresolved custom derives like `thiserror::Error` (which can cause false positives, now that we emit diagnostics for unresolved imports).

This works even when proc-macro support is turned off, in which case we fall back to a dummy expander that always returns an error. IMO this is the right way to handle at least the name resolution part of proc. macros, while the *expansion* itself should rely on the build system to build and provide the macro DLL. It does mean that they may go out of sync, but we can provide diagnostics if that happens (something like "could not find macro X in crate Y – ensure that all files of crate Y are saved").

I think it is valuable to be able to reason about proc macros even when we can't expand them, since proc macro expansion can break between Rust releases or users might not want to turn it on for performance reasons. It allows us to provide better diagnostics on any proc macro invocation we're not expanding (like a weak warning that informs the user that proc macro support is turned off, or that it has been disabled because the server crashed).

Fixes https://github.com/rust-analyzer/rust-analyzer/issues/5763

Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
2020-09-28 11:03:47 +00:00
..
arena Add TBD description to arena 2020-08-24 13:29:10 +02:00
assists Remove partial import test in insert_use 2020-09-25 15:21:50 +02:00
base_db Move most of the logic into the completion module 2020-09-10 01:42:20 +03:00
cfg Add description for crates that will be published 2020-08-24 13:07:22 +02:00
flycheck Spawn a flycheck instance per workspace 2020-09-27 19:41:54 +02:00
hir Don't unnecessarily unnest imports for import insertion 2020-09-25 15:19:22 +02:00
hir_def Merge #6033 2020-09-28 11:03:47 +00:00
hir_expand Merge #6033 2020-09-28 11:03:47 +00:00
hir_ty Update chalk to 0.28.0 2020-09-25 15:29:31 +02:00
ide Merge #6055 2020-09-25 11:55:35 +00:00
ide_db Rename record_field_pat to record_pat_field 2020-09-10 18:56:04 +02:00
mbe Bump smol_str from 0.1.16 to 0.1.17 2020-09-24 16:39:08 +02:00
parser Rename record_field_pat to record_pat_field 2020-09-10 18:56:04 +02:00
paths Add description for crates that will be published 2020-08-24 13:07:22 +02:00
proc_macro_api Add description for crates that will be published 2020-08-24 13:07:22 +02:00
proc_macro_srv Add description for crates that will be published 2020-08-24 13:07:22 +02:00
proc_macro_test Add description for crates that will be published 2020-08-24 13:07:22 +02:00
profile Add description for crates that will be published 2020-08-24 13:07:22 +02:00
project_model Merge #6018 2020-09-20 19:25:09 +00:00
rust-analyzer Spawn a flycheck instance per workspace 2020-09-27 19:41:54 +02:00
ssr ⬆️ expect-test 2020-08-28 14:47:14 +02:00
stdx Add description for crates that will be published 2020-08-24 13:07:22 +02:00
syntax Rename impl edit method to be more explicit 2020-09-21 10:01:50 +01:00
test_utils Add description for crates that will be published 2020-08-24 13:07:22 +02:00
text_edit Actually assert disjointness 2020-09-03 13:37:36 +02:00
toolchain Add description for crates that will be published 2020-08-24 13:07:22 +02:00
tt Add description for crates that will be published 2020-08-24 13:07:22 +02:00
vfs Rename the method to avoid false promises 2020-09-10 01:45:49 +03:00
vfs-notify Add description for crates that will be published 2020-08-24 13:07:22 +02:00