bors d03fe84169 Auto merge of #79328 - c410-f3r:hir-if, r=matthewjasper ... Reintroduce hir::ExprKind::If Basically copied and paste #59288/https://github.com/rust-lang/rust-clippy/pull/4080 with some modifications. The vast majority of tests were fixed and now there are only a few remaining. Since I am still unable to figure out the missing pieces, any help with the following list is welcome. - [ ] **Unnecessary `typeck` exception**: [Cheated on this one to make CI green.](https://github.com/rust-lang/rust/pull/79328/files#diff-3faee9ba23fc54a12b7c43364ba81f8c5660045c7e1d7989a02a0cee1c5b2051) - [x] **Incorrect span**: [Span should reference `then` and `else` separately.](https://github.com/rust-lang/rust/pull/79328/files#diff-cf2c46e82222ee4b1037a68fff8a1af3c4f1de7a6b3fd798aacbf3c0475abe3d) - [x] **New note regarding `assert!`**: [Modified but not "wrong". Maybe can be a good thing?](https://github.com/rust-lang/rust/pull/79328/files#diff-9e0d7c89ed0224e2b62060c957177c27db43c30dfe3c2974cb6b5091cda9cfb5) - [x] **Inverted report location**: [Modified but not "wrong". Locations were inverted.](https://github.com/rust-lang/rust/pull/79328/files#diff-f637ce7c1f68d523a165aa9651765df05e36c4d7d279194b1a6b28b48a323691) - [x] **`src/test/ui/point-to-type-err-cause-on-impl-trait-return.rs` has weird errors**: [Not sure why this is happening.](https://github.com/rust-lang/rust/pull/79328/files#diff-c823c09660f5b112f95e97e8ff71f1797b6c7f37dbb3d16f8e98bbaea8072e95) - [x] **Missing diagnostic**: [???](https://github.com/rust-lang/rust/pull/79328/files#diff-6b8ab09360d725ba4513933827f9796b42ff9522b0690f80b76de067143af2fc)		2021-01-14 14:41:58 +00:00
..
liveness	Move RWUTable to a separate module	2020-12-09 00:00:00 +00:00
check_attr.rs	Separate out a hir::Impl struct	2021-01-12 20:32:33 -05:00
check_const.rs	Reintroduce hir::ExprKind::If	2021-01-07 18:54:12 -03:00
dead.rs	Separate out a hir::Impl struct	2021-01-12 20:32:33 -05:00
diagnostic_items.rs	Use visitor for its very purpose.	2020-11-26 21:32:29 +01:00
entry.rs	Formatting.	2020-11-26 21:32:29 +01:00
hir_id_validator.rs	Do not visit ForeignItemRef for HIR indexing and validation.	2020-11-28 18:08:17 +01:00
hir_stats.rs	rustc_ast: visit_mac -> visit_mac_call	2020-11-03 23:39:51 +03:00
intrinsicck.rs	Fix small typo	2021-01-10 21:24:32 -08:00
lang_items.rs	Store ForeignItem in a side table.	2020-11-26 21:29:27 +01:00
layout_test.rs	Store ForeignItem in a side table.	2020-11-26 21:29:27 +01:00
lib_features.rs	mv compiler to compiler/	2020-08-30 18:45:07 +03:00
lib.rs	Validate use of parameters in naked functions	2020-11-25 00:00:00 +00:00
liveness.rs	Reintroduce hir::ExprKind::If	2021-01-07 18:54:12 -03:00
loops.rs	mv compiler to compiler/	2020-08-30 18:45:07 +03:00
naked_functions.rs	Reintroduce hir::ExprKind::If	2021-01-07 18:54:12 -03:00
reachable.rs	Separate out a hir::Impl struct	2021-01-12 20:32:33 -05:00
region.rs	Reintroduce hir::ExprKind::If	2021-01-07 18:54:12 -03:00
stability.rs	Separate out a hir::Impl struct	2021-01-12 20:32:33 -05:00
upvars.rs	mv compiler to compiler/	2020-08-30 18:45:07 +03:00
weak_lang_items.rs	Collapse all uses of target.options.foo into target.foo	2020-11-08 17:29:13 +03:00