mirror of
https://github.com/rust-lang/rust.git
synced 2025-05-14 02:49:40 +00:00
06e02d5b25
Don't warn an empty pattern unreachable if we're not sure the data is valid Exhaustiveness checking used to be naive about the possibility of a place containing invalid data. This could cause it to emit an "unreachable pattern" lint on an arm that was in fact reachable, as in https://github.com/rust-lang/rust/issues/117119. This PR fixes that. We now track whether a place that is matched on may hold invalid data. This also forced me to be extra precise about how exhaustiveness manages empty types. Note that this now errs in the opposite direction: the following arm is truly unreachable (because the binding causes a read of the value) but not linted as such. I'd rather not recommend writing a `match ... {}` that has the implicit side-effect of loading the value. [Never patterns](https://github.com/rust-lang/rust/issues/118155) will solve this cleanly. ```rust match union.value { _x => unreachable!(), } ``` I recommend reviewing commit by commit. I went all-in on the test suite because this went through a lot of iterations and I kept everything. The bit I'm least confident in is `is_known_valid_scrutinee` in `check_match.rs`. Fixes https://github.com/rust-lang/rust/issues/117119. |
||
|---|---|---|
| .. | ||
| dep_graph | ||
| hir | ||
| hooks | ||
| infer | ||
| middle | ||
| mir | ||
| query | ||
| thir | ||
| traits | ||
| ty | ||
| util | ||
| arena.rs | ||
| error.rs | ||
| lib.rs | ||
| lint.rs | ||
| macros.rs | ||
| metadata.rs | ||
| tests.rs | ||
| thir.rs | ||
| values.rs | ||