mirror of
https://github.com/rust-lang/rust.git
synced 2025-06-04 19:29:07 +00:00
bfe032334f
`E0229`: Suggest Moving Type Constraints to Type Parameter Declaration Fixes #113073 This PR suggests `impl<T: Bound> Trait<T> for Foo` when finding `impl Trait<T: Bound> for Foo`. Tangentially, it also improves a handful of other error messages. It accomplishes this in two steps: 1. Check if constrained arguments and parameter names appear in the same order and delay emitting "incorrect number of generic arguments" error because it can be confusing for the programmer to see `0 generic arguments provided` when there are `n` constrained generic arguments. 2. Inside `E0229`, suggest declaring the type parameter right after the `impl` keyword by finding the relevant impl block's span for type parameter declaration. This also handles lifetime declarations correctly. Also, the multi part suggestion doesn't use the fluent error mechanism because translating all the errors to fluent style feels outside the scope of this PR. I will handle it in a separate PR if this gets approved. |
||
|---|---|---|
| .. | ||
| check | ||
| coherence | ||
| collect | ||
| errors | ||
| hir_ty_lowering | ||
| impl_wf_check | ||
| outlives | ||
| structured_errors | ||
| variance | ||
| autoderef.rs | ||
| bounds.rs | ||
| check_unused.rs | ||
| collect.rs | ||
| constrained_generic_params.rs | ||
| errors.rs | ||
| hir_wf_check.rs | ||
| impl_wf_check.rs | ||
| lib.rs | ||
| structured_errors.rs | ||