mirror of
https://github.com/rust-lang/rust.git
synced 2025-05-14 02:49:40 +00:00
016e9b5e33
rustc: Allow safe #[target_feature] on wasm This commit updates the compiler's handling of the `#[target_feature]` attribute when applied to functions on WebAssembly-based targets. The compiler in general requires that any functions with `#[target_feature]` are marked as `unsafe` as well, but this commit relaxes the restriction for WebAssembly targets where the attribute can be applied to safe functions as well. The reason this is done is that the motivation for this feature of the compiler is not applicable for WebAssembly targets. In general the `#[target_feature]` attribute is used to enhance target CPU features enabled beyond the basic level for the rest of the compilation. If done improperly this means that your program could execute an instruction that the CPU you happen to be running on does not understand. This is considered undefined behavior where it is unknown what will happen (e.g. it's not a deterministic `SIGILL`). For WebAssembly, however, the target is different. It is not possible for a running WebAssembly program to execute an instruction that the engine does not understand. If this were the case then the program would not have validated in the first place and would not run at all. Even if this were allowed in some hypothetical future where engines have some form of runtime feature detection (which they do not right now) any implementation of such a feature would generate a trap if a module attempts to execute an instruction the module does not understand. This deterministic trap behavior would still not fall into the category of undefined behavior because the trap is deterministic. For these reasons the `#[target_feature]` attribute is now allowed on safe functions, but only for WebAssembly targets. This notably enables the wasm-SIMD intrinsics proposed for stabilization in #74372 to be marked as safe generally instead of today where they're all `unsafe` due to the historical implementation of `#[target_feature]` in the compiler. |
||
|---|---|---|
| .. | ||
| check_consts | ||
| coverage | ||
| inline | ||
| add_call_guards.rs | ||
| add_moves_for_packed_drops.rs | ||
| add_retag.rs | ||
| check_const_item_mutation.rs | ||
| check_packed_ref.rs | ||
| check_unsafety.rs | ||
| cleanup_post_borrowck.rs | ||
| const_debuginfo.rs | ||
| const_goto.rs | ||
| const_prop.rs | ||
| deaggregator.rs | ||
| deduplicate_blocks.rs | ||
| dest_prop.rs | ||
| dump_mir.rs | ||
| early_otherwise_branch.rs | ||
| elaborate_drops.rs | ||
| function_item_references.rs | ||
| generator.rs | ||
| inline.rs | ||
| instcombine.rs | ||
| lower_intrinsics.rs | ||
| match_branches.rs | ||
| mod.rs | ||
| multiple_return_terminators.rs | ||
| no_landing_pads.rs | ||
| nrvo.rs | ||
| promote_consts.rs | ||
| remove_noop_landing_pads.rs | ||
| remove_storage_markers.rs | ||
| remove_unneeded_drops.rs | ||
| remove_zsts.rs | ||
| required_consts.rs | ||
| rustc_peek.rs | ||
| simplify_branches.rs | ||
| simplify_comparison_integral.rs | ||
| simplify_try.rs | ||
| simplify.rs | ||
| uninhabited_enum_branching.rs | ||
| unreachable_prop.rs | ||
| validate.rs | ||