Matthias Krüger 026d56b0f6 Rollup merge of #139967 - jieyouxu:auxiliary, r=wesleywiser ... Introduce and use specialized `//@ ignore-auxiliary` for test support files instead of using `//@ ignore-test` ### Summary Add a semantically meaningful directive for ignoring test *auxiliary* files. This is for auxiliary files that *participate* in actual tests but should not be built by `compiletest` (i.e. these files are involved through `mod xxx;` or `include!()` or `#[path = "xxx"]`, etc.). ### Motivation A specialized directive like `//@ ignore-auxiliary` makes it way easier to audit disabled tests via `//@ ignore-test`. - These support files cannot use the canonical `auxiliary/` dir because they participate in module resolution or are included, or their relative paths can be important for test intention otherwise. Follow-up to: - #139705 - #139783 - #139740 See also discussions in: - [#t-compiler > Directive name for non-test aux files?](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Directive.20name.20for.20non-test.20aux.20files.3F/with/512773817) - [#t-compiler > Handling disabled &#96;//@ ignore-test&#96; tests](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Handling.20disabled.20.60.2F.2F.40.20ignore-test.60.20tests/with/512005974) - [#t-compiler/meetings > &#91;steering&#93; 2025-04-11 Dealing with disabled tests](https://rust-lang.zulipchat.com/#narrow/channel/238009-t-compiler.2Fmeetings/topic/.5Bsteering.5D.202025-04-11.20Dealing.20with.20disabled.20tests/with/511717981) ### Remarks on remaining unconditionally disabled tests under `tests/` After this PR, against commit 79a272c640, only **14** remaining test files are disabled through `//@ ignore-test`: <details> <summary>Remaining `//@ ignore-test` files under `tests/`</summary> ``` tests/debuginfo/drop-locations.rs 4://@ ignore-test (broken, see #128971) tests/rustdoc/macro-document-private-duplicate.rs 1://@ ignore-test (fails spuriously, see issue #89228) tests/rustdoc/inline_cross/assoc-const-equality.rs 3://@ ignore-test (FIXME: #125092) tests/ui/match/issue-27021.rs 7://@ ignore-test (#54987) tests/ui/match/issue-26996.rs 7://@ ignore-test (#54987) tests/ui/issues/issue-49298.rs 9://@ ignore-test (#54987) tests/ui/issues/issue-59756.rs 2://@ ignore-test (rustfix needs multiple suggestions) tests/ui/precondition-checks/write.rs 5://@ ignore-test (unimplemented) tests/ui/precondition-checks/read.rs 5://@ ignore-test (unimplemented) tests/ui/precondition-checks/write_bytes.rs 5://@ ignore-test (unimplemented) tests/ui/explicit-tail-calls/drop-order.rs 2://@ ignore-test: tail calls are not implemented in rustc_codegen_ssa yet, so this causes 🧊 tests/ui/panics/panic-short-backtrace-windows-x86_64.rs 3://@ ignore-test (#92000) tests/ui/json/json-bom-plus-crlf-multifile-aux.rs 3://@ ignore-test Not a test. Used by other tests tests/ui/traits/next-solver/object-soundness-requires-generalization.rs 2://@ ignore-test (see #114196) ``` </details> Of these, most are either **unimplemented**, or **spurious**, or **known-broken**. The outstanding one is `tests/ui/json/json-bom-plus-crlf-multifile-aux.rs` which I did not want to touch in *this* PR -- that aux file has load-bearing BOM and carriage returns and byte offset matters. I think those test files that require special encoding / BOM probably are better off as `run-make` tests. See #139968 for that aux file. ### Review advice - Best reviewed commit-by-commit. - The directive name diverged from the most voted `//@ auxiliary` because I think that's easy to confuse with `//@ aux-{crate,dir}`. r? compiler		2025-04-17 21:53:25 +02:00
..
bad-format-args.rs
bad-format-args.stderr
coherence-overlapping-inherent-impl-trait.rs
coherence-overlapping-inherent-impl-trait.stderr	Show number in error message even for one error	2023-11-24 19:15:52 +01:00
empty_span.rs
empty_span.stderr	Show number in error message even for one error	2023-11-24 19:15:52 +01:00
huge_multispan_highlight.ascii.svg	Filter empty lines, comments and delimiters from previous to last multiline span rendering	2024-12-12 23:36:27 +00:00
huge_multispan_highlight.rs	Don't allow -Zunstable-options to take a value	2024-11-18 18:04:59 +11:00
huge_multispan_highlight.unicode.svg	Filter empty lines, comments and delimiters from previous to last multiline span rendering	2024-12-12 23:36:27 +00:00
issue-11715.rs	Remove attribute #[rustc_error]	2025-03-30 01:32:21 +03:00
issue-11715.stderr	Remove attribute #[rustc_error]	2025-03-30 01:32:21 +03:00
issue-28308.rs
issue-28308.stderr	Do not suggest using -Zmacro-backtrace for builtin macros	2025-03-14 19:50:03 +00:00
one_line.rs
one_line.stderr	Show number in error message even for one error	2023-11-24 19:15:52 +01:00
overlapping_inherent_impls.rs
overlapping_inherent_impls.stderr
tab_2.rs
tab_2.stderr	Refactor emitter to better account for unicode chars when trimming	2025-03-07 17:55:08 +00:00
tab_3.rs
tab_3.stderr	Show number in error message even for one error	2023-11-24 19:15:52 +01:00
tab.rs
tab.stderr	Point to where missing return type should go	2023-10-04 21:09:54 +00:00
two_files_data.rs	tests: use //@ ignore-auxiliary with backlinked primary test file	2025-04-17 19:45:28 +08:00
two_files.rs
two_files.stderr	Show diff suggestion format on verbose replacement	2025-02-10 20:21:39 +00:00
unicode_2.rs
unicode_2.stderr
unicode_3.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
unicode_3.stderr
unicode.expanded.stdout	Explicitly annotate edition for unpretty=expanded and unpretty=hir tests	2025-04-16 11:10:10 +02:00
unicode.normal.stderr	Explicitly annotate edition for unpretty=expanded and unpretty=hir tests	2025-04-16 11:10:10 +02:00
unicode.rs	Explicitly annotate edition for unpretty=expanded and unpretty=hir tests	2025-04-16 11:10:10 +02:00