LeSeulArtichaut
fc0af8e4d8
never_loop: suggest using an if let instead of a for loop
2021-08-11 16:35:33 +02:00
bors
4e760b675c
Auto merge of #7522 - dswij:map-flatten-result, r=llogiq
...
Cover `Result` on `map_flatten` lint
Closes #7496
changelog: `[map_flatten]` handles `Result` type
2021-08-02 07:27:09 +00:00
bors
b6c23297bf
Auto merge of #7519 - Jarcho:rustfmt_fix, r=giraffate
...
Workaround rust-lang/rustfmt#4477 - relative paths in `path` attribute
See rust-lang/rustfmt#4477
changelog: None
2021-08-02 00:56:54 +00:00
Dharma Saputra Wijaya
69d439065e
Handle Result on map_flatten lint
...
Adds a check on `.map(..).flatten()` on `Result` type that follows the
behaviour on `Option` type.
2021-08-01 17:47:54 +08:00
Jason Newcomb
205aa88921
Fix while_let_on_iterator
...
When the iterator is one field within a local correctly check for usages of the field
2021-07-31 09:32:54 -04:00
Jason Newcomb
fe75faa6ee
Fix while_let_on_iterator
...
Reborrow mutable references rather then take a reference to them.
2021-07-31 00:11:46 -04:00
Jason Newcomb
fc387b877a
Workaround rust-lang/rustfmt#4477 - relative paths in path attribute
2021-07-30 23:43:04 -04:00
flip1995
54e539121d
Rename two lints to comply with our lint naming convention
...
self_named_constructor -> self_named_constructors
append_instead_of_extend -> extend_with_drain
2021-07-29 12:10:18 +02:00
flip1995
490beda6be
Merge remote-tracking branch 'upstream/master' into rustup
2021-07-29 11:14:25 +02:00
Jacob Pratt
5331fea875
Update tests
2021-07-27 16:26:50 -04:00
bors
3214de3fe6
Auto merge of #7493 - xFrednet:7220-fix-new-without-default-impl-type, r=camsteffen
...
Prefer a code snipped over formatting the self type (`new_without_default`)
Fixes : rust-lang/rust-clippy#7220
changelog: [`new_without_default`]: The `Default` impl block type doesn't use the full type path qualification
Have a nice day to everyone reading this 🙃
2021-07-26 12:20:54 +00:00
bors
02d70f3604
Auto merge of #7477 - F3real:needless_continue, r=flip1995
...
Enhance needless continue to detect loop {continue;}
Fixes #7417
changelog: Report [`needless_continue`] in `loop { continue; }` case
2021-07-26 11:52:55 +00:00
xFrednet
89c8c3f4cd
Prefer a code snipped over formatting the self type (new_without_default)
2021-07-26 09:35:38 +02:00
Cameron Steffen
d3492a0894
author: check block.expr: None
2021-07-25 18:10:59 -05:00
Cameron Steffen
afe5962d38
clippy::author improvements
2021-07-23 17:03:12 -05:00
chaz-kiker
1b8fc8f13d
update clippy ui test 'future_not_send.stderr' to match
...
the new diagnostic messages
2021-07-23 12:55:13 -05:00
F3real
c3452f3bd2
Lint on continue expression without semi-colon
2021-07-22 22:23:59 +02:00
F3real
9d6127cdb0
Emit needless_continue warning if loop ends on continue
2021-07-21 23:32:16 +02:00
F3real
24ec35a904
Enhance needless continue to detect loop {continue;}
2021-07-20 19:26:45 +02:00
bors
610381455c
Auto merge of #7221 - th1000s:keyword_, r=giraffate
...
similar_names: No longer suggest inserting or appending an underscore
changelog: [`similar_names`] lint no longer suggests to insert or add an underscore to "fix" too similar names
2021-07-19 14:18:59 +00:00
flip1995
884ef4c287
Merge commit '4c41a222ca5d1325fb4b6709395bd06e766cc042' into clippyup
2021-07-19 11:52:05 +02:00
bors
f467750680
Auto merge of #7470 - DevinR528:fix-ice7447, r=flip1995
...
Add check if ty has_escaping_bound_vars in zero_sized_map_values lint
Fixes : #7447
changelog: fix ICE in [`zero_sized_map_values`]
2021-07-19 09:22:34 +00:00
bors
f70a07454b
Auto merge of #7403 - Anthuang:redundant-method-names, r=Manishearth
...
New lint: [`self_named_constructor`]
Adds the `self_named_constructor` lint for detecting when an implemented method has the same name as the type it is implemented for.
changelog: [`self_named_constructor`]
closes : #7142
2021-07-19 06:49:51 +00:00
Anthony Huang
e9e10d209e
Run bless
2021-07-19 01:21:06 -04:00
bors
46363df926
Auto merge of #7474 - camsteffen:binop, r=Manishearth
...
Use lang items for BinOp lints
changelog: none
2021-07-18 15:52:49 +00:00
Michael Howell
f882c363e2
fix(clippy): add missing allow(dyn_drop)
2021-07-18 07:57:03 -07:00
Cameron Steffen
98c500cf83
Factor BinOp utils
2021-07-17 20:49:19 -05:00
Jason Newcomb
5bfc2568a2
Fix ICE in is_integer_const when the expression is inside an AnonConst body
2021-07-17 19:01:19 -04:00
flip1995
b98e2ec527
Fix ICE in redundant_pattern_matching
2021-07-16 10:45:28 +02:00
Devin Ragotzy
7312611207
Add check if ty has_escaping_bound_vars in zero_sized_map_values lint
2021-07-15 18:37:02 -04:00
flip1995
1d084b13a5
Merge commit '54a20a02ecd0e1352a871aa0990bcc8b8b03173e' into clippyup
2021-07-15 10:44:10 +02:00
flip1995
69fbd64e2a
Merge remote-tracking branch 'upstream/master' into rustup
2021-07-15 10:32:06 +02:00
lyj
e575610fb3
redundant_allocation: add Arc; some refractoring.
2021-07-15 07:10:55 +08:00
bors
2b193e247f
Auto merge of #7462 - xFrednet:7369-branches-sharing-code-else-expr-fp, r=camsteffen
...
FP fix and documentation for `branches_sharing_code` lint
Closes rust-lang/rust-clippy#7369
Related rust-lang/rust-clippy#7452 I'm still thinking about the best way to fix this. I could simply add another visitor to ensure that the moved expressions don't modify values being used in the condition, but I'm not totally happy with this due to the complexity. I therefore only documented it for now
changelog: [`branches_sharing_code`] fixed false positive where block expressions would sometimes be ignored.
2021-07-14 20:29:56 +00:00
xFrednet
61e280863f
Fixed branches_sharing_code FP with block expressions in else
...
And added `branches_sharing_code` PF note to lint doc for `rust-clippy#7452`
2021-07-14 21:37:17 +02:00
bors
4acbff9eb0
Auto merge of #7437 - ebobrow:redundant-closure-move, r=flip1995
...
suggest `&mut` for redundant FnMut closures
fixes #6903
changelog: suggest `&mut` for redundant FnMut closures
2021-07-14 15:15:28 +00:00
Elliot Bobrow
4c398e07e0
suggest &mut for redundant FnMut closures
2021-07-14 07:56:27 -07:00
lyj
251c3b64da
fix 5707
2021-07-14 10:57:47 +08:00
Thomas Otto
e8f57c3ac4
No longer suggest inserting or appending an underscore
...
changelog: [`similar_names`] lint no longer suggests to insert or add an underscore
to "fix" too similar names
2021-07-13 23:21:24 +02:00
bors
8131445e53
Auto merge of #7446 - Y-Nak:fix-7445, r=xFrednet,flip1995
...
`default_numeric_fallback`: Fix FP with floating literal
Fix #7445
changelog: `default_numeric_fallback`: Fix FP with floating literal
2021-07-13 14:31:02 +00:00
Yoshitomo Nakanishi
25e4c7d73f
default_numeric_fallback: Add rustfix tests
2021-07-13 23:18:31 +09:00
Cameron Steffen
306f9e843d
Split a lint message into help
2021-07-13 08:57:16 -05:00
Cameron Steffen
20dbb277cf
Fix useless_format false positive
2021-07-13 08:57:16 -05:00
Yoshitomo Nakanishi
04aa3f7e9b
default_numeric_fallback: Add more tests for floating literal
2021-07-09 18:24:23 +09:00
Yoshitomo Nakanishi
3bc5abef62
default_numeric_fallback: Fix FP with floating literal
2021-07-08 11:37:12 +09:00
Ryan Levick
30c5c2ff03
Add s to non_fmt_panic
2021-07-06 20:12:56 +02:00
iobtl
eeefbb7617
fix false positive (panic message) with assert macro using message parameter
2021-07-06 15:14:53 +08:00
Anthony Huang
357a8f0344
Add redundant_method_names lint
2021-07-05 14:15:20 -04:00
Mateusz Gacek
59a164e86c
Add new lint: strlen_on_c_strings
2021-07-05 11:10:45 +02:00
Cameron Steffen
cb4670deb3
Fix use_self ICE
2021-07-03 12:40:50 -05:00
