bors
5dd0e1b7ae
Auto merge of #107671 - CastilloDel:master, r=estebank
...
Fix suggestions rendering when the diff span is multiline
Fixes #92741
cc `@estebank`
I think, I finally fixed. I still want to go back and try to clean up the code a bit. I'm open to suggestions.
Some examples of the new suggestions:
```
help: consider removing the borrow
|
2 - &
|
```
```
help: consider removing the borrow
|
2 - &
3 - mut
|
```
```
help: consider removing the borrow
|
2 - &
3 - mut if true { true } else { false }
2 + if true { true } else { false }
|
```
Should we add a test to ensure this behavior doesn't disappear in the future?
2023-02-07 13:29:45 +00:00
CastilloDel
f0830c0ade
Add run-rustfix to tests/ui/issues/issue-92741.rs
2023-02-06 15:34:47 +01:00
CastilloDel
039f70e926
Add more test cases to tests/ui/issues/issue-92741.rs
2023-02-06 15:30:29 +01:00
CastilloDel
9cdc07538d
Add UI test for issue #92741
2023-02-05 19:12:41 +01:00
Esteban Küber
da1360d981
Provide structured suggestion for binding needing type on E0594
...
Partially address #45405 .
2023-02-03 18:53:27 +00:00
Esteban Küber
5ae8e23816
Mention fn coercion rules (needs to be expanded)
2023-01-30 21:51:33 +00:00
Esteban Küber
153ed09fb3
Tweak use of trimmed paths
2023-01-30 20:12:21 +00:00
Esteban Küber
252c43b42b
Do not mention lifetime names in force trimmed paths
2023-01-30 20:12:21 +00:00
Esteban Küber
81973a39e0
Don't show for<'lt> in force trimmed paths
2023-01-30 20:12:21 +00:00
Esteban Küber
62ba3e70a1
Modify primary span label for E0308
...
The previous output was unintuitive to users.
2023-01-30 20:12:19 +00:00
Matthias Krüger
22e62a4fca
Rollup merge of #106944 - Nilstrieb:there-once-was-a-diagnostic, r=WaffleLapkin
...
Suggest using a lock for `*Cell: Sync` bounds
I mostly did this for `OnceCell<T>` at first because users will be confused to see that the `OnceCell<T>` in `std` isn't `Sync` but then extended it to `Cell<T>` and `RefCell<T>` as well.
2023-01-25 22:19:52 +01:00
Matthias Krüger
9e3f330656
Rollup merge of #106897 - estebank:issue-99430, r=davidtwco
...
Tweak E0597
CC #99430
2023-01-25 22:19:52 +01:00
Michael Goulet
e6400693b8
Rollup merge of #104154 - timrobertsdev:deny-by-default-bindings_with_variant_name, r=scottmcm
...
Change `bindings_with_variant_name` to deny-by-default
Changed the `bindings_with_variant_name` lint to deny-by-default and fixed up the affected tests.
Addresses #103442 .
2023-01-20 21:33:20 -05:00
--global
734f375019
Change bindings_with_variant_name to deny-by-default
2023-01-20 02:26:12 -05:00
Nilstrieb
6d0c91fda3
Add rustc_on_unimplemented on Sync for cell types
...
Suggest using a lock instead.
2023-01-19 21:09:25 +01:00
bohan
97ae79ac9d
add raw identifier for keyword in suggestion
2023-01-20 00:36:20 +08:00
Esteban Küber
7b8251e188
Account for method call and indexing when looking for inner-most path in expression
2023-01-17 02:52:43 +00:00
Esteban Küber
656db98bd9
Tweak E0597
...
CC #99430
2023-01-15 19:46:20 +00:00
Mara Bos
6821adb651
Deprioritize fulfillment errors that come from expansions.
2023-01-14 14:05:26 +01:00
Matthias Krüger
c6e3a47843
Rollup merge of #106585 - estebank:issue-46585, r=compiler-errors
...
When suggesting writing a fully qualified path probe for appropriate types
Address the more common part of #46585 .
2023-01-13 19:16:42 +01:00
Yuki Okushi
5adc7a5e37
Rollup merge of #106785 - compiler-errors:better-impl-wf-spans, r=estebank
...
Make blame spans better for impl wfcheck
r? types
2023-01-13 16:54:24 +09:00
Michael Goulet
5924c2511e
Only point at impl self ty in WF if trait predicate shares self ty
2023-01-12 22:25:30 +00:00
Michael Goulet
bf0623e363
Don't suggest dyn as parameter to add
2023-01-12 22:04:30 +00:00
Michael Goulet
950b47fb96
Render missing generics suggestion verbosely
2023-01-12 22:04:30 +00:00
Michael Goulet
2aabb0fd5d
Point at impl self type for impl wf obligations
2023-01-12 20:44:47 +00:00
Michael Goulet
d7113948d3
Rollup merge of #106524 - compiler-errors:constructor-note, r=cjgillot
...
Label `struct/enum constructor` instead of `fn item`, mention that it should be called on type mismatch
Fixes #106516
2023-01-11 22:25:49 -08:00
Michael Goulet
83d3b76ac2
Rollup merge of #106097 - mejrs:mir_build2, r=oli-obk
...
Migrate mir_build diagnostics 2 of 3
The first three commits are fairly boring, however I've made some changes to the output of the match checking diagnostics.
2023-01-11 22:25:47 -08:00
mejrs
31c20210b9
Migrate pattern matching
2023-01-11 14:40:02 -08:00
Esteban Küber
12ddf77811
When suggesting writing a fully qualified path probe for appropriate types
...
Fix #46585 .
2023-01-11 21:30:10 +00:00
Michael Goulet
d375440dab
label where constructor is defined and note that it should be called
2023-01-11 19:53:15 +00:00
Michael Goulet
ede5c31af4
Be more specific about constructor FnDefs in type mismatch
2023-01-11 19:53:14 +00:00
Michael Goulet
9a39d7e441
Note predicate span on ImplDerivedObligation
2023-01-11 19:46:45 +00:00
Albert Larsan
cf2dff2b1e
Move /src/test to /tests
2023-01-11 09:32:08 +00:00
