Aleksey Kladov
24ad1cce2c
Avoid premature pessimization
...
The extra allocation for message should not matter here at all, but
using a static string is just as ergonomic, if not more, and there's
no reason to write deliberately slow code
2020-02-02 18:56:37 +01:00
Aleksey Kladov
9d5a5211a4
Small cleanup
2020-01-31 13:34:44 +01:00
Aleksey Kladov
7cc0a86528
Fix long loop timeout
2020-01-29 14:04:10 +01:00
Aleksey Kladov
9753eb98cc
Complain loudly if the main loop is blocked
2020-01-29 11:21:49 +01:00
Aleksey Kladov
aaa4861a0b
More uniform naming
2020-01-29 11:15:08 +01:00
Aleksey Kladov
2d2585e03f
Don't compute diagnostics on the main thread
...
closes #2909
2020-01-29 11:03:59 +01:00
Aleksey Kladov
493a903f22
Bump main thread priority on windows
2020-01-26 14:15:57 +01:00
Aleksey Kladov
40109941db
Use default threadpool size
2020-01-25 13:27:36 +01:00
Aleksey Kladov
f44aee27d3
Disable env_logger humantime feature
...
We rarely care about timings of events, and, when we care, we need
millisecond precision
2020-01-25 11:53:40 +01:00
Aleksey Kladov
b90ea640e6
Cancel requests during shutdown
2020-01-24 16:35:37 +01:00
Emil Lauridsen
05aa5b854b
Remove RWLock from check watcher.
...
@matklad mentioned this might be a good idea.
So the general idea is that we don't really need the lock, as we can
just clone the check watcher state when creating a snapshot. We can then
use `Arc::get_mut` to get mutable access to the state from `WorldState`
when needed.
Running with this it seems to improve responsiveness a bit while cargo
is running, but I have no hard numbers to prove it. In any case, a
serialization point less is always better when we're trying to be
responsive.
2020-01-23 09:26:08 +01:00
kjeremy
ee7dd4b9ae
Update crates
2020-01-22 15:40:35 -05:00
Aleksey Kladov
bd96d0b258
Minimize visibility
2020-01-16 11:58:31 +01:00
Kirill Bulatov
d51cf7794d
itertools::Either -> either::Either
2020-01-15 20:20:20 +02:00
Kirill Bulatov
78a21253b4
Apply the api design suggestions
2020-01-15 20:17:17 +02:00
Kirill Bulatov
73dc8b6f06
Another attempt to add multiple edits
2020-01-15 20:16:27 +02:00
Emil Lauridsen
7a8c6351bf
Extract check task handling into function
2020-01-15 16:33:58 +01:00
Emil Lauridsen
478ba65f8d
Manage check state updates in main_loop to reduce lock contention
2020-01-15 15:50:49 +01:00
Jeremy Kolb
e1688be1bb
lsp-types 0.69.0
...
Stabilizes most proposed features
2020-01-15 08:05:42 -05:00
bors[bot]
876f92d547
Merge #2843
...
2843: Add inlay parameter name hints for call expr r=matklad a=imtsuki
This patch adds Intellij-like parameter name hints for literal values in function calls.
<img width="624" alt="Screenshot" src="https://user-images.githubusercontent.com/8423594/72366533-68d7f800-3735-11ea-9279-cf193ca8ca2f.png ">
Signed-off-by: imtsuki <me@qjx.app>
Co-authored-by: imtsuki <me@qjx.app>
2020-01-15 10:24:51 +00:00
imtsuki
c390e92fdd
Add inlay parameter name hints for function calls
...
Signed-off-by: imtsuki <me@qjx.app>
2020-01-15 01:18:52 +08:00
Jeremy Kolb
325912f01e
Tweak add_custom_impl
2020-01-14 09:08:45 -05:00
kjeremy
170c7bd7e3
Log client info if present
2020-01-13 16:20:47 -05:00
Emil Lauridsen
c774850fd8
Schedule check update regardless of notification setting
2020-01-13 17:22:21 +01:00
Emil Lauridsen
daca5a3711
Defer cargo check until after workspace load
2020-01-13 17:12:14 +01:00
Jeremy Kolb
9e71ff9636
Report macro calls as functions
2020-01-12 17:22:09 -05:00
bors[bot]
3924c7de50
Merge #2791
...
2791: Slightly more robust cargo watcher root search r=kiljacken a=kiljacken
Fixes #2780 (hopefully).
Use the already painstakingly found `workspaces` instead of naively using `folder_roots` from editor.
Co-authored-by: Emil Lauridsen <mine809@gmail.com>
2020-01-11 20:41:41 +00:00
Emil Lauridsen
8e778f9842
Clean up straggling mut
2020-01-11 21:37:01 +01:00
Emil Lauridsen
480c44918c
Disable cargo checking in workspaces with no cargo projects
2020-01-11 21:32:40 +01:00
Emil Lauridsen
d6da18e99d
Address nit
2020-01-10 22:41:52 +01:00
Emil Lauridsen
1d1eea217d
Slightly more robust cargo watcher root search
2020-01-10 22:10:26 +01:00
kjeremy
a633a6275a
Fix Write being sent down the wire.
...
Not sure what the deal is here but it wasn't sending Write.
2020-01-10 15:30:17 -05:00
Jeremy Kolb
d993f329a0
Basic DocumentHighlightKind support for assignments
2020-01-10 15:14:19 -05:00
Aleksey Kladov
cf5bdf464c
Merge pull request #2732 from detrumi/cargo-toml-not-found-message-toggle
...
Flag to hide cargo.toml not found error
2020-01-09 15:16:39 +01:00
Jeremy Kolb
1b19a8aa5e
Implement proposed CallHierarchy feature
...
See: https://github.com/microsoft/vscode-languageserver-node/blob/master/protocol/src/protocol.callHierarchy.proposed.ts
2020-01-08 10:15:49 -05:00
Mikhail Modin
fb25c91979
Adds a way to limits reference search by StructLiteral
2020-01-08 15:21:54 +01:00
Wilco Kusee
003620f0d6
Use downcasting for CargoTomlNotFoundError
2020-01-08 14:06:08 +01:00
Aleksey Kladov
072f0d323b
Fix back compat
2020-01-07 16:45:57 +01:00
Wilco Kusee
e7bb82c3a4
Allow disabling Cargo.toml not found error
2020-01-03 15:04:54 +01:00
Jeremy Kolb
35d72e40e2
Update dependencies
2020-01-01 17:51:48 -05:00
Aleksey Kladov
23bac12062
Retry inlay hints on content modified error
2019-12-30 22:20:04 +01:00
Emil Lauridsen
0d69d23d2f
Lowercase drive letters when getting paths from cargo check
2019-12-29 18:27:14 +01:00
Emil Lauridsen
c732f215cb
Don't finish main cargo watch thread when subprocess finishes.
2019-12-27 12:43:14 +01:00
Emil Lauridsen
428a6ff5b8
Move cargo watch functionality to separate crate
2019-12-27 11:10:07 +01:00
Emil Lauridsen
0cdbd08149
Keep VSCode config mostly backwards compatible
2019-12-25 20:26:06 +01:00
Emil Lauridsen
71d2d81dcc
Some documentatioN
2019-12-25 19:56:07 +01:00
Emil Lauridsen
069c165536
Actually respect disabling cargo check functionality
2019-12-25 19:17:54 +01:00
Emil Lauridsen
f7d04d0575
Re-format ra_lsp_server changes
2019-12-25 19:14:30 +01:00
Emil Lauridsen
178c23f505
Re-implement status display using LSP 3.15 progress event
2019-12-25 19:08:44 +01:00
Emil Lauridsen
c21fbc3e87
Migrate tests from extension to rust
2019-12-25 17:37:40 +01:00
