Commit Graph

414 Commits

Author SHA1 Message Date
Matthias Krüger
f25fee3349
Rollup merge of #133023 - samestep:hir-stats-total-count, r=nnethercote
Merge `-Zhir-stats` into `-Zinput-stats`

Currently `-Z hir-stats` prints the size and count of various kinds of nodes, and the total size of all the nodes it counted, but not the total count of nodes. So, before this PR:

```
$ git clone https://github.com/BurntSushi/ripgrep
$ cd ripgrep
$ cargo +nightly rustc -- -Z hir-stats
ast-stats-1 PRE EXPANSION AST STATS
ast-stats-1 Name                Accumulated Size         Count     Item Size
ast-stats-1 ----------------------------------------------------------------
ast-stats-1 ...
ast-stats-1 ----------------------------------------------------------------
ast-stats-1 Total                 93_576
ast-stats-1
ast-stats-2 POST EXPANSION AST STATS
ast-stats-2 Name                Accumulated Size         Count     Item Size
ast-stats-2 ----------------------------------------------------------------
ast-stats-2 ...
ast-stats-2 ----------------------------------------------------------------
ast-stats-2 Total              2_430_648
ast-stats-2
hir-stats HIR STATS
hir-stats Name                Accumulated Size         Count     Item Size
hir-stats ----------------------------------------------------------------
hir-stats ...
hir-stats ----------------------------------------------------------------
hir-stats Total              3_678_512
hir-stats
```

For consistency, this PR adds a total for the count as well:

```
$ cargo +stage1 rustc -- -Z hir-stats
ast-stats-1 PRE EXPANSION AST STATS
ast-stats-1 Name                Accumulated Size         Count     Item Size
ast-stats-1 ----------------------------------------------------------------
ast-stats-1 ...
ast-stats-1 ----------------------------------------------------------------
ast-stats-1 Total                 93_576                 1_877
ast-stats-1
ast-stats-2 POST EXPANSION AST STATS
ast-stats-2 Name                Accumulated Size         Count     Item Size
ast-stats-2 ----------------------------------------------------------------
ast-stats-2 ...
ast-stats-2 ----------------------------------------------------------------
ast-stats-2 Total              2_430_648                48_625
ast-stats-2
hir-stats HIR STATS
hir-stats Name                Accumulated Size         Count     Item Size
hir-stats ----------------------------------------------------------------
hir-stats ...
hir-stats ----------------------------------------------------------------
hir-stats Total              3_678_512                73_418
hir-stats
```

I wasn't sure if I was supposed to update `tests/ui/stats/hir-stats.stderr` to reflect this. I ran it locally, thinking it would fail, but it didn't:

```
$ ./x test tests/ui/stats
...

running 2 tests
i.

test result: ok. 1 passed; 0 failed; 1 ignored; 0 measured; 17949 filtered out
```

Also: is there a reason `-Z hir-stats` and `-Z input-stats` both exist? The former seems like it should completely supercede the latter. But strangely, the two give very different numbers for node counts:

```
$ cargo +nightly rustc -- -Z input-stats
...
Lines of code:             483
Pre-expansion node count:  2386
Post-expansion node count: 63844
```

That's a 30% difference in this case. Is it intentional that these numbers are so different? I see comments for both saying that they are merely approximations and should not be expected to be correct:

bd0826a452/compiler/rustc_ast_passes/src/node_count.rs (L1)

bd0826a452/compiler/rustc_passes/src/hir_stats.rs (L1-L3)
2024-11-19 09:19:20 +01:00
Jieyou Xu
75661c535f Tag src/build_helper with T-bootstrap 2024-11-18 20:07:03 +08:00
Jieyou Xu
1569414574 Tag more test suite changes with T-compiler 2024-11-18 20:03:57 +08:00
Jieyou Xu
dd688cb6c7 Opt out TaKO8Ki from review rotation for now 2024-11-16 16:51:39 +08:00
Sam Estep
090c24fbbf Merge -Zhir-stats into -Zinput-stats 2024-11-15 12:46:40 -05:00
onur-ozkan
2b8c345393 add myself into users_on_vacation on triagebot
Signed-off-by: onur-ozkan <work@onurozkan.dev>
2024-11-14 15:06:12 +03:00
许杰友 Jieyou Xu (Joe)
29889cca42 Unvacation 2024-11-13 21:35:46 +08:00
Matthias Krüger
b952f2ee4f
Rollup merge of #132962 - workingjubilee:add-codegen-reviewers, r=saethlin
triagebot: add codegen reviewers

Discussed with `@saethlin` off-sides
2024-11-12 23:26:45 +01:00
Jubilee Young
048824b773 triagebot: add codegen reviewers 2024-11-12 11:29:42 -08:00
Matthias Krüger
15fbae8ed9
Rollup merge of #132923 - fmease:triagebot-update-t-compiler, r=wesleywiser
Triagebot: Consolidate the T-compiler ad hoc assignment groups

https://github.com/rust-lang/compiler-team/issues/757

1. Inline compiler-team and compiler-team-contributors into compiler
2. Sort members alphabetically
2024-11-12 18:11:05 +01:00
León Orell Valerian Liehr
5b7423c2fc
Triagebot: Consolidate the T-compiler ad hoc groups 2024-11-12 00:33:23 +01:00
Matthias Krüger
2d026525db
Rollup merge of #132916 - fmease:unvac-me, r=fmease
Unvacation fmease

It's become a hindrance.
r? ghost
2024-11-11 21:58:34 +01:00
Matthias Krüger
f344169e7d
Rollup merge of #132881 - aDotInTheVoid:docs-for-docs, r=jieyouxu
triagebot: Autolabel rustdoc book

Inspired by #132876 not getting labeled as https://github.com/rust-lang/rust/labels/T-rustdoc

r? `@GuillaumeGomez`
2024-11-11 21:58:32 +01:00
León Orell Valerian Liehr
0a88d517c0
Unvacation fmease 2024-11-11 19:30:05 +01:00
Jacob Pratt
8253484854
Rollup merge of #132878 - aDotInTheVoid:less-pings-for-mark, r=GuillaumeGomez
triagebot: Assign rustdoc tests to T-rustdoc.

Should avoid situations like #132871, which got assigned to mark (via fallback) despite being a rustdoc change.

For now, I've assigned all our testsuites to the rustdoc group (whoever from T-Rustdoc is on review rotation), except the json one which is assigned to me.

CC `@rust-lang/rustdoc`

r? `@GuillaumeGomez`
2024-11-10 19:12:26 -05:00
Alona Enraght-Moony
bab112c2b8 triagebot: Autolabel rustdoc book 2024-11-10 22:05:07 +00:00
Alona Enraght-Moony
7e9c46b883 triagebot: Assign rustdoc tests to T-rustdoc. 2024-11-10 21:44:28 +00:00
Jieyou Xu
e49d9173f8 Break from review rotation 2024-11-11 02:27:09 +08:00
Jubilee
0ba177083f
Rollup merge of #132825 - Noratrieb:Noratrieb-patch-1, r=clubby789
Exclude relnotes-tracking-issue from needs-triage
2024-11-09 20:28:45 -08:00
nora
2b469607b4
Exclude relnotes-tracking-issue from needs-triage 2024-11-09 22:45:17 +01:00
Ralf Jung
b81e919f65 triagebot: ping wg-const-eval when relevant files change 2024-11-05 09:13:28 +01:00
Boxy
0900a1bd80 the unvacationer 2024-10-30 13:29:05 +00:00
Jubilee
9d58475760
Rollup merge of #132293 - Urgau:tests-check-cfg-out-triagebot, r=lqd
Remove myself from mentions inside `tests/ui/check-cfg` directory

This PR removes myself from mentions inside `tests/ui/check-cfg` directory.

I'm not sure this particular mention has ever been useful to me, and lately it's been too annoying for me to ignore it.

So remove my-self from it.
2024-10-29 03:11:44 -07:00
Urgau
5ae5323d0e Remove myself from mentions inside tests/ui/check-cfg directory 2024-10-28 22:23:56 +01:00
Noah Lev
d4774ff4ab Remove my ping for rustdoc/clean/types.rs
It was useful at one time, but now it just causes notification noise.
2024-10-28 14:32:40 -04:00
Matthias Krüger
13ec1b0c97
Rollup merge of #131875 - juntyr:wasm-notification-groups-triage, r=Mark-Simulacrum
Add WASM | WASI | Emscripten groups to triagebot.toml

Tracking issue: https://github.com/rust-lang/compiler-team/issues/799

~~This is blocked on amending the notification group section so that the instructions links point somewhere: https://github.com/rust-lang/rustc-dev-guide/pull/2100~~
2024-10-26 18:45:33 +02:00
Jubilee
0e307bb90e
Rollup merge of #132017 - celinval:smir-update-reviewerss, r=scottmcm
Update triagebot.toml

Update the list of reviewers after updating the team here: https://github.com/rust-lang/team/pull/1555
2024-10-21 20:32:02 -07:00
Matthias Krüger
fb42a4581b
Rollup merge of #131647 - jieyouxu:unicode-table-generator, r=Mark-Simulacrum
Register `src/tools/unicode-table-generator` as a runnable tool

It seems like `src/tools/unicode-table-generator` is not currently managed by bootstrap. This PR wires it up with bootstrap as a runnable tool.

This tool seems to take two possible args:

1. (Mandatory) path to `library/core/src/unicode/unicode_data.rs`, and
2. (Optional) path to generate a test file.

I only passed the mandatory path to `unicode_data.rs` in bootstrap and didn't do anything about (2). I'm not sure about how this tool is supposed to be run.

`Cargo.lock` is modified because I renamed `unicode-table-generator`'s bin name to match the tool name, as bootstrap's tool running logic expects the bin name to be derived from the tool name.

I also added a triagebot message to remind to not manually edit the library source file and edit the tool then regenerate instead, but this should probably be a tidy check (if that's desirable then that can be in a follow-up PR, though may be overkill).

Helps with #131640 but does not close it because still no docs.

r? `@Mark-Simulacrum` (since I think you authored this tool?)
2024-10-20 16:54:09 +02:00
Juniper Tyree
a4ffeb0263
Add WASM | WASI | Emscripten groups to triagebot.toml 2024-10-18 10:02:28 +03:00
Celina G. Val
67081dbb14
Update triagebot.toml
Update the list of reviewers after updating the team.
2024-10-17 18:18:01 -07:00
许杰友 Jieyou Xu (Joe)
9f42f9491d triagebot: tag PRs affecting compiletest with A-compiletest 2024-10-14 19:33:58 +08:00
许杰友 Jieyou Xu (Joe)
be89da5ab5 triagebot: add reminder for library/core/src/unicode/unicode_data.rs that it needs to be generated by tool
And should not be directly edited.
2024-10-13 19:45:25 +08:00
Matthias Krüger
0969882628
Rollup merge of #131497 - jieyouxu:spin, r=onur-ozkan
Add myself to bootstrap review rotation

r? `@onur-ozkan`
2024-10-11 12:21:06 +02:00
许杰友 Jieyou Xu (Joe)
57ae34ad3c Add myself to bootstrap review rotation 2024-10-10 19:02:58 +08:00
Jacob Pratt
e481599536
Add myself back to review rotation 2024-10-10 01:09:13 -04:00
许杰友 Jieyou Xu (Joe)
db6e31bba7 Remove myself from vacation 2024-10-07 23:40:17 +00:00
Michael Goulet
65cff8a1ef Mark Boxy as on vacation 2024-10-07 12:17:55 -04:00
Jubilee
8ec549492d
Rollup merge of #131238 - michaelwoerister:triagebot, r=michaelwoerister
Remove mw from triagebot.toml

cc https://github.com/rust-lang/team/pull/1565
2024-10-04 14:11:37 -07:00
Michael Woerister
ea3d336bbb Remove mw from triagebot.toml
cc https://github.com/rust-lang/team/pull/1565
2024-10-04 15:46:19 +02:00
许杰友 Jieyou Xu (Joe)
0369ee4c9b Week off of reviews to focus on docs
Dedicating a week to work on rustc-dev-guide.
2024-10-04 11:20:38 +00:00
naskya
8ba2c7d42b
fix minor typo in triagebot config 2024-09-27 12:58:16 +09:00
joboet
b0c2c9372a
readd @tgross35 and @joboet to the review rotation 2024-09-23 13:37:52 +02:00
Ibraheem Ahmed
f5223276bd
format 2024-09-18 01:10:16 -04:00
Ibraheem Ahmed
99ea16af1a
add myself to the libs review rotation 2024-09-18 01:07:30 -04:00
Ralf Jung
db40dc3168 notify Miri when intrinsics are changed 2024-09-11 16:31:05 +02:00
León Orell Valerian Liehr
93b4b2d51c
Temporarily remove fmease from the review rotation 2024-09-04 11:43:38 +02:00
Jakub Beránek
fa77b9d21c
Remove kobzol vacation status 2024-09-02 20:06:37 +02:00
Trevor Gross
a0073104ad Mark myself as on vacation for triagebot 2024-08-31 21:24:47 -05:00
joboet
f51289214c
mark joboet as on vacation 2024-08-30 21:28:42 +02:00
Thom Chiovoloni
5c6285c5f0 Add myself to the review rotation for libs 2024-08-23 19:16:01 +00:00