Commit Graph

211 Commits

Author SHA1 Message Date
Matthias Krüger
cf25110def
Rollup merge of #114157 - pitaj:triagebot_no-merges, r=ehuss
Enable triagebot no-merges check

Follow-up on https://github.com/rust-lang/triagebot/pull/1704

### Motivation

Occasionally, a merge commit like cb5c011670 makes it past manual review and gets merged into master.

At one point, we tried adding a check to CI to prevent this from happening (https://github.com/rust-lang/rust/pull/105058), but that ended up [problematic](https://github.com/rust-lang/rust/pull/106319#issuecomment-1368144076) and was [reverted](https://github.com/rust-lang/rust/pull/106320). This kind of check is simply too fragile for CI, and there must be a way for a human to override the bot's decision.

The capability to detect and warn about merge commits has been present in triagebot for quite some time, but was never enabled at rust-lang/rust, possibly due to concerns about false positives on rollup and subtree sync PRs. This PR intends to alleviate those concerns.

### Configuration

This configuration will exclude rollup PRs and subtree sync PRs from merge commit detection, and it will post the default warning message and add the `has-merge-commits` and `S-waiting-on-author` labels when merge commits are detected on other PRs.

The eventual vision is to have bors refuse to merge if the `has-merge-commits` label is present. A reviewer can still force the merge by removing that label if they so wish.

### Note for contributors

The rollup tool should add that label automatically, but anyone performing subtree updates should begin including "subtree update" in the titles of those PRs, to avoid false positives.

r? infra

## Open Questions

1. This configuration uses the default message that's built into triagebot:

> There are merge commits (commits with multiple parents) in your changes. We have a [no merge policy](https://rustc-dev-guide.rust-lang.org/git.html#no-merge-policy) so these commits will need to be removed for this pull request to be merged.
>
> You can start a rebase with the following commands:
> ```shell-session
> $ # rebase
> $ git rebase -i master
> $ # delete any merge commits in the editor that appears
> $ git push --force-with-lease
> ```

Any changes to this are easy, I'll just have to add a `message` option. Should we mention the excluded titles in the message?
2023-10-16 19:10:48 +02:00
Matthias Krüger
8feb7c55fe
Rollup merge of #116776 - WaffleLapkin:hell-yeah-review-requested, r=Mark-Simulacrum
Enable `review-requested` feature for rustbot

See https://github.com/rust-lang/triagebot/pull/1733.

r? `@Mark-Simulacrum`
2023-10-16 06:26:21 +02:00
Peter Jaszkowiak
4baa12bb94 Enable triagebot no-merges check
This configuration will exclude rollup PRs and subtree sync PRs from
merge commit detection. On other PRs, it will post the default warning
message and add the `has-merge-commits` and `S-waiting-on-author`
labels when merge commits are detected.

The eventual vision is to have bors refuse to merge if the
`has-merge-commits` label is present. A reviewer can still
force the merge by removing that label if they so wish.
2023-10-15 19:16:28 -06:00
Waffle Maybe
61a752a0f9
Enable review-requested feature for rustbot 2023-10-16 00:37:05 +02:00
Matthias Krüger
7a67562924
Rollup merge of #116755 - scottmcm:review-rotation, r=Mark-Simulacrum
Remove me from libcore review rotation

I'm looking at my commitments right now, and unfortunately this needs to go for at least a while.

If there's something in particular I can probably still take them, but I should drop out of the rotation for now.
2023-10-15 21:29:08 +02:00
Scott McMurray
b50aa24a4e Remove me from libcore review rotation 2023-10-15 00:49:44 -07:00
Guillaume Gomez
31b86ea6fc
Rollup merge of #116661 - WaffleLapkin:make-reviews-change-pr-state, r=Mark-Simulacrum
Make "request changes" reviews apply `S-waiting-on-author`

This makes it so **assignee** requesting changes on a PR via GitHub UI adds https://github.com/rust-lang/rust/labels/S-waiting-on-author and removes https://github.com/rust-lang/rust/labels/S-waiting-on-review.

cc `@compiler-errors` :3
2023-10-14 22:35:06 +02:00
Waffle Maybe
406fb86209
Make "request changes" reviews apply S-waiting-on-author 2023-10-12 17:36:39 +04:00
Waffle Maybe
a18729c496
Mark myself as vacation or whatever 2023-10-03 23:19:25 +04:00
bors
781ebbec8a Auto merge of #115898 - onur-ozkan:config-change-tracking, r=Mark-Simulacrum
bootstrap major change detection implementation

The use of `changelog-seen` and `bootstrap/CHANGELOG.md` has not been functional in any way for many years. We often do major/breaking changes but never update the changelog file or the `changelog-seen`. This is an alternative method for tracking major or breaking changes and informing developers when such changes occur.

Example output when bootstrap detects a major change:
![image](https://github.com/rust-lang/rust/assets/39852038/ee802dfa-a02b-488b-a433-f853ce079b8a)
2023-10-02 07:41:52 +00:00
onur-ozkan
7d3dcd918e add triagebot notification for bootstrap config changes
Signed-off-by: onur-ozkan <work@onurozkan.dev>
2023-10-01 16:55:46 +03:00
Oli Scherer
a38e98371b Split out the stable part of smir into its own crate to prevent accidental usage of forever unstable things 2023-09-25 14:38:27 +00:00
Nilstrieb
8e06b25e39
Remove TaKO8Ki from reviewers 2023-09-22 15:31:19 +02:00
Nikita Popov
4bb9c0f79b Allow anyone to set llvm-fixed-upstream
Allow llvm-* to be set by unauthenticated users, which is currently
llvm-main and llvm-fixed-upstream.
2023-09-20 07:49:23 +02:00
Mark Rousskov
d5643b1dec Expand infra-ci reviewer list 2023-09-18 10:13:49 -04:00
Jack Huey
c70ee688b3 Add me as on vacation 2023-09-17 12:08:08 -04:00
clubby789
731b221df3 Remove clubby789 from users_on_vacation 2023-09-13 21:13:05 +00:00
Santiago Pastorino
5860c4b006
Remove spastorino as "on vacation" 2023-09-11 16:55:34 -03:00
bors
af488be5f8 Auto merge of #115342 - GuillaumeGomez:fmease-rotations, r=rustdoc
Add `fmease` to rustdoc review rotations

`@fmease` asked me if it was okay for them to be part of the rustdoc review rotation. Since they are already reviewing a lot of rustdoc PRs, I think it's fine to add them to the rotation.

What do you think `@rust-lang/rustdoc` ?

r? rust-lang/rustdoc
2023-09-05 09:33:52 +00:00
Santiago Pastorino
8198c59c77
Add spastorino on vacation 2023-09-01 18:35:43 -03:00
Guillaume Gomez
b295d3e55e Add fmease to rustdoc review rotations 2023-08-29 15:30:38 +02:00
Oli Scherer
5a4ba686e3 Devacationize oli-obk 2023-08-28 15:33:09 +00:00
ozkanonur
879e106460 replace outdated github username 'ozkanonur'
Signed-off-by: ozkanonur <work@onurozkan.dev>
2023-08-27 06:26:02 +03:00
Dylan DPC
0718b75ecb
Rollup merge of #114930 - ChrisDenton:label-os, r=cuviper
Automatically add OS labels to std PRs

I'd love to have `library/std/src/sys` PRs that touch Windows stuff to have the `O-windows` label for easier discovery (and rediscovery). While I'm here I added a couple of other auto OS labels. Perhaps `O-unix` is a little too broad but it's hard to be more specific and I think it's still useful insomuch as POSIX is a thing.

r? libs
2023-08-23 05:35:15 +00:00
Chris Denton
ca055f148b
Automatically add OS labels to std PRs 2023-08-22 20:38:25 +01:00
David Wood
d5269a1d7b
triagebot: add dependency licensing pings
Signed-off-by: David Wood <david@davidtw.co>
2023-08-22 16:15:00 +01:00
Deadbeef
ddf89a8776 Remove myself from review rotation 2023-08-22 08:05:00 +00:00
Waffle Maybe
54bd826d56
Add waffle back to review rotation 2023-08-18 04:00:43 +04:00
Folyd
9a3dfd7e92
Remove Folyd from librustdoc static files 2023-08-17 12:24:28 +08:00
Oli Scherer
2801ae83d5 Mark oli as "on vacation" 2023-08-11 14:18:01 +00:00
Michael Goulet
2845baddb3
Rollup merge of #114693 - pietroalbini:pa-pietro-review-rotation, r=compiler-errors
Remove myself from the review rotation

I'll go on vacation soon, and in general I've not been able to keep up with the reviews.

r? `@Mark-Simulacrum`
2023-08-10 21:17:08 -07:00
Pietro Albini
32e6a2239b
remove myself from the review rotation 2023-08-10 12:20:47 +02:00
clubby789
762df46491 Add clubby789 to users_on_vacation 2023-08-09 22:38:30 +01:00
Matthias Krüger
eada0614ab
Rollup merge of #114408 - WaffleLapkin:waffle-on-vacation, r=wesleywiser
Temporary remove myself from review rotation

I'm going on vacation from 7-th to 15-th and won't be reviewing PRs or writing code.

Feel free to still ping me if you want, I'll read everything when I'm back, but most likely not sooner =)
2023-08-03 17:29:09 +02:00
Eric Holk
50b174b850
Temporarily eholk from review rotation 2023-08-02 13:15:35 -07:00
Waffle Maybe
60fffbc978
Temporary remove myself from review rotation 2023-08-02 00:09:54 +04:00
Matthias Krüger
495b9993b2
Rollup merge of #114107 - jyn514:vacation, r=ehuss
Prevent people from assigning me as a PR reviewer

depends on https://github.com/rust-lang/triagebot/pull/1712
2023-07-29 06:13:06 +02:00
jyn
37216f85a1 Prevent people from assigning me as a PR reviewer 2023-07-26 14:43:15 -07:00
Wesley Wiser
15e9f56088 Replace in-tree rustc_apfloat with the new version of the crate 2023-07-26 10:20:15 -04:00
Santiago Pastorino
1f9fa18e90
Ping spastorino on changes to SMIR 2023-07-18 11:23:28 -03:00
lcnr
c0156d1120 also apply to nested modules of solve 2023-07-14 10:32:27 +02:00
Josh Stone
68a381f38e Remove rustc_llvm from llvm-stamp nags
LLVM is not *built* by `compiler/rustc_llvm` at all, only bindings on
top of it, so there's no need to bump `download-ci-llvm-stamp` for that.
2023-07-10 09:02:47 -07:00
León Orell Valerian Liehr
7d7f6c544e
Don't label tracking issues with needs-triage 2023-07-10 05:45:38 +02:00
Nilstrieb
a118ce2176
Add needs-triage to all new issues
Closes #113261
2023-07-06 17:57:03 +02:00
Boxy
acbab96a8e add boxy to t-types review 2023-06-27 23:52:10 +01:00
jyn
be9b1334a0 Suggest bumping download-ci-llvm-stamp if the build config for llvm is changed 2023-06-14 09:01:40 -05:00
Jacob Lifshay
400fad779e
add programmerjake to portable-simd cc list 2023-06-07 22:26:31 -07:00
Matthias Krüger
319a905a92
Rollup merge of #112334 - fee1-dead-contrib:add-rotation, r=Nilstrieb
Add myself to highfive rotation
2023-06-06 22:00:19 +02:00
Deadbeef
aaca1712db Add myself to highfive rotation 2023-06-06 03:15:52 +00:00
Matthias Krüger
629a1e4419
Rollup merge of #112158 - calebzulawski:cc, r=Mark-Simulacrum
Add portable-simd mention

Adds a triagebot message for portable-simd
2023-06-04 13:21:27 +02:00