Commit Graph

3003 Commits

Author SHA1 Message Date
topecongiro
bd813251f1 Avoid allocating small strings in combine_strs_with_missing_comments 2018-02-19 12:52:40 +09:00
topecongiro
61c6c591e4 Avoid using pretty printer if possible
Setting a pretty printer adds noticeable overhead.

We can replace the usage in `ast:Lifetime::rewrite` by simply converting `Ident`
to string.
We can do the same thing for a macro path as long as it is not nested, which
should hold for most cases.
2018-02-19 12:52:40 +09:00
topecongiro
d7d9850c42 Do not inspect code for issues or todos when not required 2018-02-19 12:52:40 +09:00
topecongiro
80bf3da17d Use debug_assert_eq! to avoid comparing PathBuf on release
Comparing `PathBuf` adds noticeable overhead, avoid it in release build.
2018-02-19 12:52:40 +09:00
topecongiro
15c7e1c52a Replace lookup_char_pos with lookup_line
`lookup_char_pos` wastes time on fetching unused information. We only need a
`FileMap` and line numbers, so `lookup_line` is enough.
2018-02-19 12:52:40 +09:00
Nick Cameron
383e7e9955
Merge pull request #2465 from karyon/fix_2346
Fix #2346: empty comments should not have any trailing space added
2018-02-19 11:45:49 +13:00
Nick Cameron
25f2dffc1c
Merge pull request #2461 from topecongiro/reorder-mod
Refactoring: add `reorder` modules
2018-02-19 09:13:52 +13:00
Nick Cameron
cbf524f9e9
Merge pull request #2464 from topecongiro/beginning-vert
Format a match arm with the beginning vertical bar
2018-02-19 08:45:21 +13:00
Johannes Linke
8e36d54202 Fix #2346: empty comments should not have any trailing space added 2018-02-18 12:50:10 +01:00
topecongiro
ea3c01e337 Format a match arm with the beginning vertical bar 2018-02-18 10:31:11 +09:00
Seiichi Uchida
263104a365
Merge pull request #2463 from Razican/typo_fix
Fixed small typo in configuration help
2018-02-18 09:35:30 +09:00
Razican
4ca3592006
Fixed small typo in configuration help 2018-02-17 21:00:26 +01:00
Seiichi Uchida
c32eb1fe34 Add TODO 2018-02-18 03:00:59 +09:00
Seiichi Uchida
333e3e1247 Get rid of macro 2018-02-18 02:59:54 +09:00
Seiichi Uchida
a915916f24 Rename fns 2018-02-18 02:06:29 +09:00
topecongiro
e992c09e1f Get rid of format_imports 2018-02-18 01:38:31 +09:00
topecongiro
8427b80f57 Move reorder-related stuffs in visitor mod to reorder mod 2018-02-18 01:38:31 +09:00
topecongiro
eb9cafb440 Move rewrite_mod to the items module 2018-02-18 01:38:31 +09:00
topecongiro
e8636afab2 Add a reorder module 2018-02-18 01:38:31 +09:00
Seiichi Uchida
197c3b4406
Merge pull request #2460 from matklad/simple-ci
Simplify CI exaple in the readme
2018-02-17 16:57:08 +09:00
Aleksey Kladov
bcd6765285 Simplify CI exaple in the readme
rustfmt-preview is now in stable
2018-02-17 10:47:54 +03:00
Seiichi Uchida
2bee88870f
Merge pull request #2421 from brotzeit/clippy
apply some clippy suggestions
2018-02-17 16:14:39 +09:00
Seiichi Uchida
4531921f5f
Merge pull request #2454 from radix/issue-2446
Don't generate V: { f: u8, // comment }
2018-02-17 16:14:05 +09:00
Christopher Armstrong
bd0facd4ce only wrap on trailing comments, allow /* */ comments in-line 2018-02-16 21:52:08 -06:00
Christopher Armstrong
b2d57b927e use contains_comment instead of an ad-hoc check for "//" 2018-02-16 14:14:34 -06:00
Christopher Armstrong
f5c46559d6 hacky solution that makes the tests pass but should really be better 2018-02-16 14:14:34 -06:00
Christopher Armstrong
4528a570b8 test case for issue #2446 2018-02-16 14:14:34 -06:00
Nick Cameron
bdf562921d
Merge pull request #2453 from muja/patch-1
Fix typo "carfo" -> "cargo" in changelog.
2018-02-17 08:01:25 +13:00
Danyel
4af82a278c
Fix typo "carfo" -> "cargo" in changelog. 2018-02-16 18:53:34 +01:00
Nick Cameron
7293a8b122
Merge pull request #2450 from topecongiro/issue-37
Preserve trailing spaces in doc comments even when options are set
2018-02-16 18:08:27 +13:00
Seiichi Uchida
b60d9b0d4f Preserve trailing spaces in doc comments even when options are set
Closes #37.
2018-02-16 10:14:06 +09:00
Nick Cameron
f10c73ee90
Merge pull request #2448 from jonathanmorley/patch-1
Rust 1.24 released, rustfmt now works on stable
2018-02-16 14:08:27 +13:00
Nick Cameron
99faae6648
Merge pull request #2443 from topecongiro/skip-children
Do not try to parse external modules when skipping children
2018-02-16 14:07:29 +13:00
Nick Cameron
651dae30f1
Merge pull request #2436 from topecongiro/markdown-spaces
Preserve trailing two whitespace in comments
2018-02-16 13:51:37 +13:00
Nick Cameron
16e71c42d8
Merge pull request #2449 from radix/patch-1
IRC channel is now #rust-dev-tools
2018-02-16 09:52:20 +13:00
Christopher Armstrong
9332181729
IRC channel is now #rust-dev-tools
Also specifically mention the IRC network (irc.mozilla.org) that the channel is on.
2018-02-15 14:47:49 -06:00
Jonathan Morley
017fdc56f1
Rust 1.24 released, rustfmt now works on stable 2018-02-15 14:35:45 -05:00
Seiichi Uchida
bc12c84d2f Do not try to parse external modules when skipping children 2018-02-15 22:48:06 +09:00
Seiichi Uchida
c2dd1bcf66 Add rustfmt_skip to a test with long string 2018-02-15 22:47:32 +09:00
topecongiro
6f38a4aeab Preserve two or more trailing spaces in doc comment
rustdoc treats two or more trailing spaces as a line break.
2018-02-15 16:41:47 +09:00
topecongiro
296018afe7 Preserve trailing whitespaces only for doc comment 2018-02-15 16:34:22 +09:00
Nick Cameron
091ed2f0a4
Merge pull request #2086 from jugglerchris/difflines_mode
Add a new "modified lines" write mode.
2018-02-15 15:21:44 +13:00
Nick Cameron
bf355de78e
Merge pull request #2422 from davidalber/travis-config-badge
Proposal: add badge for Travis CI example status
2018-02-15 14:40:38 +13:00
Nick Cameron
69d7eb0986
Merge pull request #2441 from topecongiro/issue-2438
Return `None` when format_code_block may have failed
2018-02-15 14:18:21 +13:00
Nick Cameron
c5347fc91e
Merge pull request #2428 from PSeitz/master
scale WidthHeuristics by max_width
2018-02-15 14:17:39 +13:00
David Alber
e2088b0e0e Adding badge and explanation for Travis CI example status 2018-02-14 08:51:51 -08:00
brotzeit
ddca0f9b12 apply some clippy suggestions 2018-02-14 11:05:34 +01:00
topecongiro
785da7439f Return None when format_code_block may have failed 2018-02-14 19:00:45 +09:00
Nick Cameron
418a612220
Merge pull request #2440 from topecongiro/issue-2439
Disable formatting macro-def if args do not fit on one line
2018-02-14 12:10:08 +13:00
Nick Cameron
9cbda9062f
Merge pull request #2435 from davidalber/fix-option-typo
Fixing command-line option name
2018-02-14 12:03:21 +13:00