13 Commits

Author	SHA1	Message	Date
Mark Rousskov	0fb2b7a2da	Drop json::from_reader ... Performing UTF-8 decode outside the JSON module makes more sense in almost all cases.	2022-02-05 15:07:10 -05:00
Nicholas Nethercote	37fbd91eb5	Address review comments.	2022-01-22 10:38:34 +11:00
Nicholas Nethercote	416399dc10	Make Decodable and Decoder infallible. ... `Decoder` has two impls: - opaque: this impl is already partly infallible, i.e. in some places it currently panics on failure (e.g. if the input is too short, or on a bad `Result` discriminant), and in some places it returns an error (e.g. on a bad `Option` discriminant). The number of places where either happens is surprisingly small, just because the binary representation has very little redundancy and a lot of input reading can occur even on malformed data. - json: this impl is fully fallible, but it's only used (a) for the `.rlink` file production, and there's a `FIXME` comment suggesting it should change to a binary format, and (b) in a few tests in non-fundamental ways. Indeed #85993 is open to remove it entirely. And the top-level places in the compiler that call into decoding just abort on error anyway. So the fallibility is providing little value, and getting rid of it leads to some non-trivial performance improvements. Much of this commit is pretty boring and mechanical. Some notes about a few interesting parts: - The commit removes `Decoder::{Error,error}`. - `InternIteratorElement::intern_with`: the impl for `T` now has the same optimization for small counts that the impl for `Result<T, E>` has, because it's now much hotter. - Decodable impls for SmallVec, LinkedList, VecDeque now all use `collect`, which is nice; the one for `Vec` uses unsafe code, because that gave better perf on some benchmarks.	2022-01-22 10:38:31 +11:00
Nicholas Nethercote	88600a6d7f	Rename Decoder::read_nil and read_unit. ... Because `()` is called "unit" and it makes it match `Encoder::emit_unit`.	2022-01-22 10:22:24 +11:00
klensy	1b27b69e5a	don't allocate strings when str is enought for using as key	2021-12-07 12:54:35 +03:00
Mark Rousskov	3228603cce	Avoid generating empty closures for fieldless enums ... For many enums, this avoids generating lots of tiny stubs that need to be codegen'd and then inlined and removed by LLVM.	2021-11-22 21:22:35 -05:00
Frank Steffahn	be9d2699ca	Fix more “a”/“an” typos	2021-08-22 16:35:29 +02:00
Adam Bratschi-Kaye	88b01f1178	Emit warnings for unused fields in custom targets.	2021-06-17 21:48:02 +02:00
bjorn3	a2c4affe86	Remove unused functions and arguments from rustc_serialize	2021-06-01 19:29:11 +02:00
Michael Woerister	517d5ac230	Allow for reading raw bytes from rustc_serialize::Decoder without unsafe code.	2021-03-25 14:05:00 +01:00
Camille GILLOT	09a638820e	Move raw bytes handling to Encoder/Decoder.	2021-03-19 19:35:22 +01:00
Joshua Nelson	0ad3dce83a	Fix some clippy lints	2020-12-03 17:08:19 -05:00
mark	9e5f7d5631	mv compiler to compiler/	2020-08-30 18:45:07 +03:00