622 Commits

Author	SHA1	Message	Date
Dylan DPC	b36a10af7e	Rollup merge of #101598 - chriswailes:sanitizers, r=nagisa,eholk ... Update rustc's information on Android's sanitizers This patch updates sanitizer support definitions for Android inside the compiler. It also adjusts the logic to make sure no pre-built sanitizer runtime libraries are emitted as these are instead provided dynamically on Android targets.	2022-09-22 18:25:51 +05:30
bors	cba4a389b3	Auto merge of #101329 - QuinnPainter:armv5te-targets, r=nagisa ... Add armv5te-none-eabi and thumbv5te-none-eabi targets Creates two new Tier 3 targets, `armv5te-none-eabi` and `thumbv5te-none-eabi`. They are for the same target architecture (armv5te), but one defaults to the A32 instruction set and the other defaults to T32. Based on the existing `armv4t-none-eabi` and `thumbv4t-none-eabi` targets. My particular use case for these targets is Nintendo DS homebrew, but they should be usable for any armv5te system. Going through the Tier 3 target policy: > A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.) That will be me. > Targets must use naming consistent with any existing targets. Naming is consistent with previous targets. >> Target names should not introduce undue confusion or ambiguity unless absolutely necessary to maintain ecosystem compatibility. No ambiguity here. > Tier 3 targets may have unusual requirements to build or use, but must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users. Doesn't create any legal issues. >> The target must not introduce license incompatibilities. This doesn't introduce any new licenses. >> Anything added to the Rust repository must be under the standard Rust license (MIT OR Apache-2.0). Yep. >> The target must not cause the Rust tools or libraries built for any other host (even when supporting cross-compilation to the target) to depend on any new dependency less permissive than the Rust licensing policy. This applies whether the dependency is a Rust crate that would require adding new license exceptions (as specified by the tidy tool in the rust-lang/rust repository), or whether the dependency is a native library or binary. In other words, the introduction of the target must not cause a user installing or running a version of Rust or the Rust tools to be subject to any new license requirements. No new license requirements. >> Compiling, linking, and emitting functional binaries, libraries, or other code for the target (whether hosted on the target itself or cross-compiling from another target) must not depend on proprietary (non-FOSS) libraries. Everything this uses is FOSS, no proprietary required. > Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions. OK. >> This requirement does not prevent part or all of this policy from being cited in an explicit contract or work agreement (e.g. to implement or maintain support for a target). This requirement exists to ensure that a developer or team responsible for reviewing and approving a target does not face any legal threats or obligations that would prevent them from freely exercising their judgment in such approval, even if such judgment involves subjective matters or goes beyond the letter of these requirements. OK. > Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions. This is a bare-metal target with only support for `core` (and `alloc`, if the user provides an allocator). > The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary. Documentation has been added. > Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via `@)` to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages. OK. > Backlinks such as those generated by the issue/PR tracker when linking to an issue or PR are not considered a violation of this policy, within reason. However, such messages (even on a separate repository) must not generate notifications to anyone involved with a PR who has not requested such notifications. OK. > Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target. This doesn't break any other targets. >> In particular, this may come up when working on closely related targets, such as variations of the same architecture with different features. Avoid introducing unconditional uses of features that another variation of the target may not have; use conditional compilation or runtime detection, as appropriate, to let each target run code supported by that target. No unnecessary unconditional features here.	2022-09-21 09:36:21 +00:00
Chris Wailes	3d5a41724b	Update rustc's information on Android's sanitizers ... This patch updates sanitizier support definitions for Android inside the compiler. It also adjusts the logic to make sure no pre-built sanitizer runtime libraries are emitted as these are instead provided dynamically on Android targets.	2022-09-20 14:16:57 -07:00
Dylan DPC	3ad81e0dd8	Rollup merge of #93628 - est31:stabilize_let_else, r=joshtriplett ... Stabilize `let else` 🎉 **Stabilizes the `let else` feature, added by [RFC 3137](https://github.com/rust-lang/rfcs/pull/3137).** 🎉 Reference PR: https://github.com/rust-lang/reference/pull/1156 closes #87335 (`let else` tracking issue) FCP: https://github.com/rust-lang/rust/pull/93628#issuecomment-1029383585 ---------- ## Stabilization report ### Summary The feature allows refutable patterns in `let` statements if the expression is followed by a diverging `else`: ```Rust fn get_count_item(s: &str) -> (u64, &str) { let mut it = s.split(' '); let (Some(count_str), Some(item)) = (it.next(), it.next()) else { panic!("Can't segment count item pair: '{s}'"); }; let Ok(count) = u64::from_str(count_str) else { panic!("Can't parse integer: '{count_str}'"); }; (count, item) } assert_eq!(get_count_item("3 chairs"), (3, "chairs")); ``` ### Differences from the RFC / Desugaring Outside of desugaring I'm not aware of any differences between the implementation and the RFC. The chosen desugaring has been changed from the RFC's [original](https://rust-lang.github.io/rfcs/3137-let-else.html#reference-level-explanations). You can read a detailed discussion of the implementation history of it in `@cormacrelf` 's [summary](https://github.com/rust-lang/rust/pull/93628#issuecomment-1041143670) in this thread, as well as the [followup](https://github.com/rust-lang/rust/pull/93628#issuecomment-1046598419). Since that followup, further changes have happened to the desugaring, in #98574, #99518, #99954. The later changes were mostly about the drop order: On match, temporaries drop in the same order as they would for a `let` declaration. On mismatch, temporaries drop before the `else` block. ### Test cases In chronological order as they were merged. Added by df9a2e0687 (#87688): * [`ui/pattern/usefulness/top-level-alternation.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/pattern/usefulness/top-level-alternation.rs) to ensure the unreachable pattern lint visits patterns inside `let else`. Added by 5b95df4bdc (#87688): * [`ui/let-else/let-else-bool-binop-init.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-bool-binop-init.rs) to ensure that no lazy boolean expressions (using `&&` or `||`) are allowed in the expression, as the RFC mandates. * [`ui/let-else/let-else-brace-before-else.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-brace-before-else.rs) to ensure that no `}` directly preceding the `else` is allowed in the expression, as the RFC mandates. * [`ui/let-else/let-else-check.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-check.rs) to ensure that `#[allow(...)]` attributes added to the entire `let` statement apply for the `else` block. * [`ui/let-else/let-else-irrefutable.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-irrefutable.rs) to ensure that the `irrefutable_let_patterns` lint fires. * [`ui/let-else/let-else-missing-semicolon.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-missing-semicolon.rs) to ensure the presence of semicolons at the end of the `let` statement. * [`ui/let-else/let-else-non-diverging.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-non-diverging.rs) to ensure the `else` block diverges. * [`ui/let-else/let-else-run-pass.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-run-pass.rs) to ensure the feature works in some simple test case settings. * [`ui/let-else/let-else-scope.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-scope.rs) to ensure the bindings created by the outer `let` expression are not available in the `else` block of it. Added by bf7c32a447 (#89965): * [`ui/let-else/issue-89960.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/issue-89960.rs) as a regression test for the ICE-on-error bug #89960 . Later in 102b9125e1 this got removed in favour of more comprehensive tests. Added by 856541963c (#89974): * [`ui/let-else/let-else-if.rs`](https://github.com/rust-lang/rust/blob/1.58.1/src/test/ui/let-else/let-else-if.rs) to test for the improved error message that points out that `let else if` is not possible. Added by 9b45713b6c: * [`ui/let-else/let-else-allow-unused.rs`](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-allow-unused.rs) as a regression test for #89807, to ensure that `#[allow(...)]` attributes added to the entire `let` statement apply for bindings created by the `let else` pattern. Added by 61bcd8d307 (#89841): * [`ui/let-else/let-else-non-copy.rs`](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-non-copy.rs) to ensure that a copy is performed out of non-copy wrapper types. This mirrors `if let` behaviour. The test case bases on rustc internal changes originally meant for #89933 but then removed from the PR due to the error prior to the improvements of #89841. * [`ui/let-else/let-else-source-expr-nomove-pass.rs `](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-source-expr-nomove-pass.rs) to ensure that while there is a move of the binding in the successful case, the `else` case can still access the non-matching value. This mirrors `if let` behaviour. Added by 102b9125e1 (#89841): * [`ui/let-else/let-else-ref-bindings.rs`](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-ref-bindings.rs) and [`ui/let-else/let-else-ref-bindings-pass.rs `](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-ref-bindings-pass.rs) to check `ref` and `ref mut` keywords in the pattern work correctly and error when needed. Added by 2715c5f984 (#89841): * Match ergonomic tests adapted from the `rfc2005` test suite. Added by fec8a507a2 (#89841): * [`ui/let-else/let-else-deref-coercion-annotated.rs`](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-deref-coercion-annotated.rs) and [`ui/let-else/let-else-deref-coercion.rs`](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-deref-coercion.rs) to check deref coercions. #### Added since this stabilization report was originally written (2022-02-09) Added by 76ea566677 (#94211): * [`ui/let-else/let-else-destructuring.rs`](https://github.com/rust-lang/rust/blob/1.63.0/src/test/ui/let-else/let-else-destructuring.rs) to give a nice error message if an user tries to do an assignment with a (possibly refutable) pattern and an `else` block, like asked for in #93995. Added by e7730dcb7e (#94208): * [`ui/let-else/let-else-allow-in-expr.rs`](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-allow-in-expr.rs) to test whether `#[allow(unused_variables)]` works in the expr, as well as its non presence, as well as putting it on the entire `let else` *affects* the expr, too. This was adding a missing test as pointed out by the stabilization report. * Expansion of `ui/let-else/let-else-allow-unused.rs` and `ui/let-else/let-else-check.rs` to ensure that non-presence of `#[allow(unused)]` does issue the unused lint. This was adding a missing test case as pointed out by the stabilization report. Added by 5bd71063b3 (#94208): * [`ui/let-else/let-else-slicing-error.rs`](https://github.com/rust-lang/rust/blob/1.61.0/src/test/ui/let-else/let-else-slicing-error.rs), a regression test for #92069, which got fixed without addition of a regression test. This resolves a missing test as pointed out by the stabilization report. Added by 5374688e1d (#98574): * [`src/test/ui/async-await/async-await-let-else.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/async-await/async-await-let-else.rs) to test the interaction of async/await with `let else` Added by 6c529ded86 (#98574): * [`src/test/ui/let-else/let-else-temporary-lifetime.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/let-else/let-else-temporary-lifetime.rs) as a (partial) regression test for #98672 Added by 9b56640106 (#99518): * [`src/test/ui/let-else/let-else-temp-borrowck.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/let-else/let-else-temporary-lifetime.rs) as a regression test for #93951 * Extension of `src/test/ui/let-else/let-else-temporary-lifetime.rs` to include a partial regression test for #98672 (especially regarding `else` drop order) Added by baf9a7cb57 (#99518): * Extension of `src/test/ui/let-else/let-else-temporary-lifetime.rs` to include a partial regression test for #93951, similar to `let-else-temp-borrowck.rs` Added by 60be2de8b7 (#99518): * Extension of `src/test/ui/let-else/let-else-temporary-lifetime.rs` to include a program that can now be compiled thanks to borrow checker implications of #99518 Added by 47a7a91c96 (#100132): * [`src/test/ui/let-else/issue-100103.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/let-else/issue-100103.rs), as a regression test for #100103, to ensure that there is no ICE when doing `Err(...)?` inside else blocks. Added by e3c5bd617d (#100443): * [`src/test/ui/let-else/let-else-then-diverge.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/let-else/let-else-then-diverge.rs), to verify that there is no unreachable code error with the current desugaring. Added by 981852677c (#100443): * [`src/test/ui/let-else/issue-94176.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/let-else/issue-94176.rs), to make sure that a correct span is emitted for a missing trailing expression error. Regression test for #94176. Added by e182d12a84 (#100434): * [src/test/ui/unpretty/pretty-let-else.rs](https://github.com/rust-lang/rust/blob/master/src/test/ui/unpretty/pretty-let-else.rs), as a regression test to ensure pretty printing works for `let else` (this bug surfaced in many different ways) Added by e26285603c (#99954): * [`src/test/ui/let-else/let-else-temporary-lifetime.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/let-else/let-else-temporary-lifetime.rs) extended to contain & borrows as well, as this was identified as an earlier issue with the desugaring: https://github.com/rust-lang/rust/issues/98672#issuecomment-1200196921 Added by 2d8460ef43 (#99291): * [`src/test/ui/let-else/let-else-drop-order.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/let-else/let-else-drop-order.rs) a matrix based test for various drop order behaviour of `let else`. Especially, it verifies equality of `let` and `let else` drop orders, [resolving](https://github.com/rust-lang/rust/pull/93628#issuecomment-1238498468) a [stabilization blocker](https://github.com/rust-lang/rust/pull/93628#issuecomment-1055738523). Added by 1b87ce0d40 (#101410): * Edit to `src/test/ui/let-else/let-else-temporary-lifetime.rs` to add the `-Zvalidate-mir` flag, as a regression test for #99228 Added by af591ebe4d (#101410): * [`src/test/ui/let-else/issue-99975.rs`](https://github.com/rust-lang/rust/blob/master/src/test/ui/let-else/issue-99975.rs) as a regression test for the ICE #99975. Added by this PR: * `ui/let-else/let-else.rs`, a simple run-pass check, similar to `ui/let-else/let-else-run-pass.rs`. ### Things not currently tested * ~~The `#[allow(...)]` tests check whether allow works, but they don't check whether the non-presence of allow causes a lint to fire.~~ → *test added by e7730dcb7eb29a10ee73f269f4dc6e9d606db0da* * ~~There is no `#[allow(...)]` test for the expression, as there are tests for the pattern and the else block.~~ → *test added by e7730dcb7eb29a10ee73f269f4dc6e9d606db0da* * ~~`let-else-brace-before-else.rs` forbids the `let ... = {} else {}` pattern and there is a rustfix to obtain `let ... = ({}) else {}`. I'm not sure whether the `.fixed` files are checked by the tooling that they compile. But if there is no such check, it would be neat to make sure that `let ... = ({}) else {}` compiles.~~ → *test added by e7730dcb7eb29a10ee73f269f4dc6e9d606db0da* * ~~#92069 got closed as fixed, but no regression test was added. Not sure it's worth to add one.~~ → *test added by 5bd71063b3810d977aa376d1e6dd7cec359330cc* * ~~consistency between `let else` and `if let` regarding lifetimes and drop order: https://github.com/rust-lang/rust/pull/93628#issuecomment-1055738523~~ → *test added by 2d8460ef43d902f34ba2133fe38f66ee8d2fdafc* Edit: they are all tested now. ### Possible future work / Refutable destructuring assignments [RFC 2909](https://rust-lang.github.io/rfcs/2909-destructuring-assignment.html) specifies destructuring assignment, allowing statements like `FooBar { a, b, c } = foo();`. As it was stabilized, destructuring assignment only allows *irrefutable* patterns, which before the advent of `let else` were the only patterns that `let` supported. So the combination of `let else` and destructuring assignments gives reason to think about extensions of the destructuring assignments feature that allow refutable patterns, discussed in #93995. A naive mapping of `let else` to destructuring assignments in the form of `Some(v) = foo() else { ... };` might not be the ideal way. `let else` needs a diverging `else` clause as it introduces new bindings, while assignments have a default behaviour to fall back to if the pattern does not match, in the form of not performing the assignment. Thus, there is no good case to require divergence, or even an `else` clause at all, beyond the need for having *some* introducer syntax so that it is clear to readers that the assignment is not a given (enums and structs look similar). There are better candidates for introducer syntax however than an empty `else {}` clause, like `maybe` which could be added as a keyword on an edition boundary: ```Rust let mut v = 0; maybe Some(v) = foo(&v); maybe Some(v) = foo(&v) else { bar() }; ``` Further design discussion is left to an RFC, or the linked issue.	2022-09-17 15:31:06 +05:30
bors	95a992a686	Auto merge of #97800 - pnkfelix:issue-97463-fix-aarch64-call-abi-does-not-zeroext, r=wesleywiser ... Aarch64 call abi does not zeroext (and one cannot assume it does so) Fix #97463	2022-09-16 20:08:05 +00:00
est31	173eb6f407	Only enable the let_else feature on bootstrap ... On later stages, the feature is already stable. Result of running: rg -l "feature.let_else" compiler/ src/librustdoc/ library/ | xargs sed -s -i "s#\\[feature.let_else#\\[cfg_attr\\(bootstrap, feature\\(let_else\\)#"	2022-09-15 21:06:45 +02:00
Your Name	73d6dd5098	Changes to rename target and update docs	2022-09-14 18:38:01 +01:00
Your Name	9025ab7a1f	Add BE8 support	2022-09-13 08:27:48 +01:00
Nicholas Bishop	54d9ba8239	Use RelocModel::Pic for UEFI targets ... In https://github.com/rust-lang/rust/pull/100537, the relocation model for UEFI targets was changed from PIC (the default value) to static. There was some dicussion of this change here: https://github.com/rust-lang/rust/pull/100537#discussion_r952363012 It turns out that this can cause compilation to fail as described in https://github.com/rust-lang/rust/issues/101377, so switch back to PIC. Fixes https://github.com/rust-lang/rust/issues/101377	2022-09-09 15:26:19 -04:00
Quinn Painter	c227f0a8c9	remove DS stuff from docs + change to use thumb_base	2022-09-09 19:51:58 +01:00
Luis Cardoso	0f06320c24	translations(rustc_session): migrate TargetDataLayout::parse	2022-09-08 08:30:57 +02:00
Michael Benfield	1a08b96a0b	Change name of "dataful" variant to "untagged" ... This is in anticipation of a new enum layout, in which the niche optimization may be applied even when multiple variants have data.	2022-09-07 20:12:45 +00:00
Quinn Painter	7b0377c716	fix tidy	2022-09-02 14:17:01 +01:00
Quinn Painter	e7b62be96b	Add {thumb,arm}v5te-none-eabi targets	2022-09-02 14:16:02 +01:00
Vadim Petrochenkov	a0e21ff105	rustc_target: Refactor internal linker flavors slightly ... Remove one unstable user-facing linker flavor (l4-bender)	2022-09-01 16:54:52 +03:00
Vadim Petrochenkov	7dc186ff7e	rustc_target: Add a compatibility layer to separate internal and user-facing linker flavors	2022-09-01 16:54:52 +03:00
bors	b32223fec1	Auto merge of #100707 - dzvon:fix-typo, r=davidtwco ... Fix a bunch of typo This PR will fix some typos detected by [typos]. I only picked the ones I was sure were spelling errors to fix, mostly in the comments. [typos]: https://github.com/crate-ci/typos	2022-09-01 05:39:58 +00:00
bors	aa857eb953	Auto merge of #100537 - petrochenkov:piccheck, r=oli-obk ... rustc_target: Add some more target spec sanity checking	2022-09-01 03:13:46 +00:00
Dezhi Wu	b1430fb7ca	Fix a bunch of typo ... This PR will fix some typos detected by [typos]. I only picked the ones I was sure were spelling errors to fix, mostly in the comments. [typos]: https://github.com/crate-ci/typos	2022-08-31 18:24:55 +08:00
Matthias Krüger	0fee731a95	Rollup merge of #101025 - semarie:openbsd-archs, r=petrochenkov ... Add tier-3 support for powerpc64 and riscv64 openbsd # powerpc64 - MCP for [powerpc64-unknown-openbsd tier-3 support](https://github.com/rust-lang/compiler-team/issues/551) - only need to add spec definition in rustc_target # riscv64 - MCP for [riscv64-unknown-openbsd tier-3 support](https://github.com/rust-lang/compiler-team/issues/552) - add spec definition in rustc_target - follow freebsd about avoiding linking with `libatomic`	2022-08-31 07:57:58 +02:00
Yuki Okushi	9642e4840b	Rollup merge of #101088 - nicholasbishop:bishop-uefi-pdb, r=davidtwco ... Set DebuginfoKind::Pdb in msvc_base This PDB setting was added to `windows_msvc_base` in https://github.com/rust-lang/rust/pull/98051. It's also needed for the UEFI targets, and since `uefi_msvc_base` and `windows_msvc_base` are the only things that inherit from `msvc_base`, just move the PDB setting up to `mscv_base` to cover both. Fixes https://github.com/rust-lang/rust/issues/101071	2022-08-31 08:47:18 +09:00
Sébastien Marie	1de5b22678	add riscv64gc-unknown-openbsd support (target riscv64-unknown-openbsd on OpenBSD) ... - add platform-support documentation - add riscv64gc-unknown-openbsd spec - do not try to link with -latomic on openbsd	2022-08-28 05:22:21 +00:00
Sébastien Marie	dacb6ee7b0	add powerpc64-unknown-openbsd support	2022-08-28 05:16:02 +00:00
Nicholas Bishop	1dd47b04c0	Set DebuginfoKind::Pdb in msvc_base ... This PDB setting was added to `windows_msvc_base` in https://github.com/rust-lang/rust/pull/98051. It's also needed for the UEFI targets, and since `uefi_msvc_base` and `windows_msvc_base` are the only things that inherit from `msvc_base`, just move the PDB setting up to `mscv_base` to cover both. Fixes https://github.com/rust-lang/rust/issues/101071	2022-08-27 11:44:35 -04:00
bors	332cc8fb75	Auto merge of #100999 - nnethercote:shrink-FnAbi, r=bjorn3 ... Shrink `FnAbi` Because they can take up a lot of memory in debug and release builds. r? `@bjorn3`	2022-08-27 14:00:53 +00:00
Vadim Petrochenkov	f4b5954764	rustc_target: Use Cow and link args helpers in apple_base	2022-08-27 15:30:05 +03:00
Vadim Petrochenkov	f0d0573db1	rustc_target: Do not specify some target options redundantly ... These values are already inherited	2022-08-27 15:30:05 +03:00
Vadim Petrochenkov	2e83c22154	rustc_target: Add some more target spec sanity checking	2022-08-27 15:30:05 +03:00
bors	450e99f937	Auto merge of #98051 - davidtwco:split-dwarf-stabilization, r=wesleywiser ... session: stabilize split debuginfo on linux Stabilize the `-Csplit-debuginfo` flag... - ...on Linux for all values of the flag. Split DWARF has been implemented for a few months, hasn't had any bug reports and has had some promising benchmarking for incremental debug build performance. - ..on other platforms for the default value. It doesn't make any sense that `-Csplit-debuginfo=packed` is unstable on Windows MSVC when that's the default behaviour, but keep the other values unstable.	2022-08-26 15:47:26 +00:00
Sébastien Marie	908ac84662	openbsd: rustc_target: reorder spec by name	2022-08-26 06:15:54 +00:00
Nicholas Nethercote	f974617bda	Move ArgAbi::pad_i32 into PassMode::Cast. ... Because it's only needed for that variant. This shrinks the types and clarifies the logic.	2022-08-26 11:12:36 +10:00
Nicholas Nethercote	b853e8a619	Turn ArgAbi::pad into a bool. ... Because it's only ever set to `None` or `Some(Reg::i32())`.	2022-08-26 10:53:41 +10:00
Nicholas Nethercote	b75b3b3afe	Change FnAbi::args to a boxed slice.	2022-08-26 10:30:36 +10:00
Nicholas Nethercote	4df7bffa95	Change FnAbi::fixed_count to a u32.	2022-08-26 10:29:40 +10:00
Nicholas Nethercote	e4bf113027	Box CastTarget within PassMode. ... Because `PassMode::Cast` is by far the largest variant, but is relatively rare. This requires making `PassMode` not impl `Copy`, and `Clone` is no longer necessary. This causes lots of sigil adjusting, but nothing very notable.	2022-08-26 09:35:28 +10:00
Nicholas Nethercote	263c426bfd	Add size assertions for FnAbi and ArgAbi.	2022-08-26 09:30:30 +10:00
Matthias Krüger	44aa866488	Rollup merge of #100641 - corwinkuiper:add-armv4t-target, r=oli-obk ... Add the armv4t-none-eabi target to the supported_targets This target was added in #100244 but forgot to add it to the macro in the `mod.rs` file. ``@Lokathor``	2022-08-23 06:55:25 +02:00
Wesley Wiser	ed9b12d7fd	rustdoc doesn't like bare urls	2022-08-22 11:00:54 -04:00
Matthias Krüger	e81b994868	Rollup merge of #100636 - cutsoy:revert-77716, r=davidtwco ... Revert "Revert "Allow dynamic linking for iOS/tvOS targets."" This reverts commit 16e10bf81e (PR #77716). The original original PR enabled `cdylib` builds for iOS. However this caused problems because: > This new feature in Rust 1.46 added a lot of headache for iOS builds with cdylib targets. cdylib target is near impossible to build if you are using any crate with native dependencies (ex. openssl, libsodium, zmq). You can't just find .so files for all architectures to perform correct linking. Usual workflow is the following: > > 1. You build staticlib and rely that native dependencies will be linked as frameworks later > 2. You setup right cocoapods in ObjectiveC/Swift wrapper. > > As cargo doesn't support platform-dependent crate types https://github.com/rust-lang/rust/pull/4881 as a result a lot of projects now broken on Rust 1.46 However, this will be soon a thing of the past since 1.64 brings us the long awaited much anticipated `--crate-type` flag. > I see that this got merged recently: https://github.com/rust-lang/cargo/issues/10083. The --crate-type flag will get stabilized in 1.64. In 1.64, you could still get a successful iOS staticlib with cargo build --crate-type=statclib even if the crate has cdylib targets too. If I'm not mistaken, this solves the problem too so this PR could be reverted in 1.64 with relatively little headache. So summing up, I think this PR can be reverted in 1.64. 🤞	2022-08-20 19:45:13 +02:00
5225225	09ea9f0a87	Add diagnostic translation lints to crates that don't emit them	2022-08-18 19:29:02 +01:00
David Wood	cf2c492ef8	session: stabilize split debuginfo on linux ... Stabilize the `-Csplit-debuginfo` flag... - ...on Linux for all values of the flag. Split DWARF has been implemented for a few months, hasn't had any bug reports and has had some promising benchmarking for incremental debug build performance. - ..on other platforms for the default value. It doesn't make any sense that `-Csplit-debuginfo=packed` is unstable on Windows MSVC when that's the default behaviour, but keep the other values unstable. Signed-off-by: David Wood <david.wood@huawei.com>	2022-08-18 15:19:40 +01:00
Matthias Krüger	64cd65758c	Rollup merge of #100621 - taiki-e:armv4t-atomics-32, r=cuviper ... Pass +atomics-32 feature for {arm,thumb}v4t-none-eabi Similar to 89582e8193, but for ARMv4t. Pre-v6 ARM target does not have atomic CAS, except for Linux and Android where atomic CAS is provided by compiler-builtins. So, there is a similar issue as thumbv6m. I have confirmed that enabling the `atomics-32` target feature fixes the problem in the project affected by this issue. (https://github.com/taiki-e/portable-atomic/pull/28#discussion_r946604136) Closes #100619 r? ``@nikic`` cc ``@Lokathor``	2022-08-17 12:32:55 +02:00
Corwin	ed27a4c516	add the armv4t-none-eabi target	2022-08-16 20:10:31 +01:00
Tim van Elsloo	9233298e71	Revert "Revert "Allow dynamic linking for iOS/tvOS targets."" ... This reverts commit 16e10bf81e. # Conflicts: # compiler/rustc_target/src/spec/apple_sdk_base.rs	2022-08-16 17:36:25 +02:00
Taiki Endo	5bb04f30cb	Support 128-bit atomics on all aarch64 targets	2022-08-16 19:52:19 +09:00
Taiki Endo	8439080f27	Pass +atomics-32 feature for {arm,thumb}v4t-none-eabi	2022-08-16 19:24:12 +09:00
Vadim Petrochenkov	8fa707ab41	rustc_target: Update some old naming around self contained linking ... The "fallback" naming pre-dates introduction of `-Clink-self-contained`	2022-08-12 18:47:13 +03:00
bors	e2b52ff73e	Auto merge of #99464 - nikic:llvm-15, r=cuviper ... Update to LLVM 15 For preliminary testing. Some LLVM 15 compatibility fixes were applied separately in #99512. Release timeline: * LLVM 15 branched on Jul 26. * The final LLVM 15.0.0 release is scheduled for Sep 6. * Current nightly (1.65.0) is scheduled for Nov 3. Changes in this PR (apart from the LLVM update): * Pass `--set llvm.allow-old-toolchain` for many Docker images. LLVM 16 will require GCC >= 7.1, while LLVM 15 still allows older compilers with an option. Specify the option for builders still using GCC 5.4. #95026 updated some of the used toolchains, but not all. * Use the `+atomics-32` target feature for thumbv6m. * Explicitly link libatomic when cross-compiling LLVM to 32-bit target. * Explicitly disable zstd support, to avoid libzstd.so dependency. New LLVM patches ([commits](https://github.com/rust-lang/llvm-project/commits/rustc/15.0-2022-08-09)): * [rust-only] Fix ICE with GCC 5.4 (15be58d7f0) * [rust-only] Fix build with GCC 5.4 (774edc10fa) * ~~[rust-only] Fix build with GCC 5.2 (1a6069a7bb)~~ * ~~[rust-only] Fix ICE with GCC 5.2 (493081f290)~~ * ~~[rust-only] Fix build with GCC 5.2 (0fc5979d73)~~ * [backported] Addition of `+atomics` target feature (57bdd9892d). * [backported] Revert compiler-rt change that broke powerpc (9c68b43915) * [awaiting backport] Fix RelLookupTableConverter on gnux32 (639388a05f / https://github.com/llvm/llvm-project/issues/57021) Tested images: dist-x86_64-linux, armhf-gnu, arm-android, dist-s390x-linux, dist-x86_64-illumos, dist-x86_64-freebsd, wasm32, dist-x86_64-musl, dist-various-1, dist-riscv64-linux, dist-mips-linux, dist-mipsel-linux, dist-powerpc-linux, dist-aarch64-linux, dist-x86_64-apple, x86_64-msvc-1, x86_64-msvc-2, dist-various-2, dist-arm-linux Tested up to the usual ipv6 error: test-various, i686-gnu, x86_64-gnu-nopt r? `@ghost`	2022-08-12 02:58:51 +00:00
Matthias Krüger	92b32e307c	Rollup merge of #99500 - tmandry:fuchsia-flags, r=petrochenkov ... Fix flags when using clang as linker for Fuchsia Don't add C runtime or set dynamic linker when linking with clang for Fuchsia. Clang already does this for us.	2022-08-11 22:52:59 +02:00
Matthias Krüger	6737549aaf	Rollup merge of #99421 - Bryanskiy:android-crt-static, r=petrochenkov ... add crt-static for android	2022-08-11 22:52:58 +02:00