Michael Sproul
4f9d6eea5c
Detect assignment ops in integer_arithmetic
2019-09-27 11:55:42 +10:00
bors
adc1df11b4
Auto merge of #4568 - mikerite:fix-4548, r=flip1995
...
Fix `nonminimal-bool` false positive
Closes #4548
Closes #3847
changelog: Fix `nonminimal-bool` false positive
2019-09-26 08:06:16 +00:00
bors
4d30b08027
Auto merge of #4569 - james9909:add-comparison-chain, r=oli-obk
...
Add a new lint for comparison chains
changelog: Adds a new lint: `comparison_chain`.
`comparison_chain` lints all `if` conditional chains where all the conditions are binary comparisons on the same two operands and will suggest a rewrite with `match`.
Closes #4531 .
2019-09-26 07:38:08 +00:00
Lzu Tao
5639639d35
Remove unused attribute in test
2019-09-26 01:53:39 +00:00
Lzu Tao
08ce6bc6d9
Fix macro expansion in toplevel_ref_arg lint
2019-09-26 08:46:51 +07:00
Lzu Tao
3b9e5dfda5
Add regression test for macro expansion
2019-09-26 08:14:58 +07:00
Manish Goregaokar
b94f2e89fd
unnecessary_operation: make test rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
04dd580f37
unnecessary_clone: split rustfixable lint out into separate test
2019-09-25 14:45:18 -07:00
Manish Goregaokar
363e382f5b
string_add, string_add_assign: split tests, make one rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
1a4dcfca35
redundant_static_lifetimes: split test, make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
ea16ab56d5
renamed_builtin_attr: make test rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
d28dacb33a
redundant_pattern_matching: make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
a83a8dccba
redundant_closure_call: split tests into fixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
e4ff86dcd4
map_unit_fn: make test rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
ad0e7c8e7f
map_unit_fn: fix applicability
2019-09-25 14:45:18 -07:00
Manish Goregaokar
24c283ea12
option_map_unit_fn: Split into fixable/unfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
38a0785436
map_unit_fn: rename tests to fixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
1090509564
non_copy_const: remove incorrect suggestion
2019-09-25 14:45:18 -07:00
Manish Goregaokar
a9a3350455
needless_return: add allow()s to test, make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
980650eec2
needless_collect: fix suggestion, make test rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
7f822e742d
needless_borrowed_ref: fix false positive, make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
622b167eb8
needless_borrow: allow other lints, make fixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
0d8e4d7c37
mem_discriminant: split test, make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
483e140bce
map_flatten: make it a rustfix test
2019-09-25 14:45:18 -07:00
Manish Goregaokar
d29f6d28b5
Leave note on non-rustfixable tests
2019-09-25 14:45:18 -07:00
Manish Goregaokar
329e224eba
Remove large-digit-groups test from literals.rs
2019-09-25 14:45:18 -07:00
Manish Goregaokar
4368771548
map_entry test: Fix semicolon, add run-rustfix
2019-09-25 14:45:18 -07:00
Manish Goregaokar
e2f4b60661
Split map_entry tests into fixable and unfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
d445bf2e89
Remove suggestion for complex map_entry cases
2019-09-25 13:54:53 -07:00
Manish Goregaokar
982c51e769
arm.pats -> arm.pat
2019-09-25 12:52:16 -07:00
Manish Goregaokar
68c26b325b
Rustup to rustc 1.39.0-nightly ( acf7b50c7
2019-09-25)
...
- Addresses inference error
- Updates compiletest
2019-09-25 11:11:14 -07:00
James Wang
52408f5b7d
Add a new lint for comparison chains
2019-09-24 16:55:05 -05:00
Michael Wright
0cc48ad9f9
Fix nonminimal-bool
false positive
...
Closes #4548
Closes #3847
2019-09-24 08:13:50 +02:00
Philipp Hansch
df83732f09
Add run-rustfix for toplevel_ref_arg lint
2019-09-23 11:22:31 +02:00
Michael Wright
ca6d36ba22
Merge branch 'master' into unneeded_wildcard_pattern
2019-09-23 05:26:47 +02:00
Matthias Krüger
d7b3e237db
rustup https://github.com/rust-lang/rust/pull/64666
2019-09-22 12:35:20 +02:00
Michael Wright
be4e41562a
Add additional tests to unneeded_wildcard_pattern
2019-09-22 09:10:39 +02:00
Michael Wright
d04bf15114
Merge branch 'master' into unneeded_wildcard_pattern
2019-09-22 08:59:23 +02:00
Philipp Hansch
afd7b180e5
Add run-rustfix for wildcard_enum_match_arm lint
2019-09-21 07:26:18 +02:00
bors
f21cd81949
Auto merge of #4558 - Manishearth:suggestions, r=phansch
...
Make more tests rustfixable
changelog: Fix various lint suggestions
Progress towards https://github.com/rust-lang/rust-clippy/issues/3630
r? @phansch
2019-09-21 01:01:21 +00:00
Manish Goregaokar
2fecf756f7
inline_fn_without_body: make it use a rustfix page
2019-09-21 10:01:06 +09:00
Manish Goregaokar
ee9e1af4ed
implicit_return: make it use a rustfix test
2019-09-21 10:01:06 +09:00
Manish Goregaokar
a2ab0698cc
identity_conversion: make it use a rustfix test
2019-09-21 10:01:06 +09:00
Manish Goregaokar
bbfb9a49e3
for_loop: Split test into fixable/unfixable, make needless_range_loop use updated range syntax
2019-09-21 10:01:06 +09:00
Manish Goregaokar
38a34b1bd7
eq_op: stop testing nonminimal_bool in same file
2019-09-20 23:21:37 +09:00
Manish Goregaokar
49adc99aed
op_ref: Move tests out of eq_op file
2019-09-20 23:21:37 +09:00
Manish Goregaokar
d513a0b0a1
deref_addrof_double_trigger: Note why rustfix can't be used
2019-09-20 14:51:28 +09:00
Andre Bogus
8d884c8a1a
new lint: mem-replace-with-uninit
2019-09-20 00:25:57 +02:00
bors
cdaa93d695
Auto merge of #4544 - JoshMcguigan:issue-4542, r=flip1995
...
#4542 remove machine applicable suggestion
This helps #4542 (but does not completely resolve) by removing the machine applicable suggestion (which was incorrect) for that case.
I would have preferred to fix the machine applicable suggestion to handle format strings, but that's a bit beyond my current understanding of the clippy codebase. I'd be happy to give it a try given some guidance.
changelog: only produce machine applicable suggestions on `explicit_write` lint
2019-09-19 09:28:29 +00:00
bors
f08f171530
Auto merge of #4539 - jolson88:cast-lossless-pedantic, r=flip1995
...
Changes cast-lossless to a pedantic lint
As discussed in #4528 , this moves the cast-lossless lint from `all` to `pedantic`.
I couldn't tell from description alone if it should also be removed from the complexity category, so I left it as part of complexity for now. I didn't see any impact to the tests from this change, but I could be wrong (as this is my first PR).
fixes #4528
changelog: Moves cast-lossless from default to checking only as a `pedantic` lint.
2019-09-19 08:50:31 +00:00