635 Commits

Author	SHA1	Message	Date
Michael Goulet	32d2340dbd	Check use<..> in RPITIT for refinement	2024-11-18 00:27:44 +00:00
Guillaume Gomez	fc8d2b38d8	Rollup merge of #133080 - ehuss:edition-desugar-span, r=compiler-errors ... Fix span edition for 2024 RPIT coming from an external macro This fixes a problem where code generated by an external macro with an RPIT would end up using the call-site edition instead of the macro's edition for the RPIT. When used from a 2024 crate, this caused the code to change behavior to the 2024 capturing rules, which we don't want. This was caused by the impl-trait lowering code would replace the span with one marked with `DesugaringKind::OpaqueTy` desugaring. However, it was also overriding the edition of the span with the edition of the local crate. Instead it should be using the edition of the span itself. Fixes https://github.com/rust-lang/rust/issues/132917	2024-11-15 23:38:12 +01:00
Eric Huss	03e2828e88	Fix span edition for 2024 RPIT coming from an external macro ... This fixes a problem where code generated by an external macro with an RPIT would end up using the call-site edition instead of the macro's edition for the RPIT. When used from a 2024 crate, this caused the code to change behavior to the 2024 capturing rules, which we don't want. This was caused by the impl-trait lowering code would replace the span with one marked with `DesugaringKind::OpaqueTy` desugaring. However, it was also overriding the edition of the span with the edition of the local crate. Instead it should be using the edition of the span itself. Fixes https://github.com/rust-lang/rust/issues/132917	2024-11-15 10:06:53 -08:00
Matthias Krüger	213803549a	Rollup merge of #132817 - compiler-errors:impl-trait-overcaptures-apit, r=BoxyUwU ... Recurse into APITs in `impl_trait_overcaptures` We were previously not detecting cases where an RPIT was located in the return type of an async function, leading to underfiring of the `impl_trait_overcaptures`. This PR does this recursion properly now. cc https://github.com/rust-lang/rust/issues/132809	2024-11-15 19:05:15 +01:00
Eric Huss	d163541022	Add test for precise-capturing from an external macro	2024-11-15 09:54:06 -08:00
Michael Goulet	0dc6c1e594	Make precise capturing suggestion machine-applicable only if it has not APITs	2024-11-12 04:08:34 +00:00
Michael Goulet	8e068b989b	Recurse into APITs in impl_trait_overcaptures	2024-11-11 20:53:08 +00:00
Michael Goulet	a1f9d5bfba	Dont suggest use<APIT>	2024-11-09 19:41:53 +00:00
Michael Goulet	ad20906065	Suggest turning APITs into generics in opaque overcaptures	2024-11-09 19:18:22 +00:00
Hans Wennborg	029add206f	Add --diagnostic-width to some tests failing after 1a0c502183 ... Otherwise the tests would fail depending on the execution environment.	2024-11-06 20:02:42 +01:00
bors	b3f75cc872	Auto merge of #132147 - estebank:long-types-2, r=davidtwco ... Tweak E0277 output when a candidate is available *Follow up to #132086.* Go from ``` error[E0277]: the trait bound `Then<Ignored<chumsky::combinator::Filter<chumsky::primitive::Any<&str, chumsky::extra::Full<EmptyErr, (), ()>>, {closure@src/main.rs:9:17: 9:27}>, char>, chumsky::combinator::Map<impl CSTParser<'a, O>, O, {closure@src/main.rs:11:24: 11:27}>, (), (), chumsky::extra::Full<EmptyErr, (), ()>>: CSTParser<'a>` is not satisfied --> src/main.rs:7:50 | 7 | fn leaf<'a, O>(parser: impl CSTParser<'a, O>) -> impl CSTParser<'a, ()> { | ^^^^^^^^^^^^^^^^^^^^^^ the trait `chumsky::private::ParserSealed<'_, &str, (), chumsky::extra::Full<EmptyErr, (), ()>>` is not implemented for `Then<Ignored<Filter<Any<&str, ...>, ...>, ...>, ..., ..., ..., ...>`, which is required by `Then<Ignored<chumsky::combinator::Filter<chumsky::primitive::Any<&str, chumsky::extra::Full<EmptyErr, (), ()>>, {closure@src/main.rs:9:17: 9:27}>, char>, chumsky::combinator::Map<impl CSTParser<'a, O>, O, {closure@src/main.rs:11:24: 11:27}>, (), (), chumsky::extra::Full<EmptyErr, (), ()>>: CSTParser<'a>` | = help: the trait `chumsky::private::ParserSealed<'_, &'a str, ((), ()), chumsky::extra::Full<EmptyErr, (), ()>>` is implemented for `Then<Ignored<chumsky::combinator::Filter<chumsky::primitive::Any<&str, chumsky::extra::Full<EmptyErr, (), ()>>, {closure@src/main.rs:9:17: 9:27}>, char>, chumsky::combinator::Map<impl CSTParser<'a, O>, O, {closure@src/main.rs:11:24: 11:27}>, (), (), chumsky::extra::Full<EmptyErr, (), ()>>` = help: for that trait implementation, expected `((), ())`, found `()` = note: required for `Then<Ignored<Filter<Any<&str, ...>, ...>, ...>, ..., ..., ..., ...>` to implement `Parser<'_, &str, ()>` note: required for `Then<Ignored<Filter<Any<&str, ...>, ...>, ...>, ..., ..., ..., ...>` to implement `CSTParser<'a>` --> src/main.rs:5:16 | 5 | impl<'a, O, T> CSTParser<'a, O> for T where T: Parser<'a, &'a str, O> {} | ^^^^^^^^^^^^^^^^ ^ ---------------------- unsatisfied trait bound introduced here = note: the full name for the type has been written to '/home/gh-estebank/longlong/target/debug/deps/longlong-0008f9a4f2023b08.long-type-13239977239800463552.txt' = note: consider using `--verbose` to print the full type name to the console = note: the full name for the type has been written to '/home/gh-estebank/longlong/target/debug/deps/longlong-0008f9a4f2023b08.long-type-13239977239800463552.txt' = note: consider using `--verbose` to print the full type name to the console ``` to ``` error[E0277]: the trait bound `Then<Ignored<chumsky::combinator::Filter<chumsky::primitive::Any<&str, chumsky::extra::Full<EmptyErr, (), ()>>, {closure@src/main.rs:9:17: 9:27}>, char>, chumsky::combinator::Map<impl CSTParser<'a, O>, O, {closure@src/main.rs:11:24: 11:27}>, (), (), chumsky::extra::Full<EmptyErr, (), ()>>: CSTParser<'a>` is not satisfied --> src/main.rs:7:50 | 7 | fn leaf<'a, O>(parser: impl CSTParser<'a, O>) -> impl CSTParser<'a, ()> { | ^^^^^^^^^^^^^^^^^^^^^^ unsatisfied trait bound ... 11 | ws.then(parser.map(|_| ())) | --------------------------- return type was inferred to be `Then<Ignored<..., ...>, ..., ..., ..., ...>` here | = help: the trait `ParserSealed<'_, &_, (), Full<_, _, _>>` is not implemented for `Then<Ignored<..., ...>, ..., ..., ..., ...>` but trait `ParserSealed<'_, &'a _, ((), ()), Full<_, _, _>>` is implemented for it = help: for that trait implementation, expected `((), ())`, found `()` = note: required for `Then<Ignored<..., ...>, ..., ..., ..., ...>` to implement `Parser<'_, &str, ()>` note: required for `Then<Ignored<..., ...>, ..., ..., ..., ...>` to implement `CSTParser<'a>` --> src/main.rs:5:16 | 5 | impl<'a, O, T> CSTParser<'a, O> for T where T: Parser<'a, &'a str, O> {} | ^^^^^^^^^^^^^^^^ ^ ---------------------- unsatisfied trait bound introduced here = note: the full name for the type has been written to '/home/gh-estebank/longlong/target/debug/deps/longlong-df9d52be87eada65.long-type-1337037744507305372.txt' = note: consider using `--verbose` to print the full type name to the console ``` * Remove redundant wording * Introduce trait diff highlighting logic and use it * Fix incorrect "long type written to path" logic (can be split off) * Point at tail expression in more cases in E0277 * Avoid long primary span labels in E0277 by moving them to a `help` Fix #132013. There are individual commits that can be their own PR. If the review load is too big, happy to split them off.	2024-11-02 20:22:49 +00:00
Esteban Küber	092ecca5b9	Point at tail expression on rpit E0277 ... ``` error[E0277]: the trait bound `{gen block@$DIR/gen_block_is_coro.rs:7:5: 7:8}: Coroutine` is not satisfied --> $DIR/gen_block_is_coro.rs:6:13 | LL | fn foo() -> impl Coroutine<Yield = u32, Return = ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Coroutine` is not implemented for `{gen block@$DIR/gen_block_is_coro.rs:7:5: 7:8}` LL | gen { yield 42 } | ---------------- return type was inferred to be `{gen block@$DIR/gen_block_is_coro.rs:7:5: 7:8}` here ``` The secondary span label is new.	2024-11-02 03:08:04 +00:00
Esteban Küber	b7fc1a7431	Add trait diff highlighting logic and use it in E0277 ... When a trait is not implemented for a type, but there *is* an `impl` for another type or different trait params, we format the output to use highlighting in the same way that E0308 does for types. The logic accounts for 3 cases: - When both the type and trait in the expected predicate and the candidate are different - When only the types are different - When only the trait generic params are different For each case, we use slightly different formatting and wording.	2024-11-02 03:08:04 +00:00
Camille GILLOT	e2a50de5f4	Use more minimized test.	2024-11-01 18:13:26 +00:00
Camille GILLOT	45d4465028	Account for late-bound depth when capturing all opaque lifetimes.	2024-11-01 17:03:17 +00:00
Jubilee	e31988cfc9	Rollup merge of #132209 - compiler-errors:modifiers, r=fmease ... Fix validation when lowering `?` trait bounds Pass the unlowered (`rustc_hir`) polarity to `lower_poly_trait_ref`. This allows us to actually *validate* that generic args are actually valid on `?Trait` paths. This actually regressed in #113671 because that PR changed the behavior where we were inadvertently re-lowering paths as `BoundPolarity::Positive`, which was also coincidentally the only place we were enforcing the generics on `?Trait` paths were correct.	2024-10-31 17:50:40 -07:00
bors	c8b83785dc	Auto merge of #131186 - compiler-errors:precise-capturing-borrowck, r=estebank ... Try to point out when edition 2024 lifetime capture rules cause borrowck issues Lifetime capture rules in 2024 are modified to capture more lifetimes, which sometimes lead to some non-local borrowck errors. This PR attempts to link these back together with a useful note pointing out the capture rule changes. This is not a blocking concern, but I'd appreciate feedback (though, again, I'd like to stress that I don't want to block this PR on this): I'm worried about this note drowning in the sea of other diagnostics that borrowck emits. I was tempted to change the level of the note to `.span_warn` just so it would show up in a different color. Thoughts? Fixes #130545 Opening as a draft first since it's stacked on #131183. r? `@ghost`	2024-10-31 03:36:06 +00:00
Michael Goulet	c1457798db	Try to point out when edition 2024 lifetime capture rules cause borrowck issues	2024-10-31 01:35:14 +00:00
bors	75eff9a574	Auto merge of #132377 - matthiaskrgr:rollup-3p1c6hs, r=matthiaskrgr ... Rollup of 3 pull requests Successful merges: - #132368 (Remove `do_not_const_check` from `Iterator` methods) - #132373 (Make sure `type_param_predicates` resolves correctly for RPITIT) - #132374 (Remove dead code stemming from the old effects desugaring) r? `@ghost` `@rustbot` modify labels: rollup	2024-10-31 00:46:22 +00:00
Michael Goulet	e356279bdf	Actually do validation for poly trait refs with ? modifier	2024-10-30 23:42:50 +00:00
Michael Goulet	d53ca63453	Make sure type_param_predicates resolves correctly for RPITIT	2024-10-30 22:30:28 +00:00
Camille GILLOT	2d74d8f333	Actually capture all in-scope lifetimes.	2024-10-30 16:22:23 +00:00
Camille GILLOT	d693e19268	Promote crashes tests to ui.	2024-10-30 16:19:53 +00:00
Camille GILLOT	b6e1214ac0	Remap impl-trait lifetimes on HIR instead of AST lowering.	2024-10-30 16:18:50 +00:00
Esteban Küber	5b54286640	Remove detail from label/note that is already available in other note ... Remove the "which is required by `{root_obligation}`" post-script in "the trait `X` is not implemented for `Y`" explanation in E0277. This information is already conveyed in the notes explaining requirements, making it redundant while making the text (particularly in labels) harder to read. ``` error[E0277]: the trait bound `NotCopy: Copy` is not satisfied --> $DIR/wf-static-type.rs:10:13 | LL | static FOO: IsCopy<Option<NotCopy>> = IsCopy { t: None }; | ^^^^^^^^^^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `NotCopy` | = note: required for `Option<NotCopy>` to implement `Copy` note: required by a bound in `IsCopy` --> $DIR/wf-static-type.rs:7:17 | LL | struct IsCopy<T:Copy> { t: T } | ^^^^ required by this bound in `IsCopy` ``` vs the prior ``` error[E0277]: the trait bound `NotCopy: Copy` is not satisfied --> $DIR/wf-static-type.rs:10:13 | LL | static FOO: IsCopy<Option<NotCopy>> = IsCopy { t: None }; | ^^^^^^^^^^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `NotCopy`, which is required by `Option<NotCopy>: Copy` | = note: required for `Option<NotCopy>` to implement `Copy` note: required by a bound in `IsCopy` --> $DIR/wf-static-type.rs:7:17 | LL | struct IsCopy<T:Copy> { t: T } | ^^^^ required by this bound in `IsCopy` ```	2024-10-29 16:26:57 +00:00
许杰友 Jieyou Xu (Joe)	a9ee1d025b	Rollup merge of #132227 - compiler-errors:better-const-span, r=Nadrieril ... Pass constness with span into lower_poly_trait_ref Gives us a span to point at for ~const/const on non-const traits. Split from #132209. r? Nadrieril	2024-10-28 13:36:20 +08:00
许杰友 Jieyou Xu (Joe)	20d2a546fa	Rollup merge of #132086 - estebank:long-types, r=jieyouxu ... Tweak E0277 highlighting and "long type" path printing Partially address #132013. 	2024-10-28 13:36:18 +08:00
Matthias Krüger	574a8ba6af	Rollup merge of #132214 - fmease:mv-impl-trait-val-paths, r=compiler-errors ... Cleanup: Move an impl-Trait check from AST validation to AST lowering Namely the one that rejects `impl Trait` in qself types and non-final path segments. There's no good reason to perform this during AST validation. We have better infrastructure in place in the AST lowerer (`ImplTraitContext`). This shaves off a lot of code. We now lower `impl Trait` in bad positions to `{type error}` which allows us to remove a special case from HIR ty lowering. Coincidentally fixes #126725. Well, it only *masks* it by passing `{type error}` to HIR analysis instead of a "bad" opaque. I was able to find a new reproducer for it. See the issue.	2024-10-27 19:49:07 +01:00
León Orell Valerian Liehr	442f39582d	Move an impl-Trait check from AST validation to AST lowering	2024-10-27 07:41:52 +01:00
Michael Goulet	bd95695b94	Pass constness with span into lower_poly_trait_ref	2024-10-26 20:54:38 +00:00
Deadbeef	f2f67232a5	Deny calls to non-#[const_trait] methods in MIR constck	2024-10-26 11:35:56 +08:00
Esteban Küber	aa82fd6d1d	Tweak highlighting when trait is available for different type ... When printing ``` = help: the trait `chumsky::private::ParserSealed<'_, &'a str, ((), ()), chumsky::extra::Full<EmptyErr, (), ()>>` is implemented for `Then<Ignored<chumsky::combinator::Filter<chumsky::primitive::Any<&str, chumsky::extra::Full<EmptyErr, (), ()>>, {closure@src/main.rs:9:17: 9:27}>, char>, chumsky::combinator::Map<impl CSTParser<'a, O>, O, {closure@src/main.rs:11:24: 11:27}>, (), (), chumsky::extra::Full<EmptyErr, (), ()>>` = help: for that trait implementation, expected `((), ())`, found `()` ``` Highlight only the `expected` and `found` types, instead of the full type in the first `help`.	2024-10-25 18:06:39 +00:00
Esteban Küber	24ac777a64	Add test for #132013	2024-10-25 18:06:36 +00:00
Michael Goulet	cde29b9ec9	Implement const effect predicate in new solver	2024-10-24 09:46:36 +00:00
Matthias Krüger	559f8ce726	Rollup merge of #131795 - compiler-errors:expectation, r=Nadrieril ... Stop inverting expectation in normalization errors We have some funky special case logic to invert the expectation and actual type for normalization errors depending on their cause code. IMO most of the error messages get better, except for `try {}` blocks' type expectations. I think that these need to be special cased in some other way, rather than via this hack. Fixes #131763	2024-10-19 22:00:57 +02:00
Michael Goulet	70746d078e	Make sure that outer opaques capture inner opaques's lifetimes even with precise capturing syntax	2024-10-19 18:02:26 +00:00
Michael Goulet	e3800a1a04	Allow dropping dyn principal	2024-10-17 20:43:31 +02:00
bors	798fb83f7d	Auto merge of #131797 - matthiaskrgr:rollup-lzpze2k, r=matthiaskrgr ... Rollup of 9 pull requests Successful merges: - #130989 (Don't check unsize goal in MIR validation when opaques remain) - #131657 (Rustfmt `for<'a> async` correctly) - #131691 (Delay ambiguous intra-doc link resolution after `Cache` has been populated) - #131730 (Refactor some `core::fmt` macros) - #131751 (Rename `can_coerce` to `may_coerce`, and then structurally resolve correctly in the probe) - #131753 (Unify `secondary_span` and `swap_secondary_and_primary` args in `note_type_err`) - #131776 (Emscripten: Xfail backtrace ui tests) - #131777 (Fix trivially_copy_pass_by_ref in stable_mir) - #131778 (Fix needless_lifetimes in stable_mir) r? `@ghost` `@rustbot` modify labels: rollup	2024-10-16 20:50:53 +00:00
Michael Goulet	99d5f3b280	Stop inverting expectation in normalization errors	2024-10-16 13:44:56 -04:00
Michael Goulet	c7730989de	Don't check unsize goal in MIR validation when opaques remain	2024-10-15 21:01:42 -04:00
Michael Goulet	0ead25c4a9	Register a dummy candidate for failed structural normalization during candiate assembly	2024-10-15 20:42:17 -04:00
Michael Goulet	8528387743	Be better at reporting alias errors	2024-10-15 20:42:17 -04:00
Michael Goulet	fd2038d344	Make sure the alias is actually rigid	2024-10-15 20:42:17 -04:00
lcnr	1a9d2d82a5	stabilize -Znext-solver=coherence	2024-10-15 13:11:00 +02:00
VulnBandit	9a2772e1c2	Don't assume traits used as type are trait objs	2024-10-11 17:36:04 +02:00
Matthias Krüger	fa3dff3e24	Rollup merge of #131475 - fmease:compiler-mv-obj-safe-dyn-compat-2, r=jieyouxu ... Compiler & its UI tests: Rename remaining occurrences of "object safe" to "dyn compatible" Follow-up to #130826. Part of #130852. 1. 1st commit: Fix stupid oversights. Should've been part of #130826. 2. 2nd commit: Rename the unstable feature `object_safe_for_dispatch` to `dyn_compatible_for_dispatch`. Might not be worth the churn, you decide. 3. 3rd commit: Apply the renaming to all UI tests (contents and paths).	2024-10-10 22:00:50 +02:00
Michael Goulet	36076ecdc7	Clarify implicit captures for RPITIT	2024-10-10 11:46:51 -07:00
Michael Goulet	a7dc98733d	Add variances to RPITITs	2024-10-10 11:46:48 -07:00
Michael Goulet	b7297ac440	Add gate for precise capturing in traits	2024-10-10 11:44:11 -07:00
Michael Goulet	09da2ebd63	Move ty::Error branch into super_combine_tys	2024-10-10 06:07:51 -04:00