609 Commits

Author	SHA1	Message	Date
c8ef	2575196152	fix: simple typo in compiler directory	2024-08-20 20:50:32 +08:00
Felix Rath	2bf2455925	Prevent double panic in query system, improve diagnostics	2024-08-19 17:42:42 +02:00
León Orell Valerian Liehr	c4c518d2d4	Use more slice patterns inside the compiler	2024-08-07 13:37:52 +02:00
Yuri Astrakhan	84e261e5cb	chore: use shorthand initializer	2024-08-02 13:22:28 -04:00
Nicholas Nethercote	84ac80f192	Reformat use declarations. ... The previous commit updated `rustfmt.toml` appropriately. This commit is the outcome of running `x fmt --all` with the new formatting options.	2024-07-29 08:26:52 +10:00
Esteban Küber	2d7795dfb9	Be more accurate about calculating display_col from a BytePos ... No longer track "zero-width" chars in `SourceMap`, read directly from the line when calculating the `display_col` of a `BytePos`. Move `char_width` to `rustc_span` and use it from the emitter. This change allows the following to properly align in terminals (depending on the font, the replaced control codepoints are rendered as 1 or 2 width, on my terminal they are rendered as 1, on VSCode text they are rendered as 2): ``` error: this file contains an unclosed delimiter --> $DIR/issue-68629.rs:5:17 | LL | ␜␟ts␀![{i | -- unclosed delimiter | | | unclosed delimiter LL | ␀␀ fn rݻoa>rݻm | ^ ```	2024-07-18 20:08:38 +00:00
Michael Goulet	247ad3385c	Use dep: for crate dependencies	2024-07-15 12:40:10 -04:00
lcnr	15f770b143	enable fuzzing of SearchGraph ... fully move it into `rustc_type_ir` and make it independent of `Interner`.	2024-07-12 06:30:19 -04:00
bors	c290e9de32	Auto merge of #126326 - eggyal:ununsafe-StableOrd, r=michaelwoerister ... Un-unsafe the `StableOrd` trait Whilst incorrect implementations of this trait can cause miscompilation, they cannot cause memory unsafety in rustc. [Discussed on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Policy.20of.20.60unsafe.60.20within.20the.20compiler). cc [MCP 533](https://github.com/rust-lang/compiler-team/issues/533), #105175, `@michaelwoerister` r? `@Nilstrieb`	2024-06-25 15:51:35 +00:00
Alan Egerton	0e73e7095a	Ensure careful consideration is given by impls ... Added an associated `const THIS_IMPLEMENTATION_HAS_BEEN_TRIPLE_CHECKED` to the `StableOrd` trait to ensure that implementors carefully consider whether the trait's contract is upheld, as incorrect implementations can cause miscompilations.	2024-06-22 07:17:02 +01:00
Michael Baikov	db5ed4bd79	Allow for try_force_from_dep_node to fail ... The way it is implemented currently try_force_from_dep_node returns true as long as there's a function to force the query. It wasn't this way from the beginning, earlier version was producing forcing result and it was changed in https://github.com/rust-lang/rust/pull/89978, I couldn't find any comments addressing this change. One way it can fail is by failing to recover the query in DepNodeParams::recover - when we are trying to query something that no longer exists in the current environment	2024-06-19 07:21:41 -04:00
Oli Scherer	7ba82d61eb	Use a dedicated type instead of a reference for the diagnostic context ... This paves the way for tracking more state (e.g. error tainting) in the diagnostic context handle	2024-06-18 15:42:11 +00:00
Alan Egerton	114dd2061e	Un-unsafe the StableOrd trait ... Whilst incorrect implementations of this trait can cause miscompilation, they cannot cause memory unsafety in rustc.	2024-06-12 13:01:22 +01:00
Nicholas Nethercote	75b164d836	Use tidy to sort crate attributes for all compiler crates. ... We already do this for a number of crates, e.g. `rustc_middle`, `rustc_span`, `rustc_metadata`, `rustc_span`, `rustc_errors`. For the ones we don't, in many cases the attributes are a mess. - There is no consistency about order of attribute kinds (e.g. `allow`/`deny`/`feature`). - Within attribute kind groups (e.g. the `feature` attributes), sometimes the order is alphabetical, and sometimes there is no particular order. - Sometimes the attributes of a particular kind aren't even grouped all together, e.g. there might be a `feature`, then an `allow`, then another `feature`. This commit extends the existing sorting to all compiler crates, increasing consistency. If any new attribute line is added there is now only one place it can go -- no need for arbitrary decisions. Exceptions: - `rustc_log`, `rustc_next_trait_solver` and `rustc_type_ir_macros`, because they have no crate attributes. - `rustc_codegen_gcc`, because it's quasi-external to rustc (e.g. it's ignored in `rustfmt.toml`).	2024-06-12 15:49:10 +10:00
Oli Scherer	c7ced1ba53	Make the panic info more useful	2024-06-06 09:47:10 +00:00
Ben Kimock	95150d7246	Add a footer in FileEncoder and check for it in MemDecoder	2024-05-21 20:12:29 -04:00
Nicholas Nethercote	9b3ef5404c	Remove some unneeded Cargo.toml dependencies. ... I found these with a hacky shell script.	2024-05-03 15:33:52 +10:00
Nicholas Nethercote	6341935a13	Remove extern crate tracing from numerous crates.	2024-04-30 16:47:49 +10:00
Nicholas Nethercote	f3e05d1609	Remove extern crate rustc_data_structures from rustc_query_system.	2024-04-29 15:40:29 +10:00
Nicholas Nethercote	4814fd0a4b	Remove extern crate rustc_macros from numerous crates.	2024-04-29 10:21:54 +10:00
Guillaume Gomez	a60ccc1876	Rollup merge of #124252 - michaelwoerister:better-forbidden-read-ice, r=oli-obk ... Improve ICE message for forbidden dep-graph reads. The new message mentions the main context that the ICE might occur in and it mentions the query/dep-node that is being read. cc https://github.com/rust-lang/rust/pull/123781, where this would have been helpful.	2024-04-22 20:26:00 +02:00
Markus Reiter	33e68aadc9	Stabilize generic NonZero.	2024-04-22 18:48:47 +02:00
Michael Woerister	6146a51f17	Add more context to the forbidden dep-graph read ICE error message.	2024-04-22 14:54:28 +02:00
Michael Woerister	c373ec07c4	Improve ICE message for forbidden dep-graph reads.	2024-04-22 12:11:07 +02:00
Matthias Krüger	f9ca213510	remove some things that do not need to be	2024-04-11 21:09:52 +02:00
Mark Rousskov	668b3188ab	Remove sharding for VecCache ... This sharding is never used (per the comment in code). If we re-add sharding at some point in the future this is cheap to restore, but for now no need for the extra complexity.	2024-04-06 10:49:31 -04:00
bors	4563f70c3b	Auto merge of #122070 - Zoxc:dep-edges-from-previous, r=cjgillot ... Encode dep graph edges directly from the previous graph when promoting This encodes dep graph edges directly from the previous graph when promoting nodes from a previous session, avoiding allocations / copies. ~~Based on https://github.com/rust-lang/rust/pull/122064 and https://github.com/rust-lang/rust/pull/116375.~~ <table><tr><td rowspan="2">Benchmark</td><td colspan="1"><b>Before</b></th><td colspan="2"><b>After</b></th></tr><tr><td align="right">Time</td><td align="right">Time</td><td align="right">%</th></tr><tr><td>🟣 <b>clap</b>:check:unchanged</td><td align="right">0.4177s</td><td align="right">0.4072s</td><td align="right">💚 -2.52%</td></tr><tr><td>🟣 <b>hyper</b>:check:unchanged</td><td align="right">0.1430s</td><td align="right">0.1420s</td><td align="right"> -0.69%</td></tr><tr><td>🟣 <b>regex</b>:check:unchanged</td><td align="right">0.3106s</td><td align="right">0.3038s</td><td align="right">💚 -2.19%</td></tr><tr><td>🟣 <b>syn</b>:check:unchanged</td><td align="right">0.5823s</td><td align="right">0.5688s</td><td align="right">💚 -2.33%</td></tr><tr><td>🟣 <b>syntex_syntax</b>:check:unchanged</td><td align="right">1.3992s</td><td align="right">1.3692s</td><td align="right">💚 -2.14%</td></tr><tr><td>Total</td><td align="right">2.8528s</td><td align="right">2.7910s</td><td align="right">💚 -2.17%</td></tr><tr><td>Summary</td><td align="right">1.0000s</td><td align="right">0.9803s</td><td align="right">💚 -1.97%</td></tr></table>	2024-04-05 11:11:17 +00:00
Vadim Petrochenkov	b40ea03f8a	rustc_index: Add a ZERO constant to index types ... It is commonly used.	2024-04-03 19:06:22 +03:00
Oli Scherer	3b94f33c23	Remove CacheSelector trait now that we can use GATs	2024-03-26 11:03:23 +00:00
John Kåre Alsaker	aa9c9a36c0	Add some comments and do some renames	2024-03-23 20:23:25 +01:00
John Kåre Alsaker	6119763e19	Encode dep graph edges directly from the previous graph when promoting	2024-03-23 20:03:55 +01:00
Jubilee	f54350a9ba	Rollup merge of #122245 - saethlin:check-dep-graph-size, r=petrochenkov ... Detect truncated DepGraph files I suspect that the following issues are caused by truncated incr comp files: * https://github.com/rust-lang/rust/issues/120582 * https://github.com/rust-lang/rust/issues/121499 * https://github.com/rust-lang/rust/issues/122210 We fail with an allocation failure or capacity overflow in this case because we assume that the ending bytes of an DepGraph file are the lengths of arrays. If the file has somehow been truncated then the ending bytes are probably some of our varint encoding, which tries to eliminate zero bytes, so interpreting a random 8 bytes as an array length has a very high chance of producing a byte capacity over `isize::MAX`. Now theoretically since https://github.com/rust-lang/rust/pull/119510 merged I have fixed the out-of-disk issues and yet in https://github.com/rust-lang/rust/issues/120894#issuecomment-1945126700 I still see some decoding failures that look like out-of-disk ICEs, for example https://crater-reports.s3.amazonaws.com/beta-1.77-1/beta-2024-02-10/gh/scottfones.aoc_2022/log.txt So this PR should ensure that we get an ICE that clearly identifies if the file in question is truncated.	2024-03-12 09:04:00 -07:00
bors	094a6204f5	Auto merge of #122064 - Zoxc:dep-graph-encode-tweaks, r=cjgillot ... Dep node encoding cleanups This does some cleanups around dep node encoding. Performance change with `-Zthreads=2`: <table><tr><td rowspan="2">Benchmark</td><td colspan="1"><b>Before</b></th><td colspan="2"><b>After</b></th><td colspan="1"><b>Before</b></th><td colspan="2"><b>After</b></th></tr><tr><td align="right">Time</td><td align="right">Time</td><td align="right">%</th><td align="right">Memory</td><td align="right">Memory</td><td align="right">%</th></tr><tr><td>🟣 <b>clap</b>:check:unchanged</td><td align="right">0.4337s</td><td align="right">0.4306s</td><td align="right"> -0.72%</td><td align="right">88.90 MiB</td><td align="right">89.04 MiB</td><td align="right"> 0.15%</td></tr><tr><td>🟣 <b>hyper</b>:check:unchanged</td><td align="right">0.1541s</td><td align="right">0.1528s</td><td align="right"> -0.86%</td><td align="right">51.99 MiB</td><td align="right">52.03 MiB</td><td align="right"> 0.07%</td></tr><tr><td>🟣 <b>regex</b>:check:unchanged</td><td align="right">0.3286s</td><td align="right">0.3248s</td><td align="right">💚 -1.15%</td><td align="right">71.89 MiB</td><td align="right">71.74 MiB</td><td align="right"> -0.21%</td></tr><tr><td>🟣 <b>syn</b>:check:unchanged</td><td align="right">0.6118s</td><td align="right">0.6057s</td><td align="right">💚 -1.01%</td><td align="right">106.59 MiB</td><td align="right">106.66 MiB</td><td align="right"> 0.06%</td></tr><tr><td>🟣 <b>syntex_syntax</b>:check:unchanged</td><td align="right">1.4570s</td><td align="right">1.4463s</td><td align="right"> -0.74%</td><td align="right">197.29 MiB</td><td align="right">197.33 MiB</td><td align="right"> 0.02%</td></tr><tr><td>Total</td><td align="right">2.9852s</td><td align="right">2.9601s</td><td align="right"> -0.84%</td><td align="right">516.66 MiB</td><td align="right">516.80 MiB</td><td align="right"> 0.03%</td></tr><tr><td>Summary</td><td align="right">1.0000s</td><td align="right">0.9911s</td><td align="right"> -0.89%</td><td align="right">1 byte</td><td align="right">1.00 bytes</td><td align="right"> 0.02%</td></tr></table> r? `@cjgillot`	2024-03-10 06:27:41 +00:00
Ben Kimock	11f8866ca8	Detect truncated incr comp files	2024-03-09 15:43:50 -05:00
John Kåre Alsaker	87ab9e8c6e	Some tweaks to the parallel query cycle handler	2024-03-09 00:24:14 +01:00
John Kåre Alsaker	9707e103ea	Avoid the double lock around EncoderState	2024-03-06 04:40:39 +01:00
John Kåre Alsaker	a2499bdfbe	Remove profiling from intern_node	2024-03-06 04:31:56 +01:00
John Kåre Alsaker	29cc76f0fc	Add a profiler reference to GraphEncoder	2024-03-06 04:17:17 +01:00
John Kåre Alsaker	dd0004a129	Don't panic when waiting on poisoned queries	2024-03-02 19:51:56 +01:00
Nicholas Nethercote	260ae70140	Overhaul how stashed diagnostics work, again. ... Stashed errors used to be counted as errors, but could then be cancelled, leading to `ErrorGuaranteed` soundness holes. #120828 changed that, closing the soundness hole. But it introduced other difficulties because you sometimes have to account for pending stashed errors when making decisions about whether errors have occured/will occur and it's easy to overlook these. This commit aims for a middle ground. - Stashed errors (not warnings) are counted immediately as emitted errors, avoiding the possibility of forgetting to consider them. - The ability to cancel (or downgrade) stashed errors is eliminated, by disallowing the use of `steal_diagnostic` with errors, and introducing the more restrictive methods `try_steal_{modify,replace}_and_emit_err` that can be used instead. Other things: - `DiagnosticBuilder::stash` and `DiagCtxt::stash_diagnostic` now both return `Option<ErrorGuaranteed>`, which enables the removal of two `delayed_bug` calls and one `Ty::new_error_with_message` call. This is possible because we store error guarantees in `DiagCtxt::stashed_diagnostics`. - Storing the guarantees also saves us having to maintain a counter. - Calls to the `stashed_err_count` method are no longer necessary alongside calls to `has_errors`, which is a nice simplification, and eliminates two more `span_delayed_bug` calls and one FIXME comment. - Tests are added for three of the four fixed PRs mentioned below. - `issue-121108.rs`'s output improved slightly, omitting a non-useful error message. Fixes #121451. Fixes #121477. Fixes #121504. Fixes #121508.	2024-02-29 11:08:27 +11:00
Nicholas Nethercote	899cb40809	Rename DiagnosticBuilder as Diag. ... Much better! Note that this involves renaming (and updating the value of) `DIAGNOSTIC_BUILDER` in clippy.	2024-02-28 08:55:35 +11:00
Nicholas Nethercote	6588f5b749	Rename Diagnostic as DiagInner. ... I started by changing it to `DiagData`, but that didn't feel right. `DiagInner` felt much better.	2024-02-28 08:33:25 +11:00
Matthias Krüger	47bf8a6c28	Rollup merge of #121401 - eltociear:patch-25, r=nnethercote ... Fix typo in serialized.rs accomodate -> accommodate	2024-02-22 18:09:54 +01:00
Nicholas Nethercote	46f4983356	Adjust the has_errors* methods. ... Currently `has_errors` excludes lint errors. This commit changes it to include lint errors. The motivation for this is that for most places it doesn't matter whether lint errors are included or not. But there are multiple places where they must be includes, and only one place where they must not be included. So it makes sense for `has_errors` to do the thing that fits the most situations, and the new `has_errors_excluding_lint_errors` method in the one exceptional place. The same change is made for `err_count`. Annoyingly, this requires the introduction of `err_count_excluding_lint_errs` for one place, to preserve existing error printing behaviour. But I still think the change is worthwhile overall.	2024-02-22 08:03:47 +11:00
Ikko Eltociear Ashimine	00234f0f68	Fix typo in serialized.rs ... accomodate -> accommodate	2024-02-22 00:33:23 +09:00
Markus Reiter	746a58d435	Use generic NonZero internally.	2024-02-15 08:09:42 +01:00
Nicholas Nethercote	05849e8c2f	Use fewer delayed bugs. ... For some cases where it's clear that an error has already occurred, e.g.: - there's a comment stating exactly that, or - things like HIR lowering, where we are lowering an error kind The commit also tweaks some comments around delayed bug sites.	2024-02-14 20:30:37 +11:00
Nicholas Nethercote	c1ffb0b675	Remove force_print_diagnostic. ... There are a couple of places where we call `inner.emitter.emit_diagnostic` directly rather than going through `inner.emit_diagnostic`, to guarantee the diagnostic is printed. This feels dubious to me, particularly the bypassing of `TRACK_DIAGNOSTIC`. This commit removes those. - In `print_error_count`, it uses `ForceWarning` instead of `Warning`. - It removes `DiagCtxtInner::failure_note`, because it only has three uses and direct use of `emit_diagnostic` is consistent with other similar locations. - It removes `force_print_diagnostic`, and adds `struct_failure_note`, and updates `print_query_stack` accordingly, which makes it more normal. That location doesn't seem to need forced printing anyway.	2024-02-14 07:51:53 +11:00
Matthias Krüger	46a0448405	Rollup merge of #120693 - nnethercote:invert-diagnostic-lints, r=davidtwco ... Invert diagnostic lints. That is, change `diagnostic_outside_of_impl` and `untranslatable_diagnostic` from `allow` to `deny`, because more than half of the compiler has been converted to use translated diagnostics. This commit removes more `deny` attributes than it adds `allow` attributes, which proves that this change is warranted. r? ````@davidtwco````	2024-02-09 14:41:50 +01:00
Nicholas Nethercote	0ac1195ee0	Invert diagnostic lints. ... That is, change `diagnostic_outside_of_impl` and `untranslatable_diagnostic` from `allow` to `deny`, because more than half of the compiler has be converted to use translated diagnostics. This commit removes more `deny` attributes than it adds `allow` attributes, which proves that this change is warranted.	2024-02-06 13:12:33 +11:00