63 Commits

Author	SHA1	Message	Date
Guillaume Gomez	91765d8c04	Convert more GUI tests colors to their original format	2023-05-14 00:16:16 +02:00
Guillaume Gomez	8e55400ec9	Convert some GUI tests color checks to use original format	2023-05-11 11:49:16 +02:00
Guillaume Gomez	0630283e9d	Migrate to 0.16.0 browser-ui-test version	2023-05-11 11:34:22 +02:00
Manish Goregaokar	ceef7e5ced	Rollup merge of #110371 - notriddle:notriddle/search-corrections, r=GuillaumeGomez ... rustdoc: restructure type search engine to pick-and-use IDs Fixes #110029 Preview: https://notriddle.com/rustdoc-demo-html-3/search-corrections/std/index.html?search=-%3E%20streaming  This change makes it so, instead of mixing string distance with type unification, function signature search works by mapping names to IDs at the start, reporting to the user any cases where it had to make corrections, and then matches with IDs when going through the items. This only changes function searches. Name searches are left alone, and corrections are only done when there's a single item in the search query.	2023-05-03 16:42:49 -07:00
Michael Howell	5cefe75436	rustdoc: remove unneeded handleKey from settings.js ... This code was added in 9dc5dfb975 and 704050da23 because the browser- native checkbox was `display: none`, breaking native keyboard accessibility. The native checkbox is now merely `appearance: none`, which does not turn off [behavior semantics], so JavaScript to reimplement it isn't needed any more. [behavior semantics]: https://w3c.github.io/csswg-drafts/css-ui/#appearance-semantics	2023-04-21 16:42:23 -07:00
Michael Howell	395840cd5e	rustdoc-search: use more descriptive "x not found; y instead" message	2023-04-20 14:32:02 -07:00
Michael Howell	b6f81e0434	rustdoc-search: give longer notification for type corrections	2023-04-19 12:56:52 -07:00
Michael Howell	4c11822aeb	rustdoc: restructure type search engine to pick-and-use IDs ... This change makes it so, instead of mixing string distance with type unification, function signature search works by mapping names to IDs at the start, reporting to the user any cases where it had to make corrections, and then matches with IDs when going through the items. This only changes function searches. Name searches are left alone, and corrections are only done when there's a single item in the search query.	2023-04-17 12:16:54 -07:00
bors	9693b178fc	Auto merge of #110252 - matthiaskrgr:rollup-ovaixra, r=matthiaskrgr ... Rollup of 8 pull requests Successful merges: - #109810 (Replace rustdoc-ui/{c,z}-help tests with a stable run-make test ) - #110035 (fix: ensure bad `#[test]` invocs retain correct AST) - #110089 (sync::mpsc: synchronize receiver disconnect with initialization) - #110103 (Report overflows gracefully with new solver) - #110122 (Fix x check --stage 1 when download-ci-llvm=false) - #110133 (Do not use ImplDerivedObligationCause for inherent impl method error reporting) - #110135 (Revert "Don't recover lifetimes/labels containing emojis as character literals") - #110235 (Fix `--extend-css` option) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup	2023-04-12 22:19:29 +00:00
Matthias Krüger	b53817df19	Rollup merge of #110205 - notriddle:notriddle/pixelated-border, r=GuillaumeGomez ... rustdoc: make settings radio and checks thicker, less contrast This is very dependent on subjectivity and what screen you use, but this change makes the radio buttons' outer circle less ugly. This is because I could see the pixels very clearly, thanks to the very thin line and high contrast. This change makes both less severe, giving your browser's antialiasing algorithm more to work with. Since it's thicker, lowering the contrast shouldn't impact visibility. ## Preview https://notriddle.com/rustdoc-demo-html-3/pixelated-border/settings.html ## Before  ## After  <details><summary>Original "after" image with 2px border around checked box</summary>  </details>	2023-04-12 20:56:23 +02:00
Guillaume Gomez	6bc6ea7a3e	Add/update tests for --extend-css option	2023-04-12 20:07:10 +02:00
Michael Howell	bb7ed64f45	rustdoc: use CSS overscroll-behavior instead of JavaScript ... Fixes the desktop scrolling weirdness mentioned in https://github.com/rust-lang/rust/pull/98775#issuecomment-1182575603 As described in the MDN page for this property: * The current Firefox ESR is 102, and the first Firefox version to support this feature is 59. * The current Chrome version 112, and the first version to support this is 63. * Edge is described as having a minor bug in `none` mode, but we use `contain` mode anyway, so it doesn't matter. * Safari 16, released September 2022, is the last browser to add this feature, and is also the oldest version we officially support.	2023-04-12 10:31:06 -07:00
Michael Howell	ad9a89eef2	rustdoc: make settings radio and checks thicker, less contrast ... This is very dependent on subjectivity and what screen you use, but this change makes the radio buttons' outer circle less ugly. This is because I could see the pixels very clearly, thanks to the very thin line and high contrast. This change makes both less severe, giving your browser's antialiasing algorithm more to work with. Since it's thicker, lowering the contrast shouldn't impact visibility.	2023-04-12 08:39:43 -07:00
Guillaume Gomez	010fa00b80	Update rustdoc GUI tests to new browser-ui-test version	2023-04-11 19:14:35 +02:00
Nilstrieb	370084860a	Rollup merge of #110037 - notriddle:notriddle/theme-default, r=GuillaumeGomez ... rustdoc: add test and bug fix for theme defaults Part of https://github.com/rust-lang/rust/issues/66181	2023-04-08 10:26:14 +02:00
Michael Howell	5cad51c0c5	rustdoc: add test and bug fix for theme defaults	2023-04-06 20:25:07 -07:00
Guillaume Gomez	529ceeeefc	Run collapsed GUI test in mobile mode as well	2023-04-06 20:26:27 +02:00
Guillaume Gomez	8f5404d0d7	Update GUI tests for logo display on very small screens	2023-04-05 21:38:52 +02:00
Guillaume Gomez	8aef0c7926	Add GUI test for scrollbar position on source code page	2023-04-04 16:35:53 +02:00
Guillaume Gomez	efad057eed	Add tests to check that collapsed content is expanded when jumping to it	2023-03-31 16:51:50 +02:00
Matthias Krüger	b39db705f5	Rollup merge of #109633 - GuillaumeGomez:fix-go-to-only-setting, r=notriddle ... Fix "Directly go to item in search if there is only one result" setting Part of #66181. The setting was actually broken, so I fixed it when I added the GUI test. r? `@notriddle`	2023-03-27 08:46:53 +02:00
Guillaume Gomez	bc9eec04b7	Add GUI test for "Directly go to item in search if there is only one result" setting	2023-03-26 17:50:09 +02:00
Matthias Krüger	236178698a	Rollup merge of #109595 - GuillaumeGomez:improve-gui-test-auto-hide-trait, r=notriddle ... Improve "Auto-hide trait implementation documentation" GUI test Part of #66181. I'll start working on the `include` command for `browser-ui-test` so we can greatly reduce the duplicated code between setting tests. r? ``@notriddle``	2023-03-26 08:39:27 +02:00
Guillaume Gomez	16bb7196a8	Improve "Auto-hide trait implementation documentation" GUI test	2023-03-25 15:28:18 +01:00
Guillaume Gomez	9cb7d4ca39	Add GUI test for "Auto-hide item methods' documentation" setting	2023-03-24 16:57:55 +01:00
Guillaume Gomez	ab1573a887	Add GUI test for "Auto-hide item contents for large items" setting	2023-03-20 20:25:35 +01:00
Matthias Krüger	83791f9de7	Rollup merge of #106915 - notriddle:notriddle/load-only-one-theme, r=GuillaumeGomez,jsha ... Only load one CSS theme by default This is a tweaked version of #103971 that uses `document.write` to create the stylesheet link at startup, avoiding a FOUC during page navigation. It also rebases the PR, making it work with the new hashed filenames. Fixes #82614 Preview: http://notriddle.com/notriddle-rustdoc-demos/load-only-one-theme-v2/std/index.html	2023-03-09 12:11:52 +01:00
Matthias Krüger	6c91ce27c3	Rollup merge of #108686 - notriddle:notriddle/jank-all, r=jsha ... rustdoc: include link on all.html location header This avoids a subtle layout shift when switching from the crate page to all items. ## Before | index.html | all.html | |------------|----------| |  |  | ## After | index.html | all.html | |------------|----------| |  |  |	2023-03-08 21:24:50 +01:00
Michael Howell	d4dce3e200	Update browser-ui-test version ... Use NEAR check to allow one pixel difference between scroll positions.	2023-03-08 12:49:35 -07:00
Michael Howell	af664be423	rustdoc: include link on all.html location header ... This avoids a subtle layout shift when switching from the crate page to all items.	2023-03-04 11:54:28 -07:00
Guillaume Gomez	cfb4af87e3	Add GUI test for rustdoc search errors background	2023-03-02 12:59:04 +01:00
Guillaume Gomez	4ff1c4d3e7	No need for the wait-for anymore to go around browser navigation bug	2023-02-23 22:04:38 +01:00
Dylan DPC	4165de40f8	Rollup merge of #107783 - notriddle:notriddle/item-table-ul, r=GuillaumeGomez ... rustdoc: simplify DOM for `.item-table` This switches from using `<div>` to the more semantic `<ul>`, and using class names that rhyme with the classes the search results table uses.	2023-02-19 13:03:41 +05:30
Matthias Krüger	3054759fa8	Rollup merge of #107340 - notriddle:notriddle/simplify-doctest-tooltip, r=GuillaumeGomez ... rustdoc: merge doctest tooltip with notable traits tooltip Fixes https://discord.com/channels/442252698964721669/443150878111694848/1066420140167680000 <details><summary>a user report where the tooltip arrow overlaps the text</summary>  </details> Fixes #91100 Preview: <https://notriddle.com/notriddle-rustdoc-demos/simplify-doctest-tooltip/std/vec/struct.Vec.html#indexing> Screenshot: 	2023-02-13 11:34:56 +01:00
Michael Howell	b0df355f80	rustdoc: use tighter line height in h1 and h2	2023-02-12 12:30:57 -07:00
Michael Howell	894c98652c	rustdoc: simplify DOM for .item-table ... This switches from using `<div>` to the more semantic `<ul>`, and using class names that rhyme with the classes the search results table uses.	2023-02-07 19:00:42 -07:00
bors	7c3f0d6f30	Auto merge of #107141 - notriddle:notriddle/max-lev-distance-2023, r=GuillaumeGomez ... rustdoc: compute maximum Levenshtein distance based on the query Preview: https://notriddle.com/notriddle-rustdoc-demos/search-lev-distance-2023/std/index.html?search=regex The heuristic is pretty close to the name resolver, maxLevDistance = `Math.floor(queryLen / 3)`. Fixes #103357 Fixes #82131 Similar to https://github.com/rust-lang/rust/pull/103710, but following the suggestion in https://github.com/rust-lang/rust/pull/103710#issuecomment-1296360267 to use `floor` instead of `ceil`, and unblocked now that https://github.com/rust-lang/rust/pull/105796 made it so that setting the max lev distance to `0` doesn't cause substring matches to be removed.	2023-02-06 02:09:00 +00:00
Michael Howell	7080f80e8b	rustdoc: remove unnecessary wrapper div.item-decl from HTML	2023-01-30 11:06:18 -07:00
Michael Howell	74e843c833	rustdoc: remove unused class has-srclink ... Stopped being used in CSS with 73d0f7c7b6	2023-01-28 17:18:56 -07:00
Michael Howell	7aa4a205a8	rustdoc: merge doctest tooltip with notable traits tooltip ... Fixes https://discord.com/channels/442252698964721669/443150878111694848/1066420140167680000 Fixes #91100	2023-01-27 09:04:39 -07:00
Yuki Okushi	17a2e1fef3	Rollup merge of #107336 - notriddle:notriddle/import-item-module-item, r=GuillaumeGomez ... rustdoc: remove mostly-unused CSS classes `import-item` and `module-item`	2023-01-27 12:57:57 +09:00
Yuki Okushi	145241402d	Rollup merge of #107242 - notriddle:notriddle/title-ordering, r=GuillaumeGomez ... rustdoc: make item links consistently use `title="{shortty} {path}"` The ordering in item tables was flipped in 3030cbea95, making it inconsistent with the ordering in method signatures. Compare these (before this PR is merged): c8e6a9e8b6/src/librustdoc/html/render/print_item.rs (L455-L459) c8e6a9e8b6/src/librustdoc/html/format.rs (L903-L908)	2023-01-27 12:57:55 +09:00
Michael Howell	97f8189614	rustdoc: remove mostly-unused CSS classes import/module-item	2023-01-26 12:55:19 -07:00
Michael Howell	5dd87c58aa	rustdoc: simplify settings popover DOM ... * Changes the class names so that they all start with `setting-`. That should make it harder to accidentally use a setting class outside the settings popover, where loading the CSS might accidentally change the styles of something unrelated. * Get rid of an unnecessary wrapper DIV around the radio button line. * Simplify CSS selectors by making the DOM easier and more intuitive to target.	2023-01-23 15:08:33 -07:00
Michael Howell	57ca36861d	rustdoc: make item links consistently use title="{shortty} {path}" ... The ordering in item tables was flipped in 3030cbea95, making it inconsistent with the ordering in method signatures. Compare these: c8e6a9e8b6/src/librustdoc/html/render/print_item.rs (L455-L459) c8e6a9e8b6/src/librustdoc/html/format.rs (L903-L908)	2023-01-23 14:31:35 -07:00
Guillaume Gomez	372ad130d5	Extend rustdoc GUI test for scraped examples top and bottom "borders"	2023-01-21 12:16:02 +01:00
Michael Howell	8211760b91	rustdoc: update test case to deal with "coo" only accepting dist=1	2023-01-21 00:11:39 -07:00
Michael Goulet	e12c6b277f	Rollup merge of #107045 - notriddle:notriddle/settings-css-setting-line, r=GuillaumeGomez ... rustdoc: remove redundant CSS rule `#settings .setting-line` Since the current version of settings.js always nests things below a div with ID `settings`, this rule always overrode the one above.	2023-01-18 18:00:31 -05:00
Michael Howell	34d595dda1	rustdoc: add test case for setting-line margin on settings.html	2023-01-18 12:48:24 -07:00
Michael Howell	bb5fb53b30	rustdoc: fix "?" keyboard command when radio button is focused ... This extends the special case with checkbox settings to also cover radios.	2023-01-18 12:14:00 -07:00