bors
9d0ccf01a1
Auto merge of #15597 - rmehri01:fix_promote_local_field_shorthand, r=HKalbasi
...
Field shorthand overwritten in promote local to const assist
Currently, running `promote_local_to_const` on the following:
```rust
struct Foo {
bar: usize,
}
fn main() {
let $0bar = 0;
let foo = Foo { bar };
}
```
Results in:
```rust
struct Foo {
bar: usize,
}
fn main() {
const BAR: usize = 0;
let foo = Foo { BAR };
}
```
But instead should be something like:
```rust
struct Foo {
bar: usize,
}
fn main() {
const BAR: usize = 0;
let foo = Foo { bar: BAR };
}
```
2023-09-16 16:48:21 +00:00
hkalbasi
f4704bc8ae
Switch to in-tree rustc dependencies with a cfg flag
2023-09-15 18:10:11 +03:30
shogo-nakano-desu
96c333262a
refactor: fix clippy lint
2023-09-15 16:47:39 +09:00
shogo-nakano-desu
0bb2298ac6
refactor: remove TODO with no explanation
2023-09-15 16:43:31 +09:00
shogo-nakano-desu
ebbbaaa90f
refactor: fix clippy lints
2023-09-15 16:43:21 +09:00
bors
12e28c3575
Auto merge of #15611 - Veykril:stability-import, r=Veykril
...
Prefer stable paths over unstable ones in import path calculation
Fixes https://github.com/rust-lang/rust-analyzer/issues/15610
2023-09-14 09:11:12 +00:00
Lukas Wirth
e63e323823
Prefer stable paths over unstable ones in import path calculation
2023-09-14 11:03:41 +02:00
bors
47c51b70dd
Auto merge of #15609 - WaffleLapkin:undup_sema, r=Veykril
...
Remove most of the duplication from `Semantics{,Impl}` via deref
See https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer/topic/Semantics.20vs.20SemanticsImpl/near/390795952
2023-09-14 06:23:54 +00:00
Maybe Waffle
a219dbda2b
Remove most of the duplication from Semantics{,Impl} via deref
2023-09-13 22:02:28 +00:00
bors
089ae47ebe
Auto merge of #15606 - Veykril:annotation-above-item-fi, r=Veykril
...
fix: Fix lens location "above_whole_item" breaking lenses
Fixes https://github.com/rust-lang/rust-analyzer/issues/15602
2023-09-13 20:02:06 +00:00
Lukas Wirth
712e67cf11
fix: Fix lens location "above_whole_item" breaking lenses
2023-09-13 22:01:04 +02:00
bors
15e1356149
Auto merge of #15601 - Veykril:diag-derive, r=Veykril
...
fix: Temporarily skip decl check in derive expansions
"Fixes https://github.com/rust-lang/rust-analyzer/issues/15344 "
2023-09-12 21:11:28 +00:00
Lukas Wirth
affe5a7315
fix: Temporarily skip decl check in derive expansions
2023-09-12 23:10:03 +02:00
David Barsky
2974416a81
fix: ensure rustfmt runs when configured with ./
2023-09-12 14:35:24 -04:00
Ryan Mehri
cd0a89ac4f
fix: field shorthand overwritten in promote local to const assist
2023-09-11 10:59:23 -07:00
dfireBird
df1239bf92
add tests for insert use with renamed imports
...
Tested for two cases:
1. Simple Use
2. Complex Use
2023-09-11 17:43:53 +05:30
dfireBird
d79486529e
remove as _ on auto importing on trait that is aliased with _
2023-09-11 17:43:53 +05:30
Ali Bektas
145a101fe8
Deunwrap add_missing_match_arms
2023-09-11 14:09:19 +02:00
Ali Bektas
893e19137e
Make assist lazy again
2023-09-11 13:33:26 +02:00
Ali Bektas
0863024b1a
Make assist lazy again
2023-09-11 13:31:42 +02:00
bors
cc6c8209cb
Auto merge of #15431 - alibektas:deunwrap/extract_function, r=Veykril
...
minor : Deunwrap extract_function
#15398 subtask 5.
2023-09-11 08:37:57 +00:00
bors
0e251ff768
Auto merge of #15232 - alibektas:14850, r=Veykril
...
ide : Disallow renaming of non-local items
fixes #14850 . This makes me wonder , why stop at structs and not do the same for other ADTs? Would be happy to add them too if nothing speaks against it.
2023-09-11 08:21:51 +00:00
Ryan Mehri
25b1b3e753
feat: add support for other ADT types and destructuring patterns
2023-09-10 22:21:12 -07:00
Ali Bektas
0118741632
v4
2023-09-10 23:25:36 +02:00
Ali Bektas
a0c8bee35e
Add more comments as requested
2023-09-10 23:19:58 +02:00
Ali Bektas
6dc7fa9423
v3
2023-09-10 23:19:58 +02:00
Ali Bektas
43edb51b21
Generalize disallowing of definition renaming
2023-09-10 23:19:58 +02:00
Ali Bektas
7ae70a06ce
Disallow renaming of non-local structs
2023-09-10 23:19:58 +02:00
Ali Bektas
2fdf7e4b75
v3
2023-09-10 23:15:37 +02:00
Ali Bektas
a66dbd11ed
v2
2023-09-10 23:15:05 +02:00
Ali Bektas
b316bccc97
replace for loops with sth more idiomatic
2023-09-10 23:15:05 +02:00
Ali Bektas
9c6257138d
Deunwrap convert_comment_block
2023-09-10 23:15:05 +02:00
Ali Bektas
0f1673c6f1
v3
2023-09-10 23:00:19 +02:00
Ali Bektas
6f7460484a
v2
2023-09-10 22:45:09 +02:00
Ali Bektas
35e0d800f0
Deunwrap extract_function
2023-09-10 22:45:09 +02:00
Ali Bektas
38491fcf07
v3
2023-09-10 22:39:07 +02:00
Ali Bektas
68d24b69d4
Deunwrap inline call v2
2023-09-10 22:39:07 +02:00
Ali Bektas
5683df2965
Deunwrap inline call
2023-09-10 22:39:07 +02:00
Ryan Mehri
7ba2e130b9
fix: add checks for overwriting incorrect ancestor
2023-09-10 00:21:11 -07:00
bors
326f37ef1f
Auto merge of #15592 - Veykril:shrink, r=Veykril
...
Shrink some stuff
2023-09-10 06:55:01 +00:00
Lukas Wirth
ccff704c25
Shrink some stuff
2023-09-10 08:24:26 +02:00
Ryan Mehri
2e13aed3bc
feat: support cross module imports
2023-09-09 11:59:59 -07:00
Ryan Mehri
136a9dbe36
style: rename some locals
2023-09-09 11:59:59 -07:00
Ryan Mehri
455dacfd3b
fix: only trigger assist on Name
2023-09-09 11:59:59 -07:00
Ryan Mehri
91ac1d6194
fix: initializing struct multiple times
2023-09-09 11:59:59 -07:00
Ryan Mehri
83196fd4d9
fix: remove trailing whitespace
2023-09-09 11:59:59 -07:00
Ryan Mehri
59738d5fd5
fix: add generated doctest
2023-09-09 11:59:58 -07:00
Ryan Mehri
d7a8e800c9
feat: initial version of bool_to_enum assist
2023-09-09 11:58:19 -07:00
bors
994df3d6a3
Auto merge of #15586 - Veykril:shrink, r=Veykril
...
shrink_to_fit body source map
2023-09-09 12:53:39 +00:00
Lukas Wirth
cfcef69072
shrink_to_fit body source map
2023-09-09 14:40:56 +02:00
