Guillaume Gomez
a8cc24a1ab
Rollup merge of #125779 - GuillaumeGomez:copy-code, r=rustdoc-team
...
[rustdoc] Add copy code feature
This PR adds a "copy code" to code blocks. Since this is a JS only feature, the HTML is generated with JS when the user hovers the code block to prevent generating DOM unless needed.
Two things to note:
1. I voluntarily kept the current behaviour of the run button (only when hovering a code block with a mouse) so it doesn't do anything on mobile. I plan to send a follow-up where the buttons would "expandable" or something. Still need to think which approach would be the best.
2. I used a picture and not text like the run button to remain consistent with the "copy path" button. I'd also prefer for the run button to use a picture (like what is used in mdbook) but again, that's something to be discussed later on.
The rendering looks like this:
It can be tested [here](https://guillaume-gomez.fr/rustdoc/bar/struct.Bar.html ) (without the run button) and [here](https://guillaume-gomez.fr/rustdoc/foo/struct.Bar.html ) (with the run button).
Fixes #86851 .
r? ``@notriddle``
2024-07-28 20:07:44 +02:00
Guillaume Gomez
015f5d6f76
Add rustdoc GUI test to check title with and without search
2024-07-27 12:12:16 +02:00
Guillaume Gomez
7de26684e8
Add regression test for items list size ( #128023 )
2024-07-22 11:33:03 +02:00
Jubilee
5bd7525856
Rollup merge of #128014 - GuillaumeGomez:stab-in-doc-blocks, r=notriddle
...
Fix stab display in doc blocks
Went across this bug randomly:
With the fixed CSS:
r? ```@notriddle```
2024-07-21 17:44:28 -07:00
Guillaume Gomez
84db684f49
Update source-code-page-code-scroll.goml GUI test
2024-07-21 12:47:34 +02:00
Guillaume Gomez
e4d701b1d3
Add regression test for stab display in doc blocks
2024-07-21 11:52:24 +02:00
Guillaume Gomez
eec3c3db88
Add GUI test for trait bounds display
2024-07-19 21:31:30 +02:00
Guillaume Gomez
590c01a5c5
Reduce width to ensure that the name is wider and thus still triggering the scroll
2024-07-19 21:31:30 +02:00
Matthias Krüger
1c665738de
Rollup merge of #127932 - notriddle:notriddle/current, r=GuillaumeGomez
...
rustdoc: fix `current` class on sidebar modnav
| Before | After |
| -- | -- |
|  | 
2024-07-19 10:48:06 +02:00
Michael Howell
2e1e627430
rustdoc: fix current class on sidebar modnav
2024-07-18 12:06:21 -07:00
Guillaume Gomez
c820a2392c
Add test for size of items in the items list
2024-07-18 20:48:20 +02:00
Guillaume Gomez
26d72512e0
Unify UI between code block buttons and top buttons
2024-07-18 14:16:29 +02:00
Guillaume Gomez
578810b4d2
Make "copy code" button the same size as the "copy path" button
2024-07-18 14:16:29 +02:00
Guillaume Gomez
ddaa90fc56
Add rustdoc GUI test for new copy code feature
2024-07-18 14:16:29 +02:00
Michael Howell
55149061ea
rustdoc: add test cases for mile wide bar
2024-07-16 13:29:35 -07:00
Michael Howell
3924493a10
rustdoc: make sidebar highlight cover whole click target
2024-07-15 17:44:05 -07:00
Michael Howell
5fc30b857c
rustdoc: click target for sidebar items flush left
2024-07-01 18:03:58 -07:00
Guillaume Gomez
c8bbeef12f
Don't call switch-theme function
2024-06-29 11:56:06 +02:00
Guillaume Gomez
b1d1e66389
Add back help-page.goml rustdoc GUI test
2024-06-29 11:56:06 +02:00
Guillaume Gomez
315be7d483
Update browser-ui-test version to 0.18.0
2024-06-27 00:04:23 +02:00
Guillaume Gomez
9e466d3361
Remove failing GUI test to stop blocking CI until it is fixed
2024-06-14 00:49:05 +02:00
Matthias Krüger
7af9ad1465
Rollup merge of #124738 - notriddle:notriddle/search-form-js, r=GuillaumeGomez
...
rustdoc: dedup search form HTML
This change constructs the search form HTML using JavaScript, instead of plain HTML. It uses a custom element because
- the [parser]'s insert algorithm runs the connected callback synchronously, so we won't get layout jank
- it requires very little HTML, so it's a real win in size
[parser]: https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token
This shrinks the standard library by about 60MiB, by my test.
There should be no visible changes. Just use less disk space.
2024-05-07 18:12:54 +02:00
Guillaume Gomez
e460901b13
Add GUI regression test for setting's cog color
2024-05-05 20:07:12 +02:00
Guillaume Gomez
0cbebd07ee
Fix bad color for setting cog in ayu theme
2024-05-05 20:07:12 +02:00
Michael Howell
eeb59f16a5
rustdoc: dedup search form HTML
...
This change constructs the search form HTML using JavaScript, instead of plain HTML. It uses a custom element because
- the [parser]'s insert algorithm runs the connected callback synchronously, so we won't get layout jank
- it requires very little HTML, so it's a real win in size
[parser]: https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token
This shrinks the standard library by about 60MiB, by my test.
2024-05-05 08:15:08 -07:00
Matthias Krüger
e9b0c91cdd
Rollup merge of #124197 - GuillaumeGomez:move-duplicated-code, r=notriddle
...
Move duplicated code in functions in `tests/rustdoc-gui/notable-trait.goml`
It also allowed me to add some new common test like:
```
assert-position: (
"//*[`@class='tooltip` popover']",
{"x": |popover_x|}
)
```
r? `@notriddle`
2024-04-23 06:24:56 +02:00
Guillaume Gomez
dd01f75a89
Move duplicated code in functions in tests/rustdoc-gui/notable-trait.goml
2024-04-20 14:53:14 +02:00
Guillaume Gomez
1ebc9efa78
Add GUI test for copy path button
2024-04-17 16:56:14 +02:00
Michael Howell
3a007dbea9
rustdoc: update test cases
2024-04-09 20:22:13 -07:00
Guillaume Gomez
66bc97cc88
Make theme switching closer to reality
2024-04-08 12:14:41 +02:00
Guillaume Gomez
53c5a69dfd
Move check-container-color's code into check-search-color function
2024-04-06 15:52:00 +02:00
Guillaume Gomez
2b1c799636
Move duplicated code into check-search-color function
2024-04-06 15:47:12 +02:00
Guillaume Gomez
f14e4db1f9
Move more common code into a function in tests/rustdoc-gui/search-result-color.goml
2024-04-06 15:24:09 +02:00
Guillaume Gomez
4967895e55
Move search-result-color.goml common parts into a function
2024-04-06 14:53:30 +02:00
Guillaume Gomez
7659ef47f0
Use include command to reduce code duplication
2024-04-05 21:38:55 +02:00
Guillaume Gomez
a815b97850
Add regression test to ensure that even if JS is enabled but not working, a theme will still get applied
2024-04-04 23:49:34 +02:00
Guillaume Gomez
8f9d93bf57
Add GUI test to ensure there is always a theme applied if JS is disabled
2024-04-03 14:27:20 +02:00
Guillaume Gomez
0bb1ec729f
Remove redundant code comments
2024-04-02 10:42:32 +02:00
Guillaume Gomez
59120d0ef5
Update to new browser-ui-test version
2024-04-01 22:25:01 +02:00
xiaoxiangxianzi
3157114f0b
chore: fix some comments
...
Signed-off-by: xiaoxiangxianzi <zhaoyizheng@outlook.com>
2024-03-27 22:32:53 +08:00
许杰友 Jieyou Xu (Joe)
6e48b96692
[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives
2024-02-22 16:04:04 +00:00
Guillaume Gomez
5d29f5a6de
Add regression test for #120471 to ensure that long crate name are handled as expected on mobile
2024-01-31 16:40:23 +01:00
Matthias Krüger
6687e8e460
Rollup merge of #119746 - notriddle:notriddle/resize-close-modals, r=fmease
...
rustdoc: hide modals when resizing the sidebar
Follow-up for
https://github.com/rust-lang/rust/pull/119477#discussion_r1439085011
CC `@lukas-code`
2024-01-22 07:56:42 +01:00
Matthias Krüger
cad609d9e3
Rollup merge of #117662 - GuillaumeGomez:links-in-headings, r=notriddle
...
[rustdoc] Allows links in headings
Reopening of https://github.com/rust-lang/rust/pull/94360 .
# Explanations
Rustdoc currently doesn't follow the markdown spec on headings: we don't allow links in them. So instead of having headings linking to themselves, this PR generates an anchor on the left side like this:
<details>
<summary>previous version</summary>
</details>
Having the anchor always displayed allows for mobile devices users to be able to have a link to the anchor. The different color used for the anchor itself is the same as links so people notice when looking at it that they can click on it.
You can test it [here](https://rustdoc.crud.net/imperio/links-in-headings/std/index.html ).
cc `@camelid`
r? `@notriddle`
2024-01-19 19:26:59 +01:00
Michael Howell
8b52275ee3
rustdoc: hide modals when resizing the sidebar
...
Follow-up for
https://github.com/rust-lang/rust/pull/119477#discussion_r1439085011
2024-01-08 09:54:05 -07:00
Lukas Markeffsky
d796ad4209
rustdoc ui: adjust tooltip z-index to be above sidebar
2023-12-31 20:31:56 +01:00
bors
67b6975051
Auto merge of #119066 - notriddle:notriddle/sidebar-source-redesign, r=GuillaumeGomez
...
rustdoc: clean up source sidebar hide button
This is a redesign of the feature, with parts pulled from https://github.com/rust-lang/rust/pull/119049 but with a button that looks more like a button and matches the one used on other sidebar pages.
Preview:
* http://notriddle.com/rustdoc-html-demo-8/source-sidebar-resize/src/std/lib.rs.html
* http://notriddle.com/rustdoc-html-demo-8/source-sidebar-resize/std/index.html
| | Before | After |
|--|--|--|
| Closed |  | 
| Open |  | 
| Mobile Closed |  | 
| Mobile Open |  | 
2023-12-31 15:32:15 +00:00
Michael Howell
624885d242
rustdoc: treat query string + as space
...
Fixes #119219
2023-12-26 14:14:28 -07:00
Guillaume Gomez
98b71bf345
Add GUI regression test for position of warning block
2023-12-24 19:24:04 +01:00
Michael Howell
9566db1e49
Fix corner cases when dealing with mobile mode
2023-12-19 19:50:53 -07:00
