Lukas Wirth
3688064ff5
Clippy
2024-02-07 17:08:38 +01:00
Lukas Wirth
731b159f10
Remove dev-dependency diff
2024-02-07 16:34:21 +01:00
Lukas Wirth
e339c65a1a
Remove dev-dependency insta
2024-02-07 16:30:20 +01:00
Lukas Wirth
def5a1d0c4
unreachable-pub
2024-02-07 16:30:13 +01:00
Lukas Wirth
bc5823d5bb
Bump salsa dev-deps
2024-02-07 16:30:07 +01:00
Lukas Wirth
0a6197df97
rustfmt
2024-02-07 16:30:00 +01:00
Lukas Wirth
159a03ad7b
Move salsa fork in-tree
2024-02-07 16:29:46 +01:00
davidsemakula
d7a03022f7
handle divergence in child if expr for unnecessary else diagnostic fix
2024-02-06 19:00:10 +03:00
davidsemakula
62cc4f9c46
add unnecessary else diagnostic
2024-02-06 19:00:10 +03:00
Laurențiu Nicola
2c4152847a
Add lete to postfix completion list
2024-02-06 13:13:51 +02:00
bors
6671d3c9a3
Auto merge of #16499 - Nadrieril:update-pat-ana, r=lnicola
...
internal: Update rustc_pattern_analysis dependency
Just bumping the dependency, as I've been making API changes over on the rustc side. More API changes incoming in the coming weeks.
One benefit of this: we no longer abort in the `DeconstructedPat: Debug` impl, which means we can use `tracing` to investigate issues.
2024-02-06 07:04:33 +00:00
Nadrieril
d2d4119d24
Don't need an arena for types anymore
2024-02-06 05:09:30 +01:00
Nadrieril
ba7b12e062
Update rustc_pattern_analysis dependency
2024-02-06 05:08:19 +01:00
Nadrieril
c2d21242aa
Tweak variant_id_for_adt
2024-02-06 05:01:05 +01:00
Matthias Krüger
ac9d1a03a7
remove clones
2024-02-05 23:15:47 +01:00
bors
66cec4d11a
Auto merge of #16470 - Veykril:clippy-disallow, r=lnicola
...
internal: Lint debug prints and disallowed types with clippy
2024-02-05 17:20:43 +00:00
dfireBird
53db37f9bf
restrict cursor range to show assists
2024-02-05 18:53:40 +05:30
bors
cb37fcc616
Auto merge of #16493 - Young-Flash:method_call_parser, r=Veykril
...
fix: emit parser error for missing argument list
close https://github.com/rust-lang/rust-analyzer/issues/16362
2024-02-05 13:03:03 +00:00
Young-Flash
864c3d5880
test: add method_call_missing_argument_list error test
2024-02-05 17:54:09 +08:00
Young-Flash
c495e3f00f
fix: emit parser error for missing argument list
2024-02-05 17:54:09 +08:00
bors
7fb639ffc1
Auto merge of #16482 - GnomedDev:boxed-subtree, r=lnicola
...
Swap Subtree::token_trees from Vec to boxed slice
Performs one of the optimizations suggested in #16325 , but a little bit more. Boxed slices guarantee `shrink_to_fit` aswell as saving a pointer width as no capacity has to be stored.
Most of the diff is:
- Changing `vec![]` to `Box::new([])`
- Changing initialize -> fill into fill -> into_boxed_slice
- Working around the lack of an owned iterator or automatic iteration over a `Box<[T]>`
I would like to use my own crate, [small-fixed-array](https://lib.rs/small-fixed-array ), although I understand if it isn't mature enough for this. If I'm given the go ahead, I can rework this PR to use it instead.
2024-02-05 09:14:06 +00:00
bors
3e47532dd4
Auto merge of #16474 - davidbarsky:david/import-on-the-fly-improvements, r=lnicola
...
internal: even more `tracing`
As part of profiling completions, I added some additional spans and moved `TyBuilder::subst_for_def` closer to its usage site (the latter had a small impact on completion performance. Thanks for the tip, Lukas!)
2024-02-05 09:01:58 +00:00
bors
081cf026b8
Auto merge of #16480 - GnomedDev:remove-unused-visit_ids, r=lnicola
...
Remove unused Subtree::visit_ids function
Completely unused, nothing else even shows up when searching for `visit_ids`.
2024-02-05 08:49:39 +00:00
Shoyu Vanilla
26715a8fde
cargo fmt
2024-02-05 10:48:34 +09:00
Shoyu Vanilla
983cce8c31
Typo fix
2024-02-05 10:37:58 +09:00
Shoyu Vanilla
f0428e57ea
Simplify redundant coercion
2024-02-05 10:35:12 +09:00
davidsemakula
b45ee82811
incorrect case diagnostics for param names of trait impl assoc functions
2024-02-05 01:31:28 +03:00
GnomedDev
a607e1b04b
Use reserve_exact for pushing to Subtree
2024-02-04 22:17:20 +00:00
davidsemakula
33b3b6dbf9
refactor: disable "unused" lint using parameter name
2024-02-05 01:07:44 +03:00
Shoyu Vanilla
97ecfe4fab
Remove unnecessary .as_ref() in generate getter assist
2024-02-05 00:44:57 +09:00
Laurențiu Nicola
38b5c8c966
Try to fix in-tree build
2024-02-04 11:07:35 +02:00
Laurențiu Nicola
b8a3180a60
Merge commit '0113bc9388b480fa42c632f57f4f0f7af5813ec1' into sync-from-ra
2024-02-04 10:37:58 +02:00
GnomedDev
8011b56827
Swap Subtree::token_trees from Vec to boxed slice
2024-02-04 00:28:22 +00:00
GnomedDev
1451270372
Remove unused Subtree::visit_ids function
2024-02-03 17:22:45 +00:00
davidsemakula
d761d86f03
refactor hir-ty::diagnostics::decl_check for enum variants
2024-02-03 17:36:11 +03:00
davidsemakula
8e29104178
refactor hir-ty::diagnostics::decl_check for struct fields
2024-02-03 17:33:25 +03:00
davidsemakula
23aa872f3c
refactor hir-ty::diagnostics::decl_check for function bodies
2024-02-03 16:40:55 +03:00
davidsemakula
c0071ace5a
refactor hir-ty::diagnostics::decl_check
2024-02-03 15:51:14 +03:00
davidsemakula
46d79e21b5
add allow and deny attribute tests for incorrect case diagnostics for traits
2024-02-02 17:07:08 +03:00
davidsemakula
080d223dd4
incorrect case diagnostics for type aliases
2024-02-02 17:07:08 +03:00
davidsemakula
0ffc088439
no incorrect case diagnostics for trait impl assoc functions and consts except for pats in fn bodies
2024-02-02 17:07:08 +03:00
davidsemakula
6d2d6323ac
incorrect case diagnostics for trait assoc functions and consts
2024-02-02 17:07:08 +03:00
davidsemakula
5fe3b75677
incorrect case diagnostics for trait name
2024-02-02 17:07:08 +03:00
bors
8f6a72871e
Auto merge of #16469 - Young-Flash:ci_typos, r=lnicola
...
internal: add typos check CI (part 2)
follow up https://github.com/rust-lang/rust-analyzer/pull/16448
2024-02-02 12:02:48 +00:00
Young-Flash
ba2910a3a7
minor: correct some typos
2024-02-02 18:22:54 +08:00
Laurențiu Nicola
4f09335063
Merge remote-tracking branch 'upstream/master' into sync-from-rust
2024-02-02 08:40:28 +02:00
David Barsky
f9bef39d48
internal: add some more tracing spans inside of hir-ty
2024-02-01 16:10:32 -05:00
David Barsky
0fd770613b
internal: Move TyBuilder::subst_for_def into a block
2024-02-01 16:06:05 -05:00
Lukas Wirth
9e8a0fae0c
Lint debug prints and disallowed types with clippy
2024-02-01 17:57:27 +01:00
bors
850ba2fb63
Auto merge of #16451 - Urhengulas:satisfy-clippy, r=Veykril
...
internal: Work through temporarily allowed clippy lints, part 2
Another follow-up to https://github.com/rust-lang/rust-analyzer/pull/16401 .
2024-02-01 14:23:18 +00:00
bors
42cb1a2bd7
Auto merge of #16465 - Veykril:eprintln, r=Veykril
...
minor: Remove `stdx::eprintln` overwrite
2024-01-31 21:07:50 +00:00
Lukas Wirth
23f4b7f45f
Remove stdx::eprintln overwrite
2024-01-31 22:06:05 +01:00
clubby789
a1fdb876c3
Remove abi_amdgpu_kernel references
2024-01-31 19:06:10 +00:00
bors
039681112f
Auto merge of #16456 - davidbarsky:david/tracing-followups, r=Veykril
...
internal: `tracing` improvements and followups
Hi folks! Building on https://github.com/rust-lang/rust-analyzer/pull/16394 , I've got a few small tweaks:
- Removed the accidental `mod.rs` usage that I introduced.
- Removed a panic in `pat_analysis.rs`.
- Recorded the event kind in `handle_event` to better distinguish what _kind_ of event is being handled.
- Did a small refactor of `hprof` to have somewhat more linear control flow, and more importantly, write the recorded fields to the output.
The end result is the following:
<img width="1530" alt="A screenshot of Visual Studio Code on a Mac. `hprof.rs` is open, with " src="https://github.com/rust-lang/rust-analyzer/assets/2067774/bd11dde5-b2da-4774-bc38-bcb4772d1192 ">
2024-01-31 18:29:51 +00:00
David Barsky
44494e235a
internal: teach hprof to record tracing fields
2024-01-31 13:15:47 -05:00
Johann Hemmann
df2c7a6e4e
cargo clippy --fix
2024-01-31 19:06:36 +01:00
Johann Hemmann
771c6c9271
format_collect
2024-01-31 19:06:36 +01:00
Johann Hemmann
d37f4e0d21
new_without_default
2024-01-31 19:06:36 +01:00
Johann Hemmann
e7e09e7750
large_enum_variant
2024-01-31 19:06:35 +01:00
Johann Hemmann
04ccef80cb
field_reassign_with_default
2024-01-31 19:06:18 +01:00
Johann Hemmann
dd9f27b8d3
borrow_deref_ref
2024-01-31 19:06:18 +01:00
Johann Hemmann
c4688343de
derivable_impls
2024-01-31 19:06:18 +01:00
Johann Hemmann
0adb4d1685
wildcard_in_or_patterns
2024-01-31 19:06:18 +01:00
Johann Hemmann
b176cf2478
useless_format
2024-01-31 19:06:18 +01:00
Johann Hemmann
b73ee2f50d
useless_conversion
2024-01-31 19:06:18 +01:00
Johann Hemmann
e7d0deac53
unnecessary_mut_passed
2024-01-31 19:06:18 +01:00
Johann Hemmann
f191b80799
Refactor
2024-01-31 19:06:18 +01:00
Johann Hemmann
c4302eaa56
unnecessary_lazy_evaluations
2024-01-31 19:06:18 +01:00
Johann Hemmann
f15ee8a380
unnecessary_filter_map
2024-01-31 19:06:18 +01:00
Johann Hemmann
de6f9561f2
unnecessary_cast
2024-01-31 19:06:18 +01:00
Johann Hemmann
daa20725c5
toplevel_ref_arg
2024-01-31 19:06:18 +01:00
Johann Hemmann
386d438e17
skip_while_next
2024-01-31 19:06:18 +01:00
David Barsky
579e98c4c5
internal: record Event kind in handle_event
2024-01-31 13:00:40 -05:00
David Barsky
251b14f2c5
internal: don't panic in debug_pat
2024-01-31 13:00:30 -05:00
bors
355c9444e1
Auto merge of #16448 - Young-Flash:typos, r=lnicola
...
minor: correct typos
I use [crate-ci/typos](https://github.com/crate-ci/typos ) to check typos in codebase, if it's ok with you, I'd like to add a typo check CI using [typos](https://github.com/crate-ci/typos ) (with Apache-2.0, MIT licenses).
BTW, we can add a [_typos.toml](https://github.com/crate-ci/typos/blob/master/docs/reference.md ) as white list for some intentional typos
2024-01-31 13:29:55 +00:00
Young-Flash
62ff8f33d4
minor: correct close to closure
2024-01-31 21:26:30 +08:00
bors
9d837a622d
Auto merge of #16445 - lnicola:bump-scip, r=lnicola
...
internal: Bump scip
Fixes #16440
2024-01-31 09:27:01 +00:00
bors
2661c272c9
Auto merge of #16461 - Veykril:expansion-info, r=Veykril
...
internal: Remove unnecessary usages of ExpansionInfo
And some follow up simplifications to https://github.com/rust-lang/rust-analyzer/pull/16439
2024-01-31 08:58:55 +00:00
Lukas Wirth
d252247ab7
internal: Remove unnecessary usages of ExpansionInfo
2024-01-31 09:57:17 +01:00
bors
e48bc04eaf
Auto merge of #16459 - Veykril:diagnostics, r=Veykril
...
internal: Use improved adjusted_display_range for all diagnostics
2024-01-31 08:17:53 +00:00
Lukas Wirth
604479c373
internal: Use improved adjusted_display_range for all diagnostics
2024-01-31 09:16:30 +01:00
bors
e4146af294
Auto merge of #16441 - Young-Flash:exclude_tests_refs, r=Veykril
...
feat: enable excluding refs search results in test
## Change
Here I introduce a new `ReferenceCategory::Test` type to indicate whether the function where this reference is located is marked as `#[test]`, and expose an config item (`rust-analyzer.references.excludeTests`) to client.
I also changed the signature of `ReferenceCategory::new`, adding a `sema: &Semantics<'_, RootDatabase>` param to do some hir analysis. Hope the current implementation is good to go.
## Demo
`"rust-analyzer.references.excludeTests": false`
`"rust-analyzer.references.excludeTests": true`
close https://github.com/rust-lang/rust-analyzer/issues/14530
2024-01-31 07:53:28 +00:00
David Barsky
17d2e8d910
internal: remove tracing/mod.rs
2024-01-30 13:37:27 -05:00
David Barsky
e1ea7c8844
internal: switch to tracing from log
...
This commit also adds `tracing` to NotificationDispatcher/RequestDispatcher,
bumps `rust-analyzer-salsa` to 0.17.0-pre.6, `always-assert` to 0.2, and
removes the homegrown `hprof` implementation in favor of a vendored
tracing-span-tree.
2024-01-30 12:27:31 -05:00
bors
63123ab408
Auto merge of #16417 - davidsemakula:normalize-use-trees, r=Veykril
...
feat: "Normalize import" assist and utilities for normalizing use trees
- Add import/use tree normalization utilities
- Add "normalize import" assist
- Update "merge imports" assist to always apply to the covering use item except for nested use tree selections
- Update "merge imports" assist to avoid adding unnecessary braces when merging nested use tree selections
See [this discussion](https://github.com/rust-lang/rust-analyzer/pull/16372#discussion_r1457244321 ) for the motivation for the new "normalize import" assist and changes to the "merge imports" assist.
2024-01-30 14:55:08 +00:00
Johann Hemmann
43b1ae0446
cargo clippy --fix
2024-01-30 14:50:21 +01:00
Johann Hemmann
75a42f1a09
collapsible_if
2024-01-30 14:44:44 +01:00
Young-Flash
db9fd370ee
minor: correct typos
2024-01-30 21:43:43 +08:00
davidsemakula
dba3fc4425
style: remove unnecessary macro
2024-01-30 16:15:15 +03:00
bors
11b401d0b4
Auto merge of #16447 - Veykril:mir-errors, r=Veykril
...
intenral: Cleanup error variants in MIR code a bit
2024-01-30 11:38:41 +00:00
bors
22b6f9679d
Auto merge of #16439 - wasd96040501:feat/gotodef3, r=Veykril
...
feat: Support for GOTO def from *inside* files included with include! macro
close #14937
Try to implement goto def from *inside* files included with include! macro.
This implementation has two limitations:
1. Only **one** file which calls include! will be tracked. (I think multiple file be included is a rare case and we may let it go for now)
2. Mapping token from included file to macro call file (semantics.rs:646~658) works fine but I am not sure is this the correct way to implement.
2024-01-30 11:27:18 +00:00
Lukas Wirth
5860763f18
Cleanup error variants in MIR code slightly
2024-01-30 09:53:39 +01:00
Laurențiu Nicola
20c01672a8
Bump scip
2024-01-30 08:43:17 +02:00
Young-Flash
2b71acac4f
test: add full path ref exclude test case
2024-01-29 18:47:58 +08:00
Young-Flash
6181102567
fix: use Semantics to judge whether a func is marked as #[test]
2024-01-29 18:42:41 +08:00
Laurențiu Nicola
f43cea0878
Merge commit '7219414e81810fd4d967136c4a0650523892c157' into sync-from-ra
2024-01-28 15:56:54 +02:00
Young-Flash
1bd21e98c0
test: add test for excluding refs
2024-01-28 18:39:42 +08:00
Young-Flash
6f303f49fe
feat: enable excluding refs search results in test
2024-01-28 18:28:13 +08:00
davidsemakula
84e13145ff
add more tests for normalize import assist
2024-01-28 11:55:01 +03:00
davidsemakula
fc00602723
merge imports assist avoids adding unnecessary braces when merging nested use tree selections
2024-01-28 11:55:01 +03:00
