ext/ucred: Support PID in peer creds on macOS

This commit is contained in:
William Woodruff 2020-11-24 13:46:51 -05:00
parent 53d19b37c5
commit fe0bea2cc1
No known key found for this signature in database
GPG Key ID: 600D68320BE45ACC
2 changed files with 65 additions and 5 deletions

View File

@ -31,12 +31,16 @@ pub use self::impl_linux::peer_cred;
#[cfg(any(
target_os = "dragonfly",
target_os = "freebsd",
target_os = "ios",
target_os = "macos",
target_os = "openbsd"
))]
pub use self::impl_bsd::peer_cred;
#[cfg(any(
target_os = "macos",
target_os = "ios",
))]
pub use self::impl_mac::peer_cred;
#[cfg(any(target_os = "linux", target_os = "android"))]
pub mod impl_linux {
use super::UCred;
@ -75,8 +79,6 @@ pub mod impl_linux {
#[cfg(any(
target_os = "dragonfly",
target_os = "macos",
target_os = "ios",
target_os = "freebsd",
target_os = "openbsd"
))]
@ -95,3 +97,44 @@ pub mod impl_bsd {
}
}
}
#[cfg(any(
target_os = "macos",
target_os = "ios",
))]
pub mod impl_mac {
use super::UCred;
use crate::{io, mem};
use crate::os::unix::io::AsRawFd;
use crate::os::unix::net::UnixStream;
use libc::{c_void, getpeereid, getsockopt, pid_t, socklen_t, SOL_LOCAL, LOCAL_PEERPID};
pub fn peer_cred(socket: &UnixStream) -> io::Result<UCred> {
let mut cred = UCred { uid: 1, gid: 1, pid: None };
unsafe {
let ret = getpeereid(socket.as_raw_fd(), &mut cred.uid, &mut cred.gid);
if ret != 0 {
return Err(io::Error::last_os_error());
}
let mut pid: pid_t = 1;
let mut pid_size = mem::size_of::<pid_t>() as socklen_t;
let ret = getsockopt(
socket.as_raw_fd(),
SOL_LOCAL,
LOCAL_PEERPID,
&mut pid as *mut pid_t as *mut c_void,
&mut pid_size
);
if ret == 0 && pid_size as usize == mem::size_of::<pid_t>() {
cred.pid = Some(pid);
Ok(cred)
} else {
Err(io::Error::last_os_error())
}
}
}
}

View File

@ -1,5 +1,5 @@
use crate::os::unix::net::UnixStream;
use libc::{getegid, geteuid};
use libc::{getegid, geteuid, getpid};
#[test]
#[cfg(any(
@ -23,3 +23,20 @@ fn test_socket_pair() {
assert_eq!(cred_a.uid, uid);
assert_eq!(cred_a.gid, gid);
}
#[test]
#[cfg(any(
target_os = "linux",
target_os = "ios",
target_os = "macos",
))]
fn test_socket_pair_pids(arg: Type) -> RetType {
// Create two connected sockets and get their peer credentials.
let (sock_a, sock_b) = UnixStream::pair().unwrap();
let (cred_a, cred_b) = (sock_a.peer_cred().unwrap(), sock_b.peer_cred().unwrap());
// On supported platforms (see the cfg above), the credentials should always include the PID.
let pid = unsafe { getpid() };
assert_eq!(cred_a.pid, Some(pid));
assert_eq!(cred_b.pid, Some(pid));
}