nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-04-16 14:07:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove numeric literals from print_literal and write_literal tests

Browse Source
This commit is contained in:
pro-grammer1 2021-01-17 18:55:59 +00:00
parent ab155b14a2
commit fb2a06dcce
6 changed files with 31 additions and 73 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clippy_lints/src/write.rs
View File

@ -461,7 +461,7 @@ impl Write {
span_lint(cx, lint, token_expr.span, "literal with an empty format string");
}
idx += 1;
}
},
ExprKind::Assign(lhs, rhs, _) => {
if_chain! {
if let ExprKind::Lit(ref lit) = rhs.kind;

4
tests/ui/crashes/ice-3891.stderr
View File

@ -1,10 +1,10 @@
error: invalid suffix `x` for integer literal
error: invalid suffix `x` for number literal
--> $DIR/ice-3891.rs:2:5
|
LL | 1x;
| ^^ invalid suffix `x`
|
= help: the suffix must be one of the integral types (`u32`, `isize`, etc)
= help: the suffix must be one of the numeric types (`u32`, `isize`, `f32`, etc.)
error: aborting due to previous error

3
tests/ui/print_literal.rs
View File

@ -19,12 +19,9 @@ fn main() {
println!("{number:>0width$}", number = 1, width = 6);
// these should throw warnings
println!("{} of {:b} people know binary, the other half doesn't", 1, 2);
print!("Hello {}", "world");
println!("Hello {} {}", world, "world");
println!("Hello {}", "world");
println!("10 / 4 is {}", 2.5);
println!("2 + 1 = {}", 3);
// positional args don't change the fact
// that we're using a literal -- this should

46
tests/ui/print_literal.stderr
View File

@ -1,88 +1,70 @@
error: literal with an empty format string
--> $DIR/print_literal.rs:22:71
--> $DIR/print_literal.rs:22:24
|
LL | println!("{} of {:b} people know binary, the other half doesn't", 1, 2);
| ^
LL | print!("Hello {}", "world");
| ^^^^^^^
|
= note: `-D clippy::print-literal` implied by `-D warnings`
error: literal with an empty format string
--> $DIR/print_literal.rs:23:24
|
LL | print!("Hello {}", "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/print_literal.rs:24:36
--> $DIR/print_literal.rs:23:36
|
LL | println!("Hello {} {}", world, "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/print_literal.rs:25:26
--> $DIR/print_literal.rs:24:26
|
LL | println!("Hello {}", "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/print_literal.rs:26:30
|
LL | println!("10 / 4 is {}", 2.5);
| ^^^
error: literal with an empty format string
--> $DIR/print_literal.rs:27:28
|
LL | println!("2 + 1 = {}", 3);
| ^
error: literal with an empty format string
--> $DIR/print_literal.rs:32:25
--> $DIR/print_literal.rs:29:25
|
LL | println!("{0} {1}", "hello", "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/print_literal.rs:32:34
--> $DIR/print_literal.rs:29:34
|
LL | println!("{0} {1}", "hello", "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/print_literal.rs:33:25
--> $DIR/print_literal.rs:30:25
|
LL | println!("{1} {0}", "hello", "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/print_literal.rs:33:34
--> $DIR/print_literal.rs:30:34
|
LL | println!("{1} {0}", "hello", "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/print_literal.rs:36:35
--> $DIR/print_literal.rs:33:35
|
LL | println!("{foo} {bar}", foo = "hello", bar = "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/print_literal.rs:36:50
--> $DIR/print_literal.rs:33:50
|
LL | println!("{foo} {bar}", foo = "hello", bar = "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/print_literal.rs:37:35
--> $DIR/print_literal.rs:34:35
|
LL | println!("{bar} {foo}", foo = "hello", bar = "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/print_literal.rs:37:50
--> $DIR/print_literal.rs:34:50
|
LL | println!("{bar} {foo}", foo = "hello", bar = "world");
| ^^^^^^^
error: aborting due to 14 previous errors
error: aborting due to 11 previous errors

3
tests/ui/write_literal.rs
View File

@ -24,12 +24,9 @@ fn main() {
writeln!(&mut v, "{number:>0width$}", number = 1, width = 6);
// these should throw warnings
writeln!(&mut v, "{} of {:b} people know binary, the other half doesn't", 1, 2);
write!(&mut v, "Hello {}", "world");
writeln!(&mut v, "Hello {} {}", world, "world");
writeln!(&mut v, "Hello {}", "world");
writeln!(&mut v, "10 / 4 is {}", 2.5);
writeln!(&mut v, "2 + 1 = {}", 3);
// positional args don't change the fact
// that we're using a literal -- this should

46
tests/ui/write_literal.stderr
View File

@ -1,88 +1,70 @@
error: literal with an empty format string
--> $DIR/write_literal.rs:27:79
--> $DIR/write_literal.rs:27:32
|
LL | writeln!(&mut v, "{} of {:b} people know binary, the other half doesn't", 1, 2);
| ^
LL | write!(&mut v, "Hello {}", "world");
| ^^^^^^^
|
= note: `-D clippy::write-literal` implied by `-D warnings`
error: literal with an empty format string
--> $DIR/write_literal.rs:28:32
|
LL | write!(&mut v, "Hello {}", "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/write_literal.rs:29:44
--> $DIR/write_literal.rs:28:44
|
LL | writeln!(&mut v, "Hello {} {}", world, "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/write_literal.rs:30:34
--> $DIR/write_literal.rs:29:34
|
LL | writeln!(&mut v, "Hello {}", "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/write_literal.rs:31:38
|
LL | writeln!(&mut v, "10 / 4 is {}", 2.5);
| ^^^
error: literal with an empty format string
--> $DIR/write_literal.rs:32:36
|
LL | writeln!(&mut v, "2 + 1 = {}", 3);
| ^
error: literal with an empty format string
--> $DIR/write_literal.rs:37:33
--> $DIR/write_literal.rs:34:33
|
LL | writeln!(&mut v, "{0} {1}", "hello", "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/write_literal.rs:37:42
--> $DIR/write_literal.rs:34:42
|
LL | writeln!(&mut v, "{0} {1}", "hello", "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/write_literal.rs:38:33
--> $DIR/write_literal.rs:35:33
|
LL | writeln!(&mut v, "{1} {0}", "hello", "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/write_literal.rs:38:42
--> $DIR/write_literal.rs:35:42
|
LL | writeln!(&mut v, "{1} {0}", "hello", "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/write_literal.rs:41:43
--> $DIR/write_literal.rs:38:43
|
LL | writeln!(&mut v, "{foo} {bar}", foo = "hello", bar = "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/write_literal.rs:41:58
--> $DIR/write_literal.rs:38:58
|
LL | writeln!(&mut v, "{foo} {bar}", foo = "hello", bar = "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/write_literal.rs:42:43
--> $DIR/write_literal.rs:39:43
|
LL | writeln!(&mut v, "{bar} {foo}", foo = "hello", bar = "world");
| ^^^^^^^
error: literal with an empty format string
--> $DIR/write_literal.rs:42:58
--> $DIR/write_literal.rs:39:58
|
LL | writeln!(&mut v, "{bar} {foo}", foo = "hello", bar = "world");
| ^^^^^^^
error: aborting due to 14 previous errors
error: aborting due to 11 previous errors