From f2d9acfc019c132635d419f14f6b09ee222a1103 Mon Sep 17 00:00:00 2001
From: Takayuki Maeda <takoyaki0316@gmail.com>
Date: Mon, 13 Jun 2022 15:48:40 +0900
Subject: [PATCH] remove unnecessary `to_string` and `String::new`
---
clippy_lints/src/almost_complete_letter_range.rs | 2 +-
clippy_lints/src/as_underscore.rs | 2 +-
clippy_lints/src/empty_structs_with_brackets.rs | 2 +-
clippy_lints/src/large_const_arrays.rs | 2 +-
clippy_lints/src/manual_async_fn.rs | 2 +-
clippy_lints/src/matches/match_same_arms.rs | 2 +-
clippy_lints/src/methods/str_splitn.rs | 4 ++--
clippy_lints/src/methods/unnecessary_iter_cloned.rs | 2 +-
clippy_lints/src/needless_late_init.rs | 4 ++--
clippy_lints/src/needless_pass_by_value.rs | 2 +-
clippy_lints/src/redundant_clone.rs | 2 +-
clippy_lints/src/transmute/transmute_float_to_int.rs | 2 +-
clippy_lints/src/transmute/transmute_ptr_to_ptr.rs | 2 +-
clippy_lints/src/transmute/transmute_ref_to_ref.rs | 2 +-
clippy_lints/src/transmute/useless_transmute.rs | 4 ++--
clippy_utils/src/attrs.rs | 2 +-
16 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/clippy_lints/src/almost_complete_letter_range.rs b/clippy_lints/src/almost_complete_letter_range.rs
index b364a370efa..59a7c535400 100644
--- a/clippy_lints/src/almost_complete_letter_range.rs
+++ b/clippy_lints/src/almost_complete_letter_range.rs
@@ -90,7 +90,7 @@ fn check_range(cx: &EarlyContext<'_>, span: Span, start: &Expr, end: &Expr, sugg
diag.span_suggestion(
span,
"use an inclusive range",
- sugg.to_owned(),
+ sugg,
Applicability::MaybeIncorrect,
);
}
diff --git a/clippy_lints/src/as_underscore.rs b/clippy_lints/src/as_underscore.rs
index 464be4218dd..0bdef9d0a7e 100644
--- a/clippy_lints/src/as_underscore.rs
+++ b/clippy_lints/src/as_underscore.rs
@@ -63,7 +63,7 @@ impl<'tcx> LateLintPass<'tcx> for AsUnderscore {
diag.span_suggestion(
ty.span,
"consider giving the type explicitly",
- format!("{}", ty_resolved),
+ ty_resolved,
Applicability::MachineApplicable,
);
}
diff --git a/clippy_lints/src/empty_structs_with_brackets.rs b/clippy_lints/src/empty_structs_with_brackets.rs
index 8430e7b4c82..08bf80a4229 100644
--- a/clippy_lints/src/empty_structs_with_brackets.rs
+++ b/clippy_lints/src/empty_structs_with_brackets.rs
@@ -44,7 +44,7 @@ impl EarlyLintPass for EmptyStructsWithBrackets {
diagnostic.span_suggestion_hidden(
span_after_ident,
"remove the brackets",
- ";".to_string(),
+ ";",
Applicability::MachineApplicable);
},
);
diff --git a/clippy_lints/src/large_const_arrays.rs b/clippy_lints/src/large_const_arrays.rs
index 27db6388136..14f84a832aa 100644
--- a/clippy_lints/src/large_const_arrays.rs
+++ b/clippy_lints/src/large_const_arrays.rs
@@ -75,7 +75,7 @@ impl<'tcx> LateLintPass<'tcx> for LargeConstArrays {
diag.span_suggestion(
sugg_span,
"make this a static item",
- "static".to_string(),
+ "static",
Applicability::MachineApplicable,
);
}
diff --git a/clippy_lints/src/manual_async_fn.rs b/clippy_lints/src/manual_async_fn.rs
index babc6fab3c0..c70b1c261b6 100644
--- a/clippy_lints/src/manual_async_fn.rs
+++ b/clippy_lints/src/manual_async_fn.rs
@@ -86,7 +86,7 @@ impl<'tcx> LateLintPass<'tcx> for ManualAsyncFn {
diag.span_suggestion(
block.span,
"move the body of the async block to the enclosing function",
- body_snip.to_string(),
+ body_snip,
Applicability::MachineApplicable
);
}
diff --git a/clippy_lints/src/matches/match_same_arms.rs b/clippy_lints/src/matches/match_same_arms.rs
index a96a7fe55f3..4f8baf7efb0 100644
--- a/clippy_lints/src/matches/match_same_arms.rs
+++ b/clippy_lints/src/matches/match_same_arms.rs
@@ -113,7 +113,7 @@ pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, arms: &'tcx [Arm<'_>]) {
diag.span_suggestion(
arm1.span,
"try removing the arm",
- String::new(),
+ "",
Applicability::MaybeIncorrect,
)
.help("or try changing either arm body")
diff --git a/clippy_lints/src/methods/str_splitn.rs b/clippy_lints/src/methods/str_splitn.rs
index 90651a6ba04..4ac738272d0 100644
--- a/clippy_lints/src/methods/str_splitn.rs
+++ b/clippy_lints/src/methods/str_splitn.rs
@@ -176,13 +176,13 @@ fn check_manual_split_once_indirect(
diag.span_suggestion(
first.span,
&remove_msg,
- String::new(),
+ "",
app,
);
diag.span_suggestion(
second.span,
&remove_msg,
- String::new(),
+ "",
app,
);
});
diff --git a/clippy_lints/src/methods/unnecessary_iter_cloned.rs b/clippy_lints/src/methods/unnecessary_iter_cloned.rs
index 7a39557ad57..19037093e20 100644
--- a/clippy_lints/src/methods/unnecessary_iter_cloned.rs
+++ b/clippy_lints/src/methods/unnecessary_iter_cloned.rs
@@ -85,7 +85,7 @@ pub fn check_for_loop_iter(
match addr_of_expr.kind {
ExprKind::AddrOf(_, _, referent) => {
let span = addr_of_expr.span.with_hi(referent.span.lo());
- diag.span_suggestion(span, "remove this `&`", String::new(), applicability);
+ diag.span_suggestion(span, "remove this `&`", "", applicability);
}
_ => unreachable!(),
}
diff --git a/clippy_lints/src/needless_late_init.rs b/clippy_lints/src/needless_late_init.rs
index 26c694a71fe..d8982ffcf66 100644
--- a/clippy_lints/src/needless_late_init.rs
+++ b/clippy_lints/src/needless_late_init.rs
@@ -318,7 +318,7 @@ fn check<'tcx>(
diag.span_suggestion(
usage.stmt.span.shrink_to_hi(),
"add a semicolon after the `if` expression",
- ";".to_string(),
+ ";",
applicability,
);
}
@@ -353,7 +353,7 @@ fn check<'tcx>(
diag.span_suggestion(
usage.stmt.span.shrink_to_hi(),
"add a semicolon after the `match` expression",
- ";".to_string(),
+ ";",
applicability,
);
}
diff --git a/clippy_lints/src/needless_pass_by_value.rs b/clippy_lints/src/needless_pass_by_value.rs
index f423be4b67a..8b273aca7d0 100644
--- a/clippy_lints/src/needless_pass_by_value.rs
+++ b/clippy_lints/src/needless_pass_by_value.rs
@@ -258,7 +258,7 @@ impl<'tcx> LateLintPass<'tcx> for NeedlessPassByValue {
diag.span_suggestion(
input.span,
"consider changing the type to",
- "&str".to_string(),
+ "&str",
Applicability::Unspecified,
);
diff --git a/clippy_lints/src/redundant_clone.rs b/clippy_lints/src/redundant_clone.rs
index 249f11f9850..3b11cbc3760 100644
--- a/clippy_lints/src/redundant_clone.rs
+++ b/clippy_lints/src/redundant_clone.rs
@@ -255,7 +255,7 @@ impl<'tcx> LateLintPass<'tcx> for RedundantClone {
diag.span_suggestion(
sugg_span,
"remove this",
- String::new(),
+ "",
app,
);
if clone_usage.cloned_used {
diff --git a/clippy_lints/src/transmute/transmute_float_to_int.rs b/clippy_lints/src/transmute/transmute_float_to_int.rs
index d5ef86dc4e5..1bde977cfa2 100644
--- a/clippy_lints/src/transmute/transmute_float_to_int.rs
+++ b/clippy_lints/src/transmute/transmute_float_to_int.rs
@@ -55,7 +55,7 @@ pub(super) fn check<'tcx>(
sugg
};
- diag.span_suggestion(e.span, "consider using", sugg.to_string(), Applicability::Unspecified);
+ diag.span_suggestion(e.span, "consider using", sugg, Applicability::Unspecified);
},
);
true
diff --git a/clippy_lints/src/transmute/transmute_ptr_to_ptr.rs b/clippy_lints/src/transmute/transmute_ptr_to_ptr.rs
index d712b33de9e..31a9b69ca15 100644
--- a/clippy_lints/src/transmute/transmute_ptr_to_ptr.rs
+++ b/clippy_lints/src/transmute/transmute_ptr_to_ptr.rs
@@ -25,7 +25,7 @@ pub(super) fn check<'tcx>(
|diag| {
if let Some(arg) = sugg::Sugg::hir_opt(cx, arg) {
let sugg = arg.as_ty(cx.tcx.mk_ptr(*to_ty));
- diag.span_suggestion(e.span, "try", sugg.to_string(), Applicability::Unspecified);
+ diag.span_suggestion(e.span, "try", sugg, Applicability::Unspecified);
}
},
);
diff --git a/clippy_lints/src/transmute/transmute_ref_to_ref.rs b/clippy_lints/src/transmute/transmute_ref_to_ref.rs
index 786e7bfc56f..707a11d361c 100644
--- a/clippy_lints/src/transmute/transmute_ref_to_ref.rs
+++ b/clippy_lints/src/transmute/transmute_ref_to_ref.rs
@@ -73,7 +73,7 @@ pub(super) fn check<'tcx>(
diag.span_suggestion(
e.span,
"try",
- sugg.to_string(),
+ sugg,
Applicability::Unspecified,
);
},
diff --git a/clippy_lints/src/transmute/useless_transmute.rs b/clippy_lints/src/transmute/useless_transmute.rs
index a0d104e2390..fc9227b76f0 100644
--- a/clippy_lints/src/transmute/useless_transmute.rs
+++ b/clippy_lints/src/transmute/useless_transmute.rs
@@ -46,7 +46,7 @@ pub(super) fn check<'tcx>(
arg.as_ty(cx.tcx.mk_ptr(rty_and_mut)).as_ty(to_ty)
};
- diag.span_suggestion(e.span, "try", sugg.to_string(), Applicability::Unspecified);
+ diag.span_suggestion(e.span, "try", sugg, Applicability::Unspecified);
}
},
);
@@ -64,7 +64,7 @@ pub(super) fn check<'tcx>(
diag.span_suggestion(
e.span,
"try",
- arg.as_ty(&to_ty.to_string()).to_string(),
+ arg.as_ty(&to_ty.to_string()),
Applicability::Unspecified,
);
}
diff --git a/clippy_utils/src/attrs.rs b/clippy_utils/src/attrs.rs
index 49318849d58..186bba09d20 100644
--- a/clippy_utils/src/attrs.rs
+++ b/clippy_utils/src/attrs.rs
@@ -92,7 +92,7 @@ pub fn get_attr<'a>(
diag.span_suggestion(
attr_segments[1].ident.span,
"consider using",
- new_name.to_string(),
+ new_name,
Applicability::MachineApplicable,
);
diag.emit();