nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-25 16:24:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rollup merge of #119402 - est31:fix_if_guard_unused, r=compiler-errors

Browse Source 
Also walk bindings created by if-let guards

This change makes the `unused_variables` lint pick up unused bindings created by if-let guards.

Fixes #119383
This commit is contained in:
Matthias Krüger 2023-12-29 11:19:28 +01:00 committed by GitHub
commit efd9fd66ba
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
compiler/rustc_passes/src/liveness.rs
View File

@ -1328,6 +1328,9 @@ impl<'a, 'tcx> Visitor<'tcx> for Liveness<'a, 'tcx> {
fn visit_arm(&mut self, arm: &'tcx hir::Arm<'tcx>) {
self.check_unused_vars_in_pat(arm.pat, None, None, |_, _, _, _| {});
if let Some(hir::Guard::IfLet(let_expr)) = arm.guard {
self.check_unused_vars_in_pat(let_expr.pat, None, None, |_, _, _, _| {});
}
intravisit::walk_arm(self, arm);
}
}

9
tests/ui/lint/unused/issue-119383.rs Normal file
View File

@ -0,0 +1,9 @@
#![feature(if_let_guard)]
#![deny(unused_variables)]
fn main() {
match () {
() if let Some(b) = Some(()) => {} //~ ERROR unused variable: `b`
_ => {}
}
}

14
tests/ui/lint/unused/issue-119383.stderr Normal file
View File

@ -0,0 +1,14 @@
error: unused variable: `b`
--> $DIR/issue-119383.rs:6:24
|
LL | () if let Some(b) = Some(()) => {}
| ^ help: if this is intentional, prefix it with an underscore: `_b`
|
note: the lint level is defined here
--> $DIR/issue-119383.rs:2:9
|
LL | #![deny(unused_variables)]
| ^^^^^^^^^^^^^^^^
error: aborting due to 1 previous error