nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-02-06 03:52:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rollup merge of #97569 - thomcc:fill_with_isnt_memset, r=Amanieu

Browse Source 
Remove `memset` alias from `fill_with`.

In https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/Unsafe.20and.20Safe.20versions.20of.20APIs.20both.20getting.20the.20same.20alias/near/284413029 `@Amanieu` pointed out that we had this, which is not really right.

In our guidelines we say that we will "not add an alias for a function that's only somewhat similar or related", which applies here. Memset doesn't take a closure, not even conceptually.
This commit is contained in:
Dylan DPC 2022-05-31 07:57:37 +02:00 committed by GitHub
commit efd2519e10
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
library/core/src/slice/mod.rs
View File

@ -3083,7 +3083,6 @@ impl<T> [T] {
/// buf.fill_with(Default::default); /// buf.fill_with(Default::default);
/// assert_eq!(buf, vec![0; 10]); /// assert_eq!(buf, vec![0; 10]);
/// ``` /// ```
#[doc(alias = "memset")]
#[stable(feature = "slice_fill_with", since = "1.51.0")] #[stable(feature = "slice_fill_with", since = "1.51.0")]
pub fn fill_with<F>(&mut self, mut f: F) pub fn fill_with<F>(&mut self, mut f: F)
where where