From efac2e5eff55b32660c41877ccb170c77672e477 Mon Sep 17 00:00:00 2001 From: Oliver Scherer Date: Mon, 20 May 2019 12:31:53 +0200 Subject: [PATCH] Revert "Turn off two tests broken due to #4108" This reverts commit 568a3ecfc3eebe099c1ffe44c3d9afdc5d445fd2. --- tests/ui/crashes/used_underscore_binding_macro.rs | 3 --- tests/ui/serde.rs | 5 +---- tests/ui/serde.stderr | 15 +++++++++++++++ 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/tests/ui/crashes/used_underscore_binding_macro.rs b/tests/ui/crashes/used_underscore_binding_macro.rs index 7e4e9dce8bc..265017c51d9 100644 --- a/tests/ui/crashes/used_underscore_binding_macro.rs +++ b/tests/ui/crashes/used_underscore_binding_macro.rs @@ -1,7 +1,5 @@ // run-pass -// FIXME(#4108) -/* #![allow(clippy::useless_attribute)] //issue #2910 #[macro_use] @@ -19,6 +17,5 @@ struct MacroAttributesTest { fn macro_attributes_test() { let _ = MacroAttributesTest { _foo: 0 }; } -*/ fn main() {} diff --git a/tests/ui/serde.rs b/tests/ui/serde.rs index 2b56195df87..5843344eba8 100644 --- a/tests/ui/serde.rs +++ b/tests/ui/serde.rs @@ -1,6 +1,3 @@ -// FIXME(#4108) - -/* #![warn(clippy::serde_api_misuse)] #![allow(dead_code)] @@ -46,5 +43,5 @@ impl<'de> serde::de::Visitor<'de> for B { unimplemented!() } } -*/ + fn main() {} diff --git a/tests/ui/serde.stderr b/tests/ui/serde.stderr index e69de29bb2d..760c9c9908a 100644 --- a/tests/ui/serde.stderr +++ b/tests/ui/serde.stderr @@ -0,0 +1,15 @@ +error: you should not implement `visit_string` without also implementing `visit_str` + --> $DIR/serde.rs:39:5 + | +LL | / fn visit_string(self, _v: String) -> Result +LL | | where +LL | | E: serde::de::Error, +LL | | { +LL | | unimplemented!() +LL | | } + | |_____^ + | + = note: `-D clippy::serde-api-misuse` implied by `-D warnings` + +error: aborting due to previous error +