mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-22 14:55:26 +00:00
Optimize PartialOrd le
Closes https://github.com/rust-lang/rust/issues/73338 This change stops default implementation of `le()` method from generating jumps.
This commit is contained in:
parent
836c317426
commit
ed0d8fa3e8
@ -981,7 +981,8 @@ pub trait PartialOrd<Rhs: ?Sized = Self>: PartialEq<Rhs> {
|
||||
#[must_use]
|
||||
#[stable(feature = "rust1", since = "1.0.0")]
|
||||
fn le(&self, other: &Rhs) -> bool {
|
||||
matches!(self.partial_cmp(other), Some(Less | Equal))
|
||||
// Pattern `Some(Less | Eq)` optimizes worse than negating `None | Some(Greater)`.
|
||||
!matches!(self.partial_cmp(other), None | Some(Greater))
|
||||
}
|
||||
|
||||
/// This method tests greater than (for `self` and `other`) and is used by the `>` operator.
|
||||
|
39
src/test/codegen/issue-73338-effecient-cmp.rs
Normal file
39
src/test/codegen/issue-73338-effecient-cmp.rs
Normal file
@ -0,0 +1,39 @@
|
||||
// This test checks that comparison operation
|
||||
// generated by #[derive(PartialOrd)]
|
||||
// doesn't contain jumps for C enums
|
||||
|
||||
// compile-flags: -Copt-level=3
|
||||
|
||||
#![crate_type="lib"]
|
||||
|
||||
#[repr(u32)]
|
||||
#[derive(Copy, Clone, Eq, PartialEq, PartialOrd)]
|
||||
pub enum Foo {
|
||||
Zero,
|
||||
One,
|
||||
Two,
|
||||
}
|
||||
|
||||
#[no_mangle]
|
||||
pub fn compare_less(a: Foo, b: Foo)->bool{
|
||||
// CHECK-NOT: br {{.*}}
|
||||
a < b
|
||||
}
|
||||
|
||||
#[no_mangle]
|
||||
pub fn compare_le(a: Foo, b: Foo)->bool{
|
||||
// CHECK-NOT: br {{.*}}
|
||||
a <= b
|
||||
}
|
||||
|
||||
#[no_mangle]
|
||||
pub fn compare_ge(a: Foo, b: Foo)->bool{
|
||||
// CHECK-NOT: br {{.*}}
|
||||
a >= b
|
||||
}
|
||||
|
||||
#[no_mangle]
|
||||
pub fn compare_greater(a: Foo, b: Foo)->bool{
|
||||
// CHECK-NOT: br {{.*}}
|
||||
a > b
|
||||
}
|
Loading…
Reference in New Issue
Block a user