From 2d4e79e1e6e39719d566bb58e04a7839588238fe Mon Sep 17 00:00:00 2001 From: Edwin Cheng Date: Mon, 17 Feb 2020 12:57:24 +0800 Subject: [PATCH] Introduce AsMacroCall trait --- crates/ra_hir/src/source_analyzer.rs | 16 ++--- crates/ra_hir_def/src/body.rs | 48 ++++++-------- crates/ra_hir_def/src/lib.rs | 63 +++++++++++++++++- crates/ra_hir_def/src/nameres/collector.rs | 77 +++++++++++----------- 4 files changed, 127 insertions(+), 77 deletions(-) diff --git a/crates/ra_hir/src/source_analyzer.rs b/crates/ra_hir/src/source_analyzer.rs index bb9a35c5d12..94d5b4cfd73 100644 --- a/crates/ra_hir/src/source_analyzer.rs +++ b/crates/ra_hir/src/source_analyzer.rs @@ -15,11 +15,9 @@ use hir_def::{ }, expr::{ExprId, PatId}, resolver::{self, resolver_for_scope, Resolver, TypeNs, ValueNs}, - DefWithBodyId, TraitId, -}; -use hir_expand::{ - hygiene::Hygiene, name::AsName, AstId, HirFileId, InFile, MacroCallId, MacroCallKind, + AsMacroCall, DefWithBodyId, TraitId, }; +use hir_expand::{hygiene::Hygiene, name::AsName, HirFileId, InFile, MacroCallId}; use hir_ty::{InEnvironment, InferenceResult, TraitEnvironment}; use ra_syntax::{ ast::{self, AstNode}, @@ -363,12 +361,10 @@ impl SourceAnalyzer { db: &impl HirDatabase, macro_call: InFile<&ast::MacroCall>, ) -> Option { - let def = self.resolve_macro_call(db, macro_call)?.id; - let ast_id = AstId::new( - macro_call.file_id, - db.ast_id_map(macro_call.file_id).ast_id(macro_call.value), - ); - Some(Expansion { macro_call_id: def.as_call_id(db, MacroCallKind::FnLike(ast_id)) }) + let macro_call_id = macro_call.as_call_id(db, |path| { + self.resolver.resolve_path_as_macro(db, &path).map(|it| it.into()) + })?; + Some(Expansion { macro_call_id }) } } diff --git a/crates/ra_hir_def/src/body.rs b/crates/ra_hir_def/src/body.rs index 142c52d3580..010d35e55b1 100644 --- a/crates/ra_hir_def/src/body.rs +++ b/crates/ra_hir_def/src/body.rs @@ -7,9 +7,7 @@ use std::{mem, ops::Index, sync::Arc}; use drop_bomb::DropBomb; use either::Either; -use hir_expand::{ - ast_id_map::AstIdMap, hygiene::Hygiene, AstId, HirFileId, InFile, MacroCallKind, MacroDefId, -}; +use hir_expand::{ast_id_map::AstIdMap, hygiene::Hygiene, AstId, HirFileId, InFile, MacroDefId}; use ra_arena::{map::ArenaMap, Arena}; use ra_prof::profile; use ra_syntax::{ast, AstNode, AstPtr}; @@ -23,7 +21,7 @@ use crate::{ nameres::CrateDefMap, path::{ModPath, Path}, src::HasSource, - DefWithBodyId, HasModule, Lookup, ModuleId, + AsMacroCall, DefWithBodyId, HasModule, Lookup, ModuleId, }; pub(crate) struct Expander { @@ -51,30 +49,26 @@ impl Expander { db: &DB, macro_call: ast::MacroCall, ) -> Option<(Mark, T)> { - let ast_id = AstId::new( - self.current_file_id, - db.ast_id_map(self.current_file_id).ast_id(¯o_call), - ); + let macro_call = InFile::new(self.current_file_id, ¯o_call); - if let Some(path) = macro_call.path().and_then(|path| self.parse_mod_path(path)) { - if let Some(def) = self.resolve_path_as_macro(db, &path) { - let call_id = def.as_call_id(db, MacroCallKind::FnLike(ast_id)); - let file_id = call_id.as_file(); - if let Some(node) = db.parse_or_expand(file_id) { - if let Some(expr) = T::cast(node) { - log::debug!("macro expansion {:#?}", expr.syntax()); + if let Some(call_id) = + macro_call.as_call_id(db, |path| self.resolve_path_as_macro(db, &path)) + { + let file_id = call_id.as_file(); + if let Some(node) = db.parse_or_expand(file_id) { + if let Some(expr) = T::cast(node) { + log::debug!("macro expansion {:#?}", expr.syntax()); - let mark = Mark { - file_id: self.current_file_id, - ast_id_map: mem::take(&mut self.ast_id_map), - bomb: DropBomb::new("expansion mark dropped"), - }; - self.hygiene = Hygiene::new(db, file_id); - self.current_file_id = file_id; - self.ast_id_map = db.ast_id_map(file_id); + let mark = Mark { + file_id: self.current_file_id, + ast_id_map: mem::take(&mut self.ast_id_map), + bomb: DropBomb::new("expansion mark dropped"), + }; + self.hygiene = Hygiene::new(db, file_id); + self.current_file_id = file_id; + self.ast_id_map = db.ast_id_map(file_id); - return Some((mark, expr)); - } + return Some((mark, expr)); } } } @@ -99,10 +93,6 @@ impl Expander { Path::from_src(path, &self.hygiene) } - fn parse_mod_path(&mut self, path: ast::Path) -> Option { - ModPath::from_src(path, &self.hygiene) - } - fn resolve_path_as_macro(&self, db: &impl DefDatabase, path: &ModPath) -> Option { self.crate_def_map .resolve_path(db, self.module.local_id, path, BuiltinShadowMode::Other) diff --git a/crates/ra_hir_def/src/lib.rs b/crates/ra_hir_def/src/lib.rs index feb3a300d58..aa0b558b8e5 100644 --- a/crates/ra_hir_def/src/lib.rs +++ b/crates/ra_hir_def/src/lib.rs @@ -46,7 +46,10 @@ mod marks; use std::hash::Hash; -use hir_expand::{ast_id_map::FileAstId, AstId, HirFileId, InFile, MacroDefId}; +use hir_expand::{ + ast_id_map::FileAstId, db::AstDatabase, hygiene::Hygiene, AstId, HirFileId, InFile, + MacroCallId, MacroCallKind, MacroDefId, +}; use ra_arena::{impl_arena_id, RawId}; use ra_db::{impl_intern_key, salsa, CrateId}; use ra_syntax::{ast, AstNode}; @@ -413,3 +416,61 @@ impl HasModule for StaticLoc { self.container.module(db) } } + +/// A helper trait for converting to MacroCallId +pub trait AsMacroCall { + fn as_call_id( + &self, + db: &(impl db::DefDatabase + AstDatabase), + resolver: impl Fn(path::ModPath) -> Option, + ) -> Option; +} + +impl AsMacroCall for InFile<&ast::MacroCall> { + fn as_call_id( + &self, + db: &(impl db::DefDatabase + AstDatabase), + resolver: impl Fn(path::ModPath) -> Option, + ) -> Option { + let ast_id = AstId::new(self.file_id, db.ast_id_map(self.file_id).ast_id(self.value)); + let h = Hygiene::new(db, self.file_id); + let path = path::ModPath::from_src(self.value.path()?, &h)?; + + AstIdWithPath::new(ast_id.file_id, ast_id.value, path).as_call_id(db, resolver) + } +} + +/// Helper wrapper for `AstId` with `ModPath` +#[derive(Clone, Debug, Eq, PartialEq)] +struct AstIdWithPath { + pub ast_id: AstId, + pub path: path::ModPath, +} + +impl AstIdWithPath { + pub fn new(file_id: HirFileId, ast_id: FileAstId, path: path::ModPath) -> AstIdWithPath { + AstIdWithPath { ast_id: AstId::new(file_id, ast_id), path } + } +} + +impl AsMacroCall for AstIdWithPath { + fn as_call_id( + &self, + db: &impl AstDatabase, + resolver: impl Fn(path::ModPath) -> Option, + ) -> Option { + let def = resolver(self.path.clone())?; + Some(def.as_call_id(db, MacroCallKind::FnLike(self.ast_id.clone()))) + } +} + +impl AsMacroCall for AstIdWithPath { + fn as_call_id( + &self, + db: &impl AstDatabase, + resolver: impl Fn(path::ModPath) -> Option, + ) -> Option { + let def = resolver(self.path.clone())?; + Some(def.as_call_id(db, MacroCallKind::Attr(self.ast_id.clone()))) + } +} diff --git a/crates/ra_hir_def/src/nameres/collector.rs b/crates/ra_hir_def/src/nameres/collector.rs index b1f3f525dd1..51c65a5d77a 100644 --- a/crates/ra_hir_def/src/nameres/collector.rs +++ b/crates/ra_hir_def/src/nameres/collector.rs @@ -7,7 +7,7 @@ use hir_expand::{ builtin_derive::find_builtin_derive, builtin_macro::find_builtin_macro, name::{name, AsName, Name}, - HirFileId, MacroCallId, MacroCallKind, MacroDefId, MacroDefKind, + HirFileId, MacroCallId, MacroDefId, MacroDefKind, }; use ra_cfg::CfgOptions; use ra_db::{CrateId, FileId}; @@ -25,8 +25,9 @@ use crate::{ path::{ImportAlias, ModPath, PathKind}, per_ns::PerNs, visibility::Visibility, - AdtId, AstId, ConstLoc, ContainerId, EnumLoc, EnumVariantId, FunctionLoc, ImplLoc, Intern, - LocalModuleId, ModuleDefId, ModuleId, StaticLoc, StructLoc, TraitLoc, TypeAliasLoc, UnionLoc, + AdtId, AsMacroCall, AstId, AstIdWithPath, ConstLoc, ContainerId, EnumLoc, EnumVariantId, + FunctionLoc, ImplLoc, Intern, LocalModuleId, ModuleDefId, ModuleId, StaticLoc, StructLoc, + TraitLoc, TypeAliasLoc, UnionLoc, }; pub(super) fn collect_defs(db: &impl DefDatabase, mut def_map: CrateDefMap) -> CrateDefMap { @@ -99,11 +100,16 @@ struct ImportDirective { #[derive(Clone, Debug, Eq, PartialEq)] struct MacroDirective { module_id: LocalModuleId, - ast_id: AstId, - path: ModPath, + ast_id: AstIdWithPath, legacy: Option, } +#[derive(Clone, Debug, Eq, PartialEq)] +struct DeriveDirective { + module_id: LocalModuleId, + ast_id: AstIdWithPath, +} + /// Walks the tree of module recursively struct DefCollector<'a, DB> { db: &'a DB, @@ -112,7 +118,7 @@ struct DefCollector<'a, DB> { unresolved_imports: Vec, resolved_imports: Vec, unexpanded_macros: Vec, - unexpanded_attribute_macros: Vec<(LocalModuleId, AstId, ModPath)>, + unexpanded_attribute_macros: Vec, mod_dirs: FxHashMap, cfg_options: &'a CfgOptions, } @@ -515,16 +521,16 @@ where return false; } - let resolved_res = self.def_map.resolve_path_fp_with_macro( - self.db, - ResolveMode::Other, - directive.module_id, - &directive.path, - BuiltinShadowMode::Module, - ); - - if let Some(def) = resolved_res.resolved_def.take_macros() { - let call_id = def.as_call_id(self.db, MacroCallKind::FnLike(directive.ast_id)); + if let Some(call_id) = directive.ast_id.as_call_id(self.db, |path| { + let resolved_res = self.def_map.resolve_path_fp_with_macro( + self.db, + ResolveMode::Other, + directive.module_id, + &path, + BuiltinShadowMode::Module, + ); + resolved_res.resolved_def.take_macros() + }) { resolved.push((directive.module_id, call_id)); res = ReachedFixedPoint::No; return false; @@ -532,12 +538,11 @@ where true }); - attribute_macros.retain(|(module_id, ast_id, path)| { - let resolved_res = self.resolve_attribute_macro(path); - - if let Some(def) = resolved_res { - let call_id = def.as_call_id(self.db, MacroCallKind::Attr(*ast_id)); - resolved.push((*module_id, call_id)); + attribute_macros.retain(|directive| { + if let Some(call_id) = + directive.ast_id.as_call_id(self.db, |path| self.resolve_attribute_macro(&path)) + { + resolved.push((directive.module_id, call_id)); res = ReachedFixedPoint::No; return false; } @@ -833,20 +838,22 @@ where }; let path = ModPath::from_tt_ident(ident); - let ast_id = AstId::new(self.file_id, def.kind.ast_id()); - self.def_collector.unexpanded_attribute_macros.push((self.module_id, ast_id, path)); + let ast_id = AstIdWithPath::new(self.file_id, def.kind.ast_id(), path); + self.def_collector + .unexpanded_attribute_macros + .push(DeriveDirective { module_id: self.module_id, ast_id }); } } } fn collect_macro(&mut self, mac: &raw::MacroData) { - let ast_id = AstId::new(self.file_id, mac.ast_id); + let mut ast_id = AstIdWithPath::new(self.file_id, mac.ast_id, mac.path.clone()); // Case 0: builtin macros if mac.builtin { if let Some(name) = &mac.name { let krate = self.def_collector.def_map.krate; - if let Some(macro_id) = find_builtin_macro(name, krate, ast_id) { + if let Some(macro_id) = find_builtin_macro(name, krate, ast_id.ast_id) { self.def_collector.define_macro( self.module_id, name.clone(), @@ -862,7 +869,7 @@ where if is_macro_rules(&mac.path) { if let Some(name) = &mac.name { let macro_id = MacroDefId { - ast_id: Some(ast_id), + ast_id: Some(ast_id.ast_id), krate: Some(self.def_collector.def_map.krate), kind: MacroDefKind::Declarative, }; @@ -872,15 +879,13 @@ where } // Case 2: try to resolve in legacy scope and expand macro_rules - if let Some(macro_def) = mac.path.as_ident().and_then(|name| { - self.def_collector.def_map[self.module_id].scope.get_legacy_macro(&name) + if let Some(macro_call_id) = ast_id.as_call_id(self.def_collector.db, |path| { + path.as_ident().and_then(|name| { + self.def_collector.def_map[self.module_id].scope.get_legacy_macro(&name) + }) }) { - let macro_call_id = - macro_def.as_call_id(self.def_collector.db, MacroCallKind::FnLike(ast_id)); - self.def_collector.unexpanded_macros.push(MacroDirective { module_id: self.module_id, - path: mac.path.clone(), ast_id, legacy: Some(macro_call_id), }); @@ -890,14 +895,12 @@ where // Case 3: resolve in module scope, expand during name resolution. // We rewrite simple path `macro_name` to `self::macro_name` to force resolve in module scope only. - let mut path = mac.path.clone(); - if path.is_ident() { - path.kind = PathKind::Super(0); + if ast_id.path.is_ident() { + ast_id.path.kind = PathKind::Super(0); } self.def_collector.unexpanded_macros.push(MacroDirective { module_id: self.module_id, - path, ast_id, legacy: None, });