mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-24 07:44:10 +00:00
address some review comments
This commit is contained in:
parent
ccc4747f46
commit
d38766ed96
@ -718,15 +718,12 @@ fn check_cast<'tcx>(cx: &LateContext<'tcx>, e: &'tcx Expr<'_>, from_ty: Ty<'tcx>
|
||||
Inherited::build(cx.tcx, local_def_id).enter(|inherited| {
|
||||
let fn_ctxt = FnCtxt::new(
|
||||
&inherited,
|
||||
// TODO should we try to get the correct ParamEnv?
|
||||
ty::ParamEnv::empty(),
|
||||
cx.param_env,
|
||||
hir_id
|
||||
);
|
||||
|
||||
// If we already have errors, we can't be sure we can pointer cast.
|
||||
if fn_ctxt.errors_reported_since_creation() {
|
||||
return None;
|
||||
}
|
||||
assert!(!fn_ctxt.errors_reported_since_creation());
|
||||
|
||||
if let Ok(check) = CastCheck::new(
|
||||
&fn_ctxt,
|
||||
@ -746,4 +743,4 @@ fn check_cast<'tcx>(cx: &LateContext<'tcx>, e: &'tcx Expr<'_>, from_ty: Ty<'tcx>
|
||||
None
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user