Replace the loop with recursive calls for clarity

This commit is contained in:
Nadrieril 2024-02-16 04:45:35 +01:00
parent 998d0e9793
commit cd0fc78c95

View File

@ -1212,36 +1212,39 @@ impl<'a, 'tcx> Builder<'a, 'tcx> {
candidates: &mut [&mut Candidate<'_, 'tcx>], candidates: &mut [&mut Candidate<'_, 'tcx>],
fake_borrows: &mut Option<FxIndexSet<Place<'tcx>>>, fake_borrows: &mut Option<FxIndexSet<Place<'tcx>>>,
) { ) {
// The candidates are sorted by priority. Check to see whether the match candidates {
// higher priority candidates (and hence at the front of the slice) [] => {
// have satisfied all their match pairs. // If there are no candidates that still need testing, we're done. Since all matches are
let fully_matched = candidates.iter().take_while(|c| c.match_pairs.is_empty()).count(); // exhaustive, execution should never reach this point.
debug!("match_candidates: {:?} candidates fully matched", fully_matched);
let (matched_candidates, unmatched_candidates) = candidates.split_at_mut(fully_matched);
for candidate in matched_candidates.iter_mut() {
start_block = self.select_matched_candidate(candidate, start_block, fake_borrows);
}
// If there are no candidates that still need testing, we're
// done. Since all matches are exhaustive, execution should
// never reach this point.
if unmatched_candidates.is_empty() {
let source_info = self.source_info(span); let source_info = self.source_info(span);
self.cfg.goto(start_block, source_info, otherwise_block); self.cfg.goto(start_block, source_info, otherwise_block);
return;
} }
[first, remaining @ ..] if first.match_pairs.is_empty() => {
// Test for the remaining candidates. // The first candidate has satisfied all its match pairs; we link it up and continue
// with the remaining candidates.
start_block = self.select_matched_candidate(first, start_block, fake_borrows);
self.match_simplified_candidates(
span,
scrutinee_span,
start_block,
otherwise_block,
remaining,
fake_borrows,
)
}
candidates => {
// The first candidate has some unsatisfied match pairs; we proceed to do more tests.
self.test_candidates_with_or( self.test_candidates_with_or(
span, span,
scrutinee_span, scrutinee_span,
unmatched_candidates, candidates,
start_block, start_block,
otherwise_block, otherwise_block,
fake_borrows, fake_borrows,
); );
} }
}
}
/// Link up matched candidates. /// Link up matched candidates.
/// ///