nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-05-10 00:47:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge #2388

Browse Source 
2388: Show missing struct fields in the error message r=matklad a=Frizi

This provides the most interesting information about the "missing structure fields" error directly to the user.

Co-authored-by: Frizi <frizi09@gmail.com>
This commit is contained in:
bors[bot] 2019-11-25 13:42:36 +00:00 committed by GitHub
commit be00d74c7b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
crates/ra_hir/src/diagnostics.rs
View File

@ -39,7 +39,12 @@ pub struct MissingFields {
impl Diagnostic for MissingFields { impl Diagnostic for MissingFields {
fn message(&self) -> String { fn message(&self) -> String {
"fill structure fields".to_string() use std::fmt::Write;
let mut message = String::from("Missing structure fields:\n");
for field in &self.missed_fields {
write!(message, "- {}\n", field).unwrap();
}
message
} }
fn source(&self) -> Source<SyntaxNodePtr> { fn source(&self) -> Source<SyntaxNodePtr> {
Source { file_id: self.file, value: self.field_list.into() } Source { file_id: self.file, value: self.field_list.into() }

3
crates/ra_hir/src/ty/tests.rs
View File

@ -4832,7 +4832,8 @@ fn no_such_field_diagnostics() {
assert_snapshot!(diagnostics, @r###" assert_snapshot!(diagnostics, @r###"
"baz: 62": no such field "baz: 62": no such field
"{\n foo: 92,\n baz: 62,\n }": fill structure fields "{\n foo: 92,\n baz: 62,\n }": Missing structure fields:
- bar
"### "###
); );
} }