nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-01-22 12:43:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

suggest using double colon when using single colon in struct field type path

Browse Source
This commit is contained in:
Takayuki Maeda 2022-03-11 16:15:57 +09:00
parent d53e19540e
commit bdc3177868
3 changed files with 66 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
compiler/rustc_parse/src/parser/item.rs
View File

@ -1534,6 +1534,16 @@ impl<'a> Parser<'a> {
let name = self.parse_field_ident(adt_ty, lo)?;
self.expect_field_ty_separator()?;
let ty = self.parse_ty()?;
if self.token.kind == token::Colon && self.look_ahead(1, |tok| tok.kind != token::Colon) {
self.struct_span_err(self.token.span, "found single colon in a struct field type path")
.span_suggestion_verbose(
self.token.span,
"maybe you meant to write a path separator here",
"::".to_string(),
Applicability::MaybeIncorrect,
)
.emit();
}
if self.token.kind == token::Eq {
self.bump();
let const_expr = self.parse_anon_const_expr()?;

20
src/test/ui/suggestions/sturct-field-type-including-single-colon.rs Normal file
View File

@ -0,0 +1,20 @@
mod foo {
struct A;
mod bar {
struct B;
}
}
struct Foo {
a: foo:A,
//~^ ERROR found single colon in a struct field type path
//~| expected `,`, or `}`, found `:`
}
struct Bar {
b: foo::bar:B,
//~^ ERROR found single colon in a struct field type path
//~| expected `,`, or `}`, found `:`
}
fn main() {}

36
src/test/ui/suggestions/sturct-field-type-including-single-colon.stderr Normal file
View File

@ -0,0 +1,36 @@
error: found single colon in a struct field type path
--> $DIR/sturct-field-type-including-single-colon.rs:9:11
|
LL | a: foo:A,
| ^
|
help: maybe you meant to write a path separator here
|
LL | a: foo::A,
| ~~
error: expected `,`, or `}`, found `:`
--> $DIR/sturct-field-type-including-single-colon.rs:9:11
|
LL | a: foo:A,
| ^
error: found single colon in a struct field type path
--> $DIR/sturct-field-type-including-single-colon.rs:15:16
|
LL | b: foo::bar:B,
| ^
|
help: maybe you meant to write a path separator here
|
LL | b: foo::bar::B,
| ~~
error: expected `,`, or `}`, found `:`
--> $DIR/sturct-field-type-including-single-colon.rs:15:16
|
LL | b: foo::bar:B,
| ^
error: aborting due to 4 previous errors