From bb8e1764bb31bc63a6b61f446e28bb567015de01 Mon Sep 17 00:00:00 2001 From: marmeladema Date: Tue, 1 Sep 2020 13:11:28 +0100 Subject: [PATCH] Simplify some match statements on `DefPathDataName' --- compiler/rustc_codegen_llvm/src/debuginfo/namespace.rs | 9 ++------- compiler/rustc_codegen_ssa/src/debuginfo/type_names.rs | 9 +-------- compiler/rustc_lint/src/context.rs | 9 ++------- 3 files changed, 5 insertions(+), 22 deletions(-) diff --git a/compiler/rustc_codegen_llvm/src/debuginfo/namespace.rs b/compiler/rustc_codegen_llvm/src/debuginfo/namespace.rs index 661d13ead83..512fc87905e 100644 --- a/compiler/rustc_codegen_llvm/src/debuginfo/namespace.rs +++ b/compiler/rustc_codegen_llvm/src/debuginfo/namespace.rs @@ -7,7 +7,7 @@ use crate::common::CodegenCx; use crate::llvm; use crate::llvm::debuginfo::DIScope; use rustc_hir::def_id::DefId; -use rustc_hir::definitions::{DefPathData, DefPathDataName}; +use rustc_hir::definitions::DefPathData; use rustc_span::symbol::Symbol; pub fn mangled_name_of_instance<'a, 'tcx>( @@ -30,12 +30,7 @@ pub fn item_namespace(cx: &CodegenCx<'ll, '_>, def_id: DefId) -> &'ll DIScope { let namespace_name = match def_key.disambiguated_data.data { DefPathData::CrateRoot => cx.tcx.crate_name(def_id.krate), - data => match data.name() { - DefPathDataName::Named(name) => name, - DefPathDataName::Anon { namespace } => { - Symbol::intern(&format!("{{{{{}}}}}", namespace)) - } - }, + data => Symbol::intern(&data.to_string()), }; let namespace_name = namespace_name.as_str(); diff --git a/compiler/rustc_codegen_ssa/src/debuginfo/type_names.rs b/compiler/rustc_codegen_ssa/src/debuginfo/type_names.rs index 5642cc526ae..45ecb793387 100644 --- a/compiler/rustc_codegen_ssa/src/debuginfo/type_names.rs +++ b/compiler/rustc_codegen_ssa/src/debuginfo/type_names.rs @@ -3,7 +3,6 @@ use rustc_data_structures::fx::FxHashSet; use rustc_hir as hir; use rustc_hir::def_id::DefId; -use rustc_hir::definitions::DefPathDataName; use rustc_middle::ty::{self, subst::SubstsRef, Ty, TyCtxt}; use std::fmt::Write; @@ -231,13 +230,7 @@ pub fn push_debuginfo_type_name<'tcx>( if qualified { output.push_str(&tcx.crate_name(def_id.krate).as_str()); for path_element in tcx.def_path(def_id).data { - output.push_str("::"); - match path_element.data.name() { - DefPathDataName::Named(name) => output.push_str(&name.as_str()), - DefPathDataName::Anon { namespace } => { - write!(output, "{{{{{}}}}}", namespace).unwrap() - } - } + write!(output, "::{}", path_element.data).unwrap(); } } else { output.push_str(&tcx.item_name(def_id).as_str()); diff --git a/compiler/rustc_lint/src/context.rs b/compiler/rustc_lint/src/context.rs index 776c3c83e02..7a3035e5b46 100644 --- a/compiler/rustc_lint/src/context.rs +++ b/compiler/rustc_lint/src/context.rs @@ -26,7 +26,7 @@ use rustc_errors::{struct_span_err, Applicability}; use rustc_hir as hir; use rustc_hir::def::Res; use rustc_hir::def_id::{CrateNum, DefId}; -use rustc_hir::definitions::{DefPathData, DefPathDataName, DisambiguatedDefPathData}; +use rustc_hir::definitions::{DefPathData, DisambiguatedDefPathData}; use rustc_middle::lint::LintDiagnosticBuilder; use rustc_middle::middle::privacy::AccessLevels; use rustc_middle::middle::stability; @@ -846,12 +846,7 @@ impl<'tcx> LateContext<'tcx> { return Ok(path); } - path.push(match disambiguated_data.data.name() { - DefPathDataName::Named(name) => name, - DefPathDataName::Anon { namespace } => { - Symbol::intern(&format!("{{{{{}}}}}", namespace)) - } - }); + path.push(Symbol::intern(&disambiguated_data.data.to_string())); Ok(path) }