From bad05e20a35318c7790990683bcdf2d254c8059a Mon Sep 17 00:00:00 2001 From: Tim Chevalier Date: Tue, 24 May 2011 10:46:48 -0700 Subject: [PATCH] Improve nonexistent-module error message The error message for (for example) "import vec;" without "use std;" was "cyclic import", which was misleading because there were no cycles. I changed it to "cyclic import or nonexistent module", which doesn't break existing tests. --- src/comp/middle/resolve.rs | 2 +- src/test/compile-fail/bad-module.rs | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 src/test/compile-fail/bad-module.rs diff --git a/src/comp/middle/resolve.rs b/src/comp/middle/resolve.rs index 201e456dbc1..608bcf0b00a 100644 --- a/src/comp/middle/resolve.rs +++ b/src/comp/middle/resolve.rs @@ -724,7 +724,7 @@ fn lookup_import(&env e, def_id defid, namespace ns) -> option::t[def] { ret lookup_import(e, defid, ns); } case (resolving(?sp)) { - e.sess.span_err(sp, "cyclic import"); + e.sess.span_err(sp, "cyclic import or nonexistent module"); } case (resolved(?val, ?typ, ?md)) { ret alt (ns) { case (ns_value) { val } diff --git a/src/test/compile-fail/bad-module.rs b/src/test/compile-fail/bad-module.rs new file mode 100644 index 00000000000..d9d35f327f5 --- /dev/null +++ b/src/test/compile-fail/bad-module.rs @@ -0,0 +1,7 @@ +// xfail-stage0 +// error-pattern: nonexistent module +import vec; + +fn main() { + auto foo = vec.len([]); +} \ No newline at end of file