Only emit one error for use foo::self;

Currently `use foo::self;` would emit both E0429 and E0432. This
commit silence the latter one (assuming `foo` is a valid module).

Fixes #42559
This commit is contained in:
Tommy Ip 2017-06-10 10:55:19 +01:00
parent 60ac9f467c
commit b89db83e6c
4 changed files with 15 additions and 4 deletions

View File

@ -482,6 +482,16 @@ impl<'a, 'b:'a> ImportResolver<'a, 'b> {
if let Some(err) = self.finalize_import(import) {
errors = true;
if let SingleImport { source, ref result, .. } = import.subclass {
if source.name == "self" {
// Silence `unresolved import` error if E0429 is already emitted
match result.value_ns.get() {
Err(Determined) => continue,
_ => {},
}
}
}
// If the error is a single failed import then create a "fake" import
// resolution for it so that later resolve stages won't complain.
self.import_dummy_binding(import);

View File

@ -9,7 +9,6 @@
// except according to those terms.
use std::fmt::self; //~ ERROR E0429
//~^ ERROR E0432
fn main () {
}

View File

@ -13,9 +13,8 @@
mod a {
mod b {
use self as A; //~ ERROR `self` imports are only allowed within a { } list
//~^ ERROR unresolved import `self` [E0432]
//~| no `self` in the root
use self as A;
//~^ ERROR `self` imports are only allowed within a { } list
use super as B;
//~^ ERROR unresolved import `super` [E0432]
//~| no `super` in the root

View File

@ -11,4 +11,7 @@
use foo::self; //~ ERROR unresolved import `foo::self`
//~^ ERROR `self` imports are only allowed within a { } list
use std::mem::self;
//~^ ERROR `self` imports are only allowed within a { } list
fn main() {}