nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-12-29 08:54:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

lint: Document the why and how of the no_mangle const lint

Browse Source
This commit is contained in:
Richo Healey 2015-02-03 12:09:45 -08:00
parent 73d5d89567
commit b6f55efd5b
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/librustc/lint/builtin.rs
View File

@ -2107,7 +2107,10 @@ impl LintPass for InvalidNoMangleItems {
}, },
ast::ItemConst(..) => { ast::ItemConst(..) => {
if attr::contains_name(it.attrs.as_slice(), "no_mangle") { if attr::contains_name(it.attrs.as_slice(), "no_mangle") {
let msg = "const items should never be #[no_mangle]"; // Const items do not refer to a particular location in memory, and therefore
// don't have anything to attach a symbol to
let msg = "const items should never be #[no_mangle], consider instead using \
`pub static`";
cx.span_lint(NO_MANGLE_CONST_ITEMS, it.span, msg); cx.span_lint(NO_MANGLE_CONST_ITEMS, it.span, msg);
} }
} }