From b4ca06558a51cf421be98e1dbb8285c7b32f6450 Mon Sep 17 00:00:00 2001
From: Joshua Nelson <jnelson@cloudflare.com>
Date: Mon, 18 Apr 2022 20:21:19 -0500
Subject: [PATCH] Remove assertion that all paths in `ShouldRun` exist
This breaks on submodules (see #96188). Disable the assertion for now until I can think of a proper
fix.
This doesn't revert any of the changes in `Step`s themselves, only what
`ShouldRun::paths` does.
---
src/bootstrap/builder.rs | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/bootstrap/builder.rs b/src/bootstrap/builder.rs
index d688f798956..965e66880f4 100644
--- a/src/bootstrap/builder.rs
+++ b/src/bootstrap/builder.rs
@@ -388,11 +388,13 @@ impl<'a> ShouldRun<'a> {
paths
.iter()
.map(|p| {
- assert!(
- self.builder.src.join(p).exists(),
- "`should_run.paths` should correspond to real on-disk paths - use `alias` if there is no relevant path: {}",
- p
- );
+ // FIXME(#96188): make sure this is actually a path.
+ // This currently breaks for paths within submodules.
+ //assert!(
+ // self.builder.src.join(p).exists(),
+ // "`should_run.paths` should correspond to real on-disk paths - use `alias` if there is no relevant path: {}",
+ // p
+ //);
TaskPath { path: p.into(), kind: Some(self.kind) }
})
.collect(),