cleanup the api

crates/ra_mbe/src/lib.rs

@@ -24,17 +24,26 @@ use ra_syntax::SmolStr;
 
 pub use tt::{Delimiter, Punct};
 
-pub use crate::{
+pub use crate::syntax_bridge::ast_to_token_tree;
-    mbe_parser::parse,
-    mbe_expander::exapnd,
-    syntax_bridge::macro_call_to_tt,
-};
 
+/// This struct contains AST for a single `macro_rules` defenition. What might
+/// be very confusing is that AST has almost exactly the same shape as
+/// `tt::TokenTree`, but there's a crucial difference: in macro rules, `$ident`
+/// and `$()*` have special meaning (see `Var` and `Repeat` data structures)
 #[derive(Debug)]
 pub struct MacroRules {
     pub(crate) rules: Vec<Rule>,
 }
 
+impl MacroRules {
+    pub fn parse(tt: &tt::Subtree) -> Option<MacroRules> {
+        mbe_parser::parse(tt)
+    }
+    pub fn expand(&self, tt: &tt::Subtree) -> Option<tt::Subtree> {
+        mbe_expander::exapnd(self, tt)
+    }
+}
+
 #[derive(Debug)]
 pub(crate) struct Rule {
     pub(crate) lhs: Subtree,
@@ -93,3 +102,55 @@ pub(crate) struct Var {
     pub(crate) text: SmolStr,
     pub(crate) kind: Option<SmolStr>,
 }
+
+#[cfg(test)]
+mod tests {
+    use ra_syntax::{ast, AstNode};
+
+    use super::*;
+
+    #[test]
+    fn test_convert_tt() {
+        let macro_definition = r#"
+macro_rules! impl_froms {
+    ($e:ident: $($v:ident),*) => {
+        $(
+            impl From<$v> for $e {
+                fn from(it: $v) -> $e {
+                    $e::$v(it)
+                }
+            }
+        )*
+    }
+}
+"#;
+
+        let macro_invocation = r#"
+impl_froms!(TokenTree: Leaf, Subtree);
+"#;
+
+        let source_file = ast::SourceFile::parse(macro_definition);
+        let macro_definition = source_file
+            .syntax()
+            .descendants()
+            .find_map(ast::MacroCall::cast)
+            .unwrap();
+
+        let source_file = ast::SourceFile::parse(macro_invocation);
+        let macro_invocation = source_file
+            .syntax()
+            .descendants()
+            .find_map(ast::MacroCall::cast)
+            .unwrap();
+
+        let definition_tt = ast_to_token_tree(macro_definition.token_tree().unwrap()).unwrap();
+        let invocation_tt = ast_to_token_tree(macro_invocation.token_tree().unwrap()).unwrap();
+        let rules = crate::MacroRules::parse(&definition_tt).unwrap();
+        let expansion = rules.expand(&invocation_tt).unwrap();
+        assert_eq!(
+        expansion.to_string(),
+        "impl From < Leaf > for TokenTree {fn from (it : Leaf) -> TokenTree {TokenTree :: Leaf (it)}} \
+         impl From < Subtree > for TokenTree {fn from (it : Subtree) -> TokenTree {TokenTree :: Subtree (it)}}"
+    )
+    }
+}

crates/ra_mbe/src/mbe_parser.rs

@@ -1,10 +1,9 @@
-use crate::tt_cursor::TtCursor;
-
 /// This module parses a raw `tt::TokenStream` into macro-by-example token
 /// stream. This is a *mostly* identify function, expect for handling of
 /// `$var:tt_kind` and `$(repeat),*` constructs.
+use crate::tt_cursor::TtCursor;
 
-pub fn parse(tt: &tt::Subtree) -> Option<crate::MacroRules> {
+pub(crate) fn parse(tt: &tt::Subtree) -> Option<crate::MacroRules> {
     let mut parser = TtCursor::new(tt);
     let mut rules = Vec::new();
     while !parser.is_eof() {

crates/ra_mbe/src/syntax_bridge.rs

@@ -1,8 +1,7 @@
 use ra_syntax::{ast, AstNode, SyntaxNode, SyntaxKind::*};
 
-pub fn macro_call_to_tt(call: &ast::MacroCall) -> Option<tt::Subtree> {
+pub fn ast_to_token_tree(ast: &ast::TokenTree) -> Option<tt::Subtree> {
-    let tt = call.token_tree()?;
+    convert_tt(ast.syntax())
-    convert_tt(tt.syntax())
 }
 
 fn convert_tt(tt: &SyntaxNode) -> Option<tt::Subtree> {
@@ -66,48 +65,3 @@ fn convert_tt(tt: &SyntaxNode) -> Option<tt::Subtree> {
     };
     Some(res)
 }
-
-#[test]
-fn test_convert_tt() {
-    let macro_definition = r#"
-macro_rules! impl_froms {
-    ($e:ident: $($v:ident),*) => {
-        $(
-            impl From<$v> for $e {
-                fn from(it: $v) -> $e {
-                    $e::$v(it)
-                }
-            }
-        )*
-    }
-}
-"#;
-
-    let macro_invocation = r#"
-impl_froms!(TokenTree: Leaf, Subtree);
-"#;
-
-    let source_file = ast::SourceFile::parse(macro_definition);
-    let macro_definition = source_file
-        .syntax()
-        .descendants()
-        .find_map(ast::MacroCall::cast)
-        .unwrap();
-
-    let source_file = ast::SourceFile::parse(macro_invocation);
-    let macro_invocation = source_file
-        .syntax()
-        .descendants()
-        .find_map(ast::MacroCall::cast)
-        .unwrap();
-
-    let definition_tt = macro_call_to_tt(macro_definition).unwrap();
-    let invocation_tt = macro_call_to_tt(macro_invocation).unwrap();
-    let mbe = crate::parse(&definition_tt).unwrap();
-    let expansion = crate::exapnd(&mbe, &invocation_tt).unwrap();
-    assert_eq!(
-        expansion.to_string(),
-        "impl From < Leaf > for TokenTree {fn from (it : Leaf) -> TokenTree {TokenTree :: Leaf (it)}} \
-         impl From < Subtree > for TokenTree {fn from (it : Subtree) -> TokenTree {TokenTree :: Subtree (it)}}"
-    )
-}