nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-01-30 00:23:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary clone

Browse Source
This commit is contained in:
Joshua Nelson 2020-09-11 13:49:45 -04:00
parent 57250eff55
commit b2a5a7a8c2
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/librustdoc/passes/collect_intra_doc_links.rs
View File

@ -1056,12 +1056,9 @@ impl<'a, 'tcx> DocFolder for LinkCollector<'a, 'tcx> {
}),
};
let mut candidates_iter =
candidates.iter().filter_map(|res| res.as_ref().ok());
let len = candidates_iter.clone().count();
let len = candidates.iter().filter(|res| res.is_ok()).count();
if len == 0 {
drop(candidates_iter);
resolution_failure(
self,
&item,
@ -1076,12 +1073,10 @@ impl<'a, 'tcx> DocFolder for LinkCollector<'a, 'tcx> {
}
if len == 1 {
candidates_iter.next().unwrap().clone()
candidates.into_iter().filter_map(|res| res.ok()).next().unwrap()
} else if len == 2 && is_derive_trait_collision(&candidates) {
drop(candidates_iter);
candidates.type_ns.unwrap()
} else {
drop(candidates_iter);
if is_derive_trait_collision(&candidates) {
candidates.macro_ns = Err(ResolutionFailure::Dummy);
}