558: kill last cancelables r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
This commit is contained in:
bors[bot] 2019-01-15 18:18:01 +00:00
commit ab46f8abf1
3 changed files with 7 additions and 8 deletions

View File

@ -15,7 +15,6 @@ use ra_syntax::{
use crate::{
AnalysisChange,
Cancelable,
CrateId, db, Diagnostic, FileId, FilePosition, FileRange, FileSystemEdit,
Query, RootChange, SourceChange, SourceFileEdit,
symbol_index::{LibrarySymbolsQuery, FileSymbol},
@ -158,7 +157,7 @@ impl db::RootDatabase {
}
}
pub(crate) fn diagnostics(&self, file_id: FileId) -> Cancelable<Vec<Diagnostic>> {
pub(crate) fn diagnostics(&self, file_id: FileId) -> Vec<Diagnostic> {
let syntax = self.source_file(file_id);
let mut res = ra_ide_api_light::diagnostics(&syntax)
@ -219,7 +218,7 @@ impl db::RootDatabase {
res.push(diag)
}
};
Ok(res)
res
}
pub(crate) fn assists(&self, frange: FileRange) -> Vec<SourceChange> {

View File

@ -429,7 +429,7 @@ impl Analysis {
/// Computes syntax highlighting for the given file.
pub fn highlight(&self, file_id: FileId) -> Cancelable<Vec<HighlightedRange>> {
self.db
.catch_canceled(|db| syntax_highlighting::highlight(db, file_id))?
.catch_canceled(|db| syntax_highlighting::highlight(db, file_id))
}
/// Computes completions at the given position.
@ -448,7 +448,7 @@ impl Analysis {
/// Computes the set of diagnostics for the given file.
pub fn diagnostics(&self, file_id: FileId) -> Cancelable<Vec<Diagnostic>> {
self.with_db(|db| db.diagnostics(file_id))?
self.with_db(|db| db.diagnostics(file_id))
}
/// Computes the type of the expression at the given position.

View File

@ -2,11 +2,11 @@ use ra_syntax::{ast, AstNode,};
use ra_db::SyntaxDatabase;
use crate::{
FileId, Cancelable, HighlightedRange,
FileId, HighlightedRange,
db::RootDatabase,
};
pub(crate) fn highlight(db: &RootDatabase, file_id: FileId) -> Cancelable<Vec<HighlightedRange>> {
pub(crate) fn highlight(db: &RootDatabase, file_id: FileId) -> Vec<HighlightedRange> {
let source_file = db.source_file(file_id);
let mut res = ra_ide_api_light::highlight(source_file.syntax());
for macro_call in source_file
@ -28,7 +28,7 @@ pub(crate) fn highlight(db: &RootDatabase, file_id: FileId) -> Cancelable<Vec<Hi
res.extend(mapped_ranges);
}
}
Ok(res)
res
}
#[cfg(test)]