nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-05-14 02:49:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix clippy warning

Browse Source
This commit is contained in:
yonip23 2022-05-11 23:16:49 +03:00
parent 344888a582
commit a791205e76
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clippy_lints/src/rc_clone_in_vec_init.rs
View File

@ -92,6 +92,8 @@ fn construct_lint_suggestions(
fn elem_snippet(cx: &LateContext<'_>, elem: &Expr<'_>, symbol_name: &str) -> String {
let elem_snippet = snippet(cx, elem.span, "..").to_string();
if elem_snippet.contains('\n') {
// This string must be found in `elem_snippet`, otherwise we won't be constructing
// the snippet in the first place.
let reference_creation = format!("{symbol_name}::new");
let (code_until_reference_creation, _right) = elem_snippet.split_once(&reference_creation).unwrap();
@ -132,14 +134,14 @@ fn emit_lint(cx: &LateContext<'_>, symbol: Symbol, lint_span: Span, elem: &Expr<
let suggestions = construct_lint_suggestions(cx, lint_span, symbol_name, elem, len);
diag.note(format!("each element will point to the same `{symbol_name}` instance"));
suggestions.iter().for_each(|suggestion| {
for suggestion in suggestions {
diag.span_suggestion(
lint_span,
&suggestion.message,
&suggestion.snippet,
Applicability::Unspecified,
);
});
}
},
);
}