mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-24 15:54:15 +00:00
Auto merge of #4947 - rust-lang:doc-main-extern-crate, r=flip1995
Avoid needless_doctest_main on 'extern crate' This fixes #4927. r? @flip1995 changelog: none
This commit is contained in:
commit
a68ef55dbf
@ -389,8 +389,10 @@ fn check_doc<'a, Events: Iterator<Item = (pulldown_cmark::Event<'a>, Range<usize
|
||||
headers
|
||||
}
|
||||
|
||||
static LEAVE_MAIN_PATTERNS: &[&str] = &["static", "fn main() {}", "extern crate"];
|
||||
|
||||
fn check_code(cx: &LateContext<'_, '_>, text: &str, span: Span) {
|
||||
if text.contains("fn main() {") && !(text.contains("static") || text.contains("fn main() {}")) {
|
||||
if text.contains("fn main() {") && !LEAVE_MAIN_PATTERNS.iter().any(|p| text.contains(p)) {
|
||||
span_lint(cx, NEEDLESS_DOCTEST_MAIN, span, "needless `fn main` in doctest");
|
||||
}
|
||||
}
|
||||
|
@ -25,6 +25,15 @@ fn bad_doctest() {}
|
||||
/// assert_eq!(42, ANSWER);
|
||||
/// }
|
||||
/// ```
|
||||
///
|
||||
/// Neither should this lint because of `extern crate`:
|
||||
/// ```
|
||||
/// #![feature(test)]
|
||||
/// extern crate test;
|
||||
/// fn main() {
|
||||
/// assert_eq(1u8, test::black_box(1));
|
||||
/// }
|
||||
/// ```
|
||||
fn no_false_positives() {}
|
||||
|
||||
fn main() {
|
||||
|
Loading…
Reference in New Issue
Block a user