nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-02-16 17:03:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed non-declarative-nor-opaque macros effective privacy.

Browse Source 
cc @petrochenkov
This commit is contained in:
Daniel Henry-Mantilla 2021-01-05 15:16:56 +01:00
parent 255f107cac
commit a4de27aeec
1 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
compiler/rustc_privacy/src/lib.rs
View File

@ -832,21 +832,15 @@ impl Visitor<'tcx> for EmbargoVisitor<'tcx> {
}
fn visit_macro_def(&mut self, md: &'tcx hir::MacroDef<'tcx>) {
// HACK (or fix?): a
// ```rust,ignore (dummy example)
// mod private {
// #[rustc_macro_transparency(semitransparent)]
// pub macro m { … }
// }
// ```
// is *not* `Public`ly reachable and yet this shortcut would express
// that.
// FIXME!
if md.ast.macro_rules
&& attr::find_transparency(&self.tcx.sess, &md.attrs, md.ast.macro_rules).0
!= Transparency::Opaque
// Non-opaque macros cannot make other items more accessible than they already are.
if attr::find_transparency(&self.tcx.sess, &md.attrs, md.ast.macro_rules).0
!= Transparency::Opaque
{
self.update(md.hir_id, Some(AccessLevel::Public));
// `#[macro_export]`-ed `macro_rules!` are `Public` since they
// ignore their containing path to always appear at the crate root.
if md.ast.macro_rules {
self.update(md.hir_id, Some(AccessLevel::Public));
}
return;
}