diff --git a/src/librustc_mir/transform/check_unsafety.rs b/src/librustc_mir/transform/check_unsafety.rs index bbc7803b84d..3524255e037 100644 --- a/src/librustc_mir/transform/check_unsafety.rs +++ b/src/librustc_mir/transform/check_unsafety.rs @@ -386,10 +386,13 @@ fn is_enclosed(tcx: TyCtxt, if used_unsafe.contains(&parent_id) { Some(("block".to_string(), parent_id)) } else if let Some(hir::map::NodeItem(&hir::Item { - node: hir::ItemFn(_, hir::Unsafety::Unsafe, _, _, _, _), + node: hir::ItemFn(_, fn_unsafety, _, _, _, _), .. })) = tcx.hir.find(parent_id) { - Some(("fn".to_string(), parent_id)) + match fn_unsafety { + hir::Unsafety::Unsafe => Some(("fn".to_string(), parent_id)), + hir::Unsafety::Normal => None, + } } else { is_enclosed(tcx, used_unsafe, parent_id) } diff --git a/src/test/compile-fail/issue-48131.rs b/src/test/compile-fail/issue-48131.rs new file mode 100644 index 00000000000..9eb567a5d3e --- /dev/null +++ b/src/test/compile-fail/issue-48131.rs @@ -0,0 +1,39 @@ +// Copyright 2018 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// This note is annotated because the purpose of the test +// is to ensure that certain other notes are not generated. +#![deny(unused_unsafe)] //~ NOTE + +// (test that no note is generated on this unsafe fn) +pub unsafe fn a() { + fn inner() { + unsafe { /* unnecessary */ } //~ ERROR unnecessary `unsafe` + //~^ NOTE + } + + inner() +} + +pub fn b() { + // (test that no note is generated on this unsafe block) + unsafe { + fn inner() { + unsafe { /* unnecessary */ } //~ ERROR unnecessary `unsafe` + //~^ NOTE + } + + let () = ::std::mem::uninitialized(); + + inner() + } +} + +fn main() {}