nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-05-06 23:17:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

arena,std,serialize: remove some unnecessary transmutes.

Browse Source 
`as`-able transmutes, duplication and manual slice decomposition are
silly.
This commit is contained in:
Huon Wilson 2014-02-21 23:56:09 +11:00
parent 4cc723dc22
commit 9e8d5aa29e
4 changed files with 9 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/libarena/lib.rs
View File

@ -167,13 +167,12 @@ unsafe fn destroy_chunk(chunk: &Chunk) {
// is necessary in order to properly do cleanup if a failure occurs // is necessary in order to properly do cleanup if a failure occurs
// during an initializer. // during an initializer.
#[inline] #[inline]
unsafe fn bitpack_tydesc_ptr(p: *TyDesc, is_done: bool) -> uint { fn bitpack_tydesc_ptr(p: *TyDesc, is_done: bool) -> uint {
let p_bits: uint = transmute(p); p as uint | (is_done as uint)
p_bits | (is_done as uint)
} }
#[inline] #[inline]
unsafe fn un_bitpack_tydesc_ptr(p: uint) -> (*TyDesc, bool) { fn un_bitpack_tydesc_ptr(p: uint) -> (*TyDesc, bool) {
(transmute(p & !1), p & 1 == 1) ((p & !1) as *TyDesc, p & 1 == 1)
} }
impl Arena { impl Arena {

4
src/libserialize/ebml.rs
View File

@ -161,9 +161,7 @@ pub mod reader {
]; ];
unsafe { unsafe {
let (ptr, _): (*u8, uint) = transmute(data); let ptr = data.as_ptr().offset(start as int) as *i32;
let ptr = ptr.offset(start as int);
let ptr: *i32 = transmute(ptr);
let val = from_be32(*ptr) as u32; let val = from_be32(*ptr) as u32;
let i = (val >> 28u) as uint; let i = (val >> 28u) as uint;

6
src/libstd/num/f32.rs
View File

@ -351,10 +351,8 @@ impl Float for f32 {
static EXP_MASK: u32 = 0x7f800000; static EXP_MASK: u32 = 0x7f800000;
static MAN_MASK: u32 = 0x007fffff; static MAN_MASK: u32 = 0x007fffff;
match ( let bits: u32 = unsafe {::cast::transmute(*self)};
unsafe { ::cast::transmute::<f32,u32>(*self) } & MAN_MASK, match (bits & MAN_MASK, bits & EXP_MASK) {
unsafe { ::cast::transmute::<f32,u32>(*self) } & EXP_MASK,
) {
(0, 0) => FPZero, (0, 0) => FPZero,
(_, 0) => FPSubnormal, (_, 0) => FPSubnormal,
(0, EXP_MASK) => FPInfinite, (0, EXP_MASK) => FPInfinite,

6
src/libstd/num/f64.rs
View File

@ -353,10 +353,8 @@ impl Float for f64 {
static EXP_MASK: u64 = 0x7ff0000000000000; static EXP_MASK: u64 = 0x7ff0000000000000;
static MAN_MASK: u64 = 0x000fffffffffffff; static MAN_MASK: u64 = 0x000fffffffffffff;
match ( let bits: u64 = unsafe {::cast::transmute(*self)};
unsafe { ::cast::transmute::<f64,u64>(*self) } & MAN_MASK, match (bits & MAN_MASK, bits & EXP_MASK) {
unsafe { ::cast::transmute::<f64,u64>(*self) } & EXP_MASK,
) {
(0, 0) => FPZero, (0, 0) => FPZero,
(_, 0) => FPSubnormal, (_, 0) => FPSubnormal,
(0, EXP_MASK) => FPInfinite, (0, EXP_MASK) => FPInfinite,