nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-30 18:53:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

reword dbg_macro labels

Browse Source
This commit is contained in:
Andy Russell 2023-01-01 02:41:45 -05:00
parent 6ccd4ebd5b
commit 9aef1a264a
No known key found for this signature in database
GPG Key ID: BE2221033EDBC374
3 changed files with 49 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
clippy_lints/src/dbg_macro.rs
View File

@ -10,11 +10,11 @@ use rustc_span::sym;
declare_clippy_lint! { declare_clippy_lint! {
/// ### What it does /// ### What it does
/// Checks for usage of dbg!() macro. /// Checks for usage of the [`dbg!`](https://doc.rust-lang.org/std/macro.dbg.html) macro.
/// ///
/// ### Why is this bad? /// ### Why is this bad?
/// `dbg!` macro is intended as a debugging tool. It /// The `dbg!` macro is intended as a debugging tool. It should not be present in released
/// should not be in version control. /// software or committed to a version control system.
/// ///
/// ### Example /// ### Example
/// ```rust,ignore /// ```rust,ignore
@ -91,8 +91,8 @@ impl LateLintPass<'_> for DbgMacro {
cx, cx,
DBG_MACRO, DBG_MACRO,
macro_call.span, macro_call.span,
"`dbg!` macro is intended as a debugging tool", "the `dbg!` macro is intended as a debugging tool",
"ensure to avoid having uses of it in version control", "remove the invocation before committing it to a version control system",
suggestion, suggestion,
applicability, applicability,
); );

36
tests/ui-toml/dbg_macro/dbg_macro.stderr
View File

@ -1,99 +1,99 @@
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:5:22 --> $DIR/dbg_macro.rs:5:22
| |
LL | if let Some(n) = dbg!(n.checked_sub(4)) { n } else { n } LL | if let Some(n) = dbg!(n.checked_sub(4)) { n } else { n }
| ^^^^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^^^
| |
= note: `-D clippy::dbg-macro` implied by `-D warnings` = note: `-D clippy::dbg-macro` implied by `-D warnings`
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | if let Some(n) = n.checked_sub(4) { n } else { n } LL | if let Some(n) = n.checked_sub(4) { n } else { n }
| ~~~~~~~~~~~~~~~~ | ~~~~~~~~~~~~~~~~
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:9:8 --> $DIR/dbg_macro.rs:9:8
| |
LL | if dbg!(n <= 1) { LL | if dbg!(n <= 1) {
| ^^^^^^^^^^^^ | ^^^^^^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | if n <= 1 { LL | if n <= 1 {
| ~~~~~~ | ~~~~~~
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:10:9 --> $DIR/dbg_macro.rs:10:9
| |
LL | dbg!(1) LL | dbg!(1)
| ^^^^^^^ | ^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | 1 LL | 1
| |
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:12:9 --> $DIR/dbg_macro.rs:12:9
| |
LL | dbg!(n * factorial(n - 1)) LL | dbg!(n * factorial(n - 1))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | n * factorial(n - 1) LL | n * factorial(n - 1)
| |
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:17:5 --> $DIR/dbg_macro.rs:17:5
| |
LL | dbg!(42); LL | dbg!(42);
| ^^^^^^^^ | ^^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | 42; LL | 42;
| ~~ | ~~
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:18:5 --> $DIR/dbg_macro.rs:18:5
| |
LL | dbg!(dbg!(dbg!(42))); LL | dbg!(dbg!(dbg!(42)));
| ^^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | dbg!(dbg!(42)); LL | dbg!(dbg!(42));
| ~~~~~~~~~~~~~~ | ~~~~~~~~~~~~~~
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:19:14 --> $DIR/dbg_macro.rs:19:14
| |
LL | foo(3) + dbg!(factorial(4)); LL | foo(3) + dbg!(factorial(4));
| ^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | foo(3) + factorial(4); LL | foo(3) + factorial(4);
| ~~~~~~~~~~~~ | ~~~~~~~~~~~~
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:20:5 --> $DIR/dbg_macro.rs:20:5
| |
LL | dbg!(1, 2, dbg!(3, 4)); LL | dbg!(1, 2, dbg!(3, 4));
| ^^^^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | (1, 2, dbg!(3, 4)); LL | (1, 2, dbg!(3, 4));
| ~~~~~~~~~~~~~~~~~~ | ~~~~~~~~~~~~~~~~~~
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:21:5 --> $DIR/dbg_macro.rs:21:5
| |
LL | dbg!(1, 2, 3, 4, 5); LL | dbg!(1, 2, 3, 4, 5);
| ^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | (1, 2, 3, 4, 5); LL | (1, 2, 3, 4, 5);
| ~~~~~~~~~~~~~~~ | ~~~~~~~~~~~~~~~

52
tests/ui/dbg_macro.stderr
View File

@ -1,143 +1,143 @@
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:5:22 --> $DIR/dbg_macro.rs:5:22
| |
LL | if let Some(n) = dbg!(n.checked_sub(4)) { n } else { n } LL | if let Some(n) = dbg!(n.checked_sub(4)) { n } else { n }
| ^^^^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^^^
| |
= note: `-D clippy::dbg-macro` implied by `-D warnings` = note: `-D clippy::dbg-macro` implied by `-D warnings`
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | if let Some(n) = n.checked_sub(4) { n } else { n } LL | if let Some(n) = n.checked_sub(4) { n } else { n }
| ~~~~~~~~~~~~~~~~ | ~~~~~~~~~~~~~~~~
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:9:8 --> $DIR/dbg_macro.rs:9:8
| |
LL | if dbg!(n <= 1) { LL | if dbg!(n <= 1) {
| ^^^^^^^^^^^^ | ^^^^^^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | if n <= 1 { LL | if n <= 1 {
| ~~~~~~ | ~~~~~~
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:10:9 --> $DIR/dbg_macro.rs:10:9
| |
LL | dbg!(1) LL | dbg!(1)
| ^^^^^^^ | ^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | 1 LL | 1
| |
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:12:9 --> $DIR/dbg_macro.rs:12:9
| |
LL | dbg!(n * factorial(n - 1)) LL | dbg!(n * factorial(n - 1))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | n * factorial(n - 1) LL | n * factorial(n - 1)
| |
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:17:5 --> $DIR/dbg_macro.rs:17:5
| |
LL | dbg!(42); LL | dbg!(42);
| ^^^^^^^^ | ^^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | 42; LL | 42;
| ~~ | ~~
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:18:5 --> $DIR/dbg_macro.rs:18:5
| |
LL | dbg!(dbg!(dbg!(42))); LL | dbg!(dbg!(dbg!(42)));
| ^^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | dbg!(dbg!(42)); LL | dbg!(dbg!(42));
| ~~~~~~~~~~~~~~ | ~~~~~~~~~~~~~~
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:19:14 --> $DIR/dbg_macro.rs:19:14
| |
LL | foo(3) + dbg!(factorial(4)); LL | foo(3) + dbg!(factorial(4));
| ^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | foo(3) + factorial(4); LL | foo(3) + factorial(4);
| ~~~~~~~~~~~~ | ~~~~~~~~~~~~
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:20:5 --> $DIR/dbg_macro.rs:20:5
| |
LL | dbg!(1, 2, dbg!(3, 4)); LL | dbg!(1, 2, dbg!(3, 4));
| ^^^^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | (1, 2, dbg!(3, 4)); LL | (1, 2, dbg!(3, 4));
| ~~~~~~~~~~~~~~~~~~ | ~~~~~~~~~~~~~~~~~~
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:21:5 --> $DIR/dbg_macro.rs:21:5
| |
LL | dbg!(1, 2, 3, 4, 5); LL | dbg!(1, 2, 3, 4, 5);
| ^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | (1, 2, 3, 4, 5); LL | (1, 2, 3, 4, 5);
| ~~~~~~~~~~~~~~~ | ~~~~~~~~~~~~~~~
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:41:9 --> $DIR/dbg_macro.rs:41:9
| |
LL | dbg!(2); LL | dbg!(2);
| ^^^^^^^ | ^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | 2; LL | 2;
| ~ | ~
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:47:5 --> $DIR/dbg_macro.rs:47:5
| |
LL | dbg!(1); LL | dbg!(1);
| ^^^^^^^ | ^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | 1; LL | 1;
| ~ | ~
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:52:5 --> $DIR/dbg_macro.rs:52:5
| |
LL | dbg!(1); LL | dbg!(1);
| ^^^^^^^ | ^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | 1; LL | 1;
| ~ | ~
error: `dbg!` macro is intended as a debugging tool error: the `dbg!` macro is intended as a debugging tool
--> $DIR/dbg_macro.rs:58:9 --> $DIR/dbg_macro.rs:58:9
| |
LL | dbg!(1); LL | dbg!(1);
| ^^^^^^^ | ^^^^^^^
| |
help: ensure to avoid having uses of it in version control help: remove the invocation before committing it to a version control system
| |
LL | 1; LL | 1;
| ~ | ~