compiletest: Remove unused llvm-cxxflags option

This commit is contained in:
Tomasz Miąsko 2020-01-24 00:00:00 +00:00
parent d857f6f1ab
commit 9a154a94b3
5 changed files with 1 additions and 11 deletions

View File

@ -1149,7 +1149,6 @@ impl Step for Compiletest {
// requires that a C++ compiler was configured which isn't always the case. // requires that a C++ compiler was configured which isn't always the case.
if !builder.config.dry_run && suite == "run-make-fulldeps" { if !builder.config.dry_run && suite == "run-make-fulldeps" {
let llvm_components = output(Command::new(&llvm_config).arg("--components")); let llvm_components = output(Command::new(&llvm_config).arg("--components"));
let llvm_cxxflags = output(Command::new(&llvm_config).arg("--cxxflags"));
cmd.arg("--cc") cmd.arg("--cc")
.arg(builder.cc(target)) .arg(builder.cc(target))
.arg("--cxx") .arg("--cxx")
@ -1157,9 +1156,7 @@ impl Step for Compiletest {
.arg("--cflags") .arg("--cflags")
.arg(builder.cflags(target, GitRepo::Rustc).join(" ")) .arg(builder.cflags(target, GitRepo::Rustc).join(" "))
.arg("--llvm-components") .arg("--llvm-components")
.arg(llvm_components.trim()) .arg(llvm_components.trim());
.arg("--llvm-cxxflags")
.arg(llvm_cxxflags.trim());
if let Some(ar) = builder.ar(target) { if let Some(ar) = builder.ar(target) {
cmd.arg("--ar").arg(ar); cmd.arg("--ar").arg(ar);
} }
@ -1197,8 +1194,6 @@ impl Step for Compiletest {
.arg("--cflags") .arg("--cflags")
.arg("") .arg("")
.arg("--llvm-components") .arg("--llvm-components")
.arg("")
.arg("--llvm-cxxflags")
.arg(""); .arg("");
} }

View File

@ -319,7 +319,6 @@ pub struct Config {
pub ar: String, pub ar: String,
pub linker: Option<String>, pub linker: Option<String>,
pub llvm_components: String, pub llvm_components: String,
pub llvm_cxxflags: String,
/// Path to a NodeJS executable. Used for JS doctests, emscripten and WASM tests /// Path to a NodeJS executable. Used for JS doctests, emscripten and WASM tests
pub nodejs: Option<String>, pub nodejs: Option<String>,

View File

@ -45,7 +45,6 @@ fn config() -> Config {
"--cxx=c++", "--cxx=c++",
"--cflags=", "--cflags=",
"--llvm-components=", "--llvm-components=",
"--llvm-cxxflags=",
"--android-cross-path=", "--android-cross-path=",
"--target=x86_64-unknown-linux-gnu", "--target=x86_64-unknown-linux-gnu",
]; ];

View File

@ -116,7 +116,6 @@ pub fn parse_config(args: Vec<String>) -> Config {
.optopt("", "ar", "path to an archiver", "PATH") .optopt("", "ar", "path to an archiver", "PATH")
.optopt("", "linker", "path to a linker", "PATH") .optopt("", "linker", "path to a linker", "PATH")
.reqopt("", "llvm-components", "list of LLVM components built in", "LIST") .reqopt("", "llvm-components", "list of LLVM components built in", "LIST")
.reqopt("", "llvm-cxxflags", "C++ flags for LLVM", "FLAGS")
.optopt("", "llvm-bin-dir", "Path to LLVM's `bin` directory", "PATH") .optopt("", "llvm-bin-dir", "Path to LLVM's `bin` directory", "PATH")
.optopt("", "nodejs", "the name of nodejs", "PATH") .optopt("", "nodejs", "the name of nodejs", "PATH")
.optopt("", "remote-test-client", "path to the remote test client", "PATH") .optopt("", "remote-test-client", "path to the remote test client", "PATH")
@ -240,7 +239,6 @@ pub fn parse_config(args: Vec<String>) -> Config {
ar: matches.opt_str("ar").unwrap_or("ar".into()), ar: matches.opt_str("ar").unwrap_or("ar".into()),
linker: matches.opt_str("linker"), linker: matches.opt_str("linker"),
llvm_components: matches.opt_str("llvm-components").unwrap(), llvm_components: matches.opt_str("llvm-components").unwrap(),
llvm_cxxflags: matches.opt_str("llvm-cxxflags").unwrap(),
nodejs: matches.opt_str("nodejs"), nodejs: matches.opt_str("nodejs"),
} }
} }

View File

@ -2651,7 +2651,6 @@ impl<'test> TestCx<'test> {
.env("HOST_RPATH_DIR", cwd.join(&self.config.compile_lib_path)) .env("HOST_RPATH_DIR", cwd.join(&self.config.compile_lib_path))
.env("TARGET_RPATH_DIR", cwd.join(&self.config.run_lib_path)) .env("TARGET_RPATH_DIR", cwd.join(&self.config.run_lib_path))
.env("LLVM_COMPONENTS", &self.config.llvm_components) .env("LLVM_COMPONENTS", &self.config.llvm_components)
.env("LLVM_CXXFLAGS", &self.config.llvm_cxxflags)
// We for sure don't want these tests to run in parallel, so make // We for sure don't want these tests to run in parallel, so make
// sure they don't have access to these vars if we run via `make` // sure they don't have access to these vars if we run via `make`
// at the top level // at the top level